Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

From: Eric Blake <eblake@redhat.com>
To: Fei Li <fli@suse.com>, Markus Armbruster <armbru@redhat.com>
Cc: David Gibson <dgibson@redhat.com>,
	qemu-devel@nongnu.org,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle
Date: Wed, 19 Dec 2018 11:29:16 -0600	[thread overview]
Message-ID: <9be94c80-623d-c1e7-2524-07b07d05446c@redhat.com> (raw)
In-Reply-To: <cc510f12-e94c-bd90-ce01-4ad5d143420f@suse.com>

On 12/19/18 6:14 AM, Fei Li wrote:

>>>>>    28 files changed, 243 insertions(+), 101 deletions(-)

>> I recommend to split this patch.  First part adds the Error ** parameter
>> to qemu_thread_create(), passing &error_abort everywhere.  No functional
>> change.  Subsequent patches then improve on &error_abort.  This way,
>> each improvement patch can be cc'ed to just that part's maintainer(s).
>> Parts you don't want to touch you simply leave at &error_abort.  Makes
>> sense?
> Yes, I think this makes sense, much clearer. :) But I am a little 
> worried about
> whether too many subsequent improvement patches (some of them are quite
> small changes) are acceptable.

A long series of small patches, where each patch is cc'd to an 
appropriate maintainer, will likely get cumulative reviews faster than a 
single monolithic patch where no one person is the expert on every line 
touched.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org