From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAC96C4338F for ; Mon, 9 Aug 2021 20:42:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C71BB6101E for ; Mon, 9 Aug 2021 20:42:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234097AbhHIUmW (ORCPT ); Mon, 9 Aug 2021 16:42:22 -0400 Received: from mxout02.lancloud.ru ([45.84.86.82]:50846 "EHLO mxout02.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233348AbhHIUmW (ORCPT ); Mon, 9 Aug 2021 16:42:22 -0400 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout02.lancloud.ru 40E0122EF73D Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: [PATCH v2 5/9] usb: host: ohci-tmio: add IRQ check From: Sergey Shtylyov To: , Greg Kroah-Hartman , Felipe Balbi , Alan Stern References: <47bacc02-4e34-3208-779c-7072a6261782@omp.ru> Organization: Open Mobile Platform Message-ID: <9bfa4edb-6852-d948-3f57-9c486e79a208@omp.ru> Date: Mon, 9 Aug 2021 23:41:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <47bacc02-4e34-3208-779c-7072a6261782@omp.ru> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The driver neglects to check the result of platform_get_irq()'s call and blithely passes the negative error codes to usb_add_hcd() (which takes *unsigned* IRQ #), causing request_irq() that it calls to fail with -EINVAL, overriding an original error code. Stop calling usb_add_hcd() with the invalid IRQ #s. Fixes: 78c73414f4f6 ("USB: ohci: add support for tmio-ohci cell") Signed-off-by: Sergey Shtylyov --- drivers/usb/host/ohci-tmio.c | 2 ++ 1 file changed, 2 insertions(+) Index: usb/drivers/usb/host/ohci-tmio.c =================================================================== --- usb.orig/drivers/usb/host/ohci-tmio.c +++ usb/drivers/usb/host/ohci-tmio.c @@ -242,6 +242,8 @@ static int ohci_hcd_tmio_drv_probe(struc if (ret < 0) goto err_enable; + if (irq < 0) + goto err_enable; ret = usb_add_hcd(hcd, irq, 0); if (ret) goto err_add_hcd;