From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754342AbcJHClE (ORCPT ); Fri, 7 Oct 2016 22:41:04 -0400 Received: from lucky1.263xmail.com ([211.157.147.133]:50490 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751882AbcJHCk4 (ORCPT ); Fri, 7 Oct 2016 22:40:56 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED4: 1 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: shawn.lin@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 2/10] mmc: sdhci: Export sdhci_start_signal_voltage_switch() in sdhci.c To: Gregory CLEMENT , Ulf Hansson , Adrian Hunter , linux-mmc@vger.kernel.org References: <9a660a813af58ad7c108fd06289513302426c9fb.1475853198.git-series.gregory.clement@free-electrons.com> Cc: Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , devicetree@vger.kernel.org, Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Ziji Hu , "Jack(SH) Zhu" , Jimmy Xu , Jisheng Zhang , Nadav Haklai , Ryan Gao , Doug Jones , Shiwu Zhang , Victor Gu , "Wei(SOCP) Liu" , Wilson Ding , Xueping Liu , Hilbert Zhang , Keji Zhang , Liuliu Zhao , Peng Zhu , Yu Cao , Romain Perier , Yehuda Yitschak , Marcin Wojtas , Hanna Hawa , Kostya Porotchkin , linux-kernel@vger.kernel.org, shawn.lin@rock-chips.com From: Shawn Lin Message-ID: <9bfe6e9a-c06e-481a-b5ea-af58820093bf@rock-chips.com> Date: Sat, 8 Oct 2016 10:40:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <9a660a813af58ad7c108fd06289513302426c9fb.1475853198.git-series.gregory.clement@free-electrons.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, ÔÚ 2016/10/7 23:22, Gregory CLEMENT дµÀ: > From: Ziji Hu > > Export sdhci_start_signal_voltage_switch() from sdhci.c. > Thus vendor sdhci driver can implement its own signal voltage > switch routine. > You can overwtite this callback within your driver itself. That is what other sdhci variant drivers did, so patch 1-3 are unnecessary. > Signed-off-by: Hu Ziji > Reviewed-by: Gregory CLEMENT > Signed-off-by: Gregory CLEMENT > --- > drivers/mmc/host/sdhci.c | 5 +++-- > drivers/mmc/host/sdhci.h | 2 ++ > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index d4bb818c52d5..2250ea22231f 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -1828,8 +1828,8 @@ static void sdhci_enable_sdio_irq(struct mmc_host *mmc, int enable) > spin_unlock_irqrestore(&host->lock, flags); > } > > -static int sdhci_start_signal_voltage_switch(struct mmc_host *mmc, > - struct mmc_ios *ios) > +int sdhci_start_signal_voltage_switch(struct mmc_host *mmc, > + struct mmc_ios *ios) > { > struct sdhci_host *host = mmc_priv(mmc); > u16 ctrl; > @@ -1921,6 +1921,7 @@ static int sdhci_start_signal_voltage_switch(struct mmc_host *mmc, > return 0; > } > } > +EXPORT_SYMBOL_GPL(sdhci_start_signal_voltage_switch); > > static int sdhci_card_busy(struct mmc_host *mmc) > { > diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h > index 21dc80b8ae3d..c38ab65b9a97 100644 > --- a/drivers/mmc/host/sdhci.h > +++ b/drivers/mmc/host/sdhci.h > @@ -687,6 +687,8 @@ void sdhci_set_bus_width(struct sdhci_host *host, int width); > void sdhci_reset(struct sdhci_host *host, u8 mask); > void sdhci_set_uhs_signaling(struct sdhci_host *host, unsigned timing); > void sdhci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios); > +int sdhci_start_signal_voltage_switch(struct mmc_host *mmc, > + struct mmc_ios *ios); > > #ifdef CONFIG_PM > extern int sdhci_suspend_host(struct sdhci_host *host); > -- Best Regards Shawn Lin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Lin Subject: Re: [PATCH 2/10] mmc: sdhci: Export sdhci_start_signal_voltage_switch() in sdhci.c Date: Sat, 8 Oct 2016 10:40:26 +0800 Message-ID: <9bfe6e9a-c06e-481a-b5ea-af58820093bf@rock-chips.com> References: <9a660a813af58ad7c108fd06289513302426c9fb.1475853198.git-series.gregory.clement@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <9a660a813af58ad7c108fd06289513302426c9fb.1475853198.git-series.gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Gregory CLEMENT , Ulf Hansson , Adrian Hunter , linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Thomas Petazzoni , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Ziji Hu , "Jack(SH) Zhu" , Jimmy Xu , Jisheng Zhang , Nadav Haklai , Ryan Gao , Doug Jones , Shiwu Zhang , Victor Gu , "Wei(SOCP) Liu" , Wilson Ding , Xueping Liu , Hilbert Zhang , Keji Zhang , Liuliu Zhao List-Id: devicetree@vger.kernel.org Hi, ÔÚ 2016/10/7 23:22, Gregory CLEMENT дµÀ: > From: Ziji Hu > > Export sdhci_start_signal_voltage_switch() from sdhci.c. > Thus vendor sdhci driver can implement its own signal voltage > switch routine. > You can overwtite this callback within your driver itself. That is what other sdhci variant drivers did, so patch 1-3 are unnecessary. > Signed-off-by: Hu Ziji > Reviewed-by: Gregory CLEMENT > Signed-off-by: Gregory CLEMENT > --- > drivers/mmc/host/sdhci.c | 5 +++-- > drivers/mmc/host/sdhci.h | 2 ++ > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index d4bb818c52d5..2250ea22231f 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -1828,8 +1828,8 @@ static void sdhci_enable_sdio_irq(struct mmc_host *mmc, int enable) > spin_unlock_irqrestore(&host->lock, flags); > } > > -static int sdhci_start_signal_voltage_switch(struct mmc_host *mmc, > - struct mmc_ios *ios) > +int sdhci_start_signal_voltage_switch(struct mmc_host *mmc, > + struct mmc_ios *ios) > { > struct sdhci_host *host = mmc_priv(mmc); > u16 ctrl; > @@ -1921,6 +1921,7 @@ static int sdhci_start_signal_voltage_switch(struct mmc_host *mmc, > return 0; > } > } > +EXPORT_SYMBOL_GPL(sdhci_start_signal_voltage_switch); > > static int sdhci_card_busy(struct mmc_host *mmc) > { > diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h > index 21dc80b8ae3d..c38ab65b9a97 100644 > --- a/drivers/mmc/host/sdhci.h > +++ b/drivers/mmc/host/sdhci.h > @@ -687,6 +687,8 @@ void sdhci_set_bus_width(struct sdhci_host *host, int width); > void sdhci_reset(struct sdhci_host *host, u8 mask); > void sdhci_set_uhs_signaling(struct sdhci_host *host, unsigned timing); > void sdhci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios); > +int sdhci_start_signal_voltage_switch(struct mmc_host *mmc, > + struct mmc_ios *ios); > > #ifdef CONFIG_PM > extern int sdhci_suspend_host(struct sdhci_host *host); > -- Best Regards Shawn Lin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: shawn.lin@rock-chips.com (Shawn Lin) Date: Sat, 8 Oct 2016 10:40:26 +0800 Subject: [PATCH 2/10] mmc: sdhci: Export sdhci_start_signal_voltage_switch() in sdhci.c In-Reply-To: <9a660a813af58ad7c108fd06289513302426c9fb.1475853198.git-series.gregory.clement@free-electrons.com> References: <9a660a813af58ad7c108fd06289513302426c9fb.1475853198.git-series.gregory.clement@free-electrons.com> Message-ID: <9bfe6e9a-c06e-481a-b5ea-af58820093bf@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, ? 2016/10/7 23:22, Gregory CLEMENT ??: > From: Ziji Hu > > Export sdhci_start_signal_voltage_switch() from sdhci.c. > Thus vendor sdhci driver can implement its own signal voltage > switch routine. > You can overwtite this callback within your driver itself. That is what other sdhci variant drivers did, so patch 1-3 are unnecessary. > Signed-off-by: Hu Ziji > Reviewed-by: Gregory CLEMENT > Signed-off-by: Gregory CLEMENT > --- > drivers/mmc/host/sdhci.c | 5 +++-- > drivers/mmc/host/sdhci.h | 2 ++ > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index d4bb818c52d5..2250ea22231f 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -1828,8 +1828,8 @@ static void sdhci_enable_sdio_irq(struct mmc_host *mmc, int enable) > spin_unlock_irqrestore(&host->lock, flags); > } > > -static int sdhci_start_signal_voltage_switch(struct mmc_host *mmc, > - struct mmc_ios *ios) > +int sdhci_start_signal_voltage_switch(struct mmc_host *mmc, > + struct mmc_ios *ios) > { > struct sdhci_host *host = mmc_priv(mmc); > u16 ctrl; > @@ -1921,6 +1921,7 @@ static int sdhci_start_signal_voltage_switch(struct mmc_host *mmc, > return 0; > } > } > +EXPORT_SYMBOL_GPL(sdhci_start_signal_voltage_switch); > > static int sdhci_card_busy(struct mmc_host *mmc) > { > diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h > index 21dc80b8ae3d..c38ab65b9a97 100644 > --- a/drivers/mmc/host/sdhci.h > +++ b/drivers/mmc/host/sdhci.h > @@ -687,6 +687,8 @@ void sdhci_set_bus_width(struct sdhci_host *host, int width); > void sdhci_reset(struct sdhci_host *host, u8 mask); > void sdhci_set_uhs_signaling(struct sdhci_host *host, unsigned timing); > void sdhci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios); > +int sdhci_start_signal_voltage_switch(struct mmc_host *mmc, > + struct mmc_ios *ios); > > #ifdef CONFIG_PM > extern int sdhci_suspend_host(struct sdhci_host *host); > -- Best Regards Shawn Lin