From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753049AbdFVMZZ (ORCPT ); Thu, 22 Jun 2017 08:25:25 -0400 Received: from mail-wr0-f174.google.com ([209.85.128.174]:36353 "EHLO mail-wr0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752103AbdFVMZX (ORCPT ); Thu, 22 Jun 2017 08:25:23 -0400 Subject: Re: [PATCH 2/2] ARM: cpuidle: Support asymmetric idle definition To: "Rafael J. Wysocki" Cc: linux-pm@vger.kernel.org, Sudeep Holla , Lorenzo Pieralisi , Leo Yan , open list References: <20170612155441.GE2261@mai> <1497282910-19085-1-git-send-email-daniel.lezcano@linaro.org> <1497282910-19085-2-git-send-email-daniel.lezcano@linaro.org> <2056969.dMlCPX6XND@aspire.rjw.lan> From: Daniel Lezcano Message-ID: <9c00e3ed-693d-4ea7-7a9f-be158b7eb7c5@linaro.org> Date: Thu, 22 Jun 2017 14:25:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <2056969.dMlCPX6XND@aspire.rjw.lan> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/06/2017 20:49, Rafael J. Wysocki wrote: > On Monday, June 12, 2017 05:55:10 PM Daniel Lezcano wrote: >> Some hardware have clusters with different idle states. The current code does >> not support this and fails as it expects all the idle states to be identical. >> >> Because of this, the Mediatek mtk8173 had to create the same idle state for a >> big.Little system and now the Hisilicon 960 is facing the same situation. >> >> Solve this by simply assuming the multiple driver will be needed for all the >> platforms using the ARM generic cpuidle driver which makes sense because of the >> different topologies we can support with a single kernel for ARM32 or ARM64. >> >> Every CPU has its own driver, so every single CPU can specify in the DT the >> idle states. >> >> This simple approach allows to support the future dynamIQ system, current SMP >> and HMP. >> >> Tested on: >> - 96boards: Hikey 620 >> - 96boards: Hikey 960 >> - 96boards: dragonboard410c >> - Mediatek 8173 >> >> Cc: Sudeep Holla >> Cc: Lorenzo Pieralisi >> Tested-by: Leo Yan >> Signed-off-by: Daniel Lezcano > > There seems to have been quite some discussion regarding this one and I'm not > sure about the resolution of it. > > I'd feel more comfortable with an ACK or Reviewed-by from Sudeep or Lorenzo here. Hi Rafael, just a gentle reminder, Sudeep acked the patch. Thanks. -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog