From: Jens Axboe <axboe@kernel.dk>
To: Jiufei Xue <jiufei.xue@linux.alibaba.com>
Cc: io-uring@vger.kernel.org
Subject: Re: [PATCH] io_uring: fix removing the wrong file in __io_sqe_files_update()
Date: Tue, 1 Sep 2020 08:04:51 -0600 [thread overview]
Message-ID: <9c0558dc-d04a-326b-beeb-be2b136af0c2@kernel.dk> (raw)
In-Reply-To: <1598938502-109415-1-git-send-email-jiufei.xue@linux.alibaba.com>
On 8/31/20 11:35 PM, Jiufei Xue wrote:
> Index here is already the position of the file in fixed_file_table, we
> should not use io_file_from_index() again to get it. Otherwise, the
> wrong file which still in use may be released unexpectedly.
Good catch! Thanks, applied.
--
Jens Axboe
prev parent reply other threads:[~2020-09-01 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 5:35 [PATCH] io_uring: fix removing the wrong file in __io_sqe_files_update() Jiufei Xue
2020-09-01 14:04 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c0558dc-d04a-326b-beeb-be2b136af0c2@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=jiufei.xue@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.