All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Khem Raj <raj.khem@gmail.com>, openembedded-core@lists.openembedded.org
Cc: Ross Burton <ross.burton@intel.com>
Subject: Re: [OE-core] [PATCH] binutils: Pregenerate autoconf files
Date: Thu, 26 Mar 2020 12:45:11 +0000	[thread overview]
Message-ID: <9c14fe5a594e1edd4cb678340ec27859ba9df864.camel@linuxfoundation.org> (raw)
In-Reply-To: <20200325231637.802324-1-raj.khem@gmail.com>

On Wed, 2020-03-25 at 16:16 -0700, Khem Raj wrote:
> libtool patch will result in configure file regeneration, instead of
> doing that at build time, do it in patch itself, this avoids running
> autoconf before configure step.
> 
> Since binutils needs specific version of autoconf ( which is 2.69 )
> this will break on systems using newer or older verisons of autoconf
> in current state.
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Cc: Ross Burton <ross.burton@intel.com>
> ---
>  meta/recipes-devtools/binutils/binutils.inc   |     8 +-
>  .../binutils/0007-Use-libtool-2.4.patch       | 26583 ++++++++++++
> ----
>  2 files changed, 20352 insertions(+), 6239 deletions(-)

Whilst I appreciate the intent here, our policy is to autoreconf most
things in general. This allows us to more easily support newer
architectures and platforms.

There is a significant build speed benefit from not autoreconf'ing
things but where do we draw the line?

I'm also worried about patches which touch both configure and
configure.ac since the timestamp changes can cause things to autoreconf
even when we're trying to avoid that. As such this is actually quite a
risky change given past bad experiences :(

I'm not completely against it but I am worried.

Cheers,

Richard


  reply	other threads:[~2020-03-26 12:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25 23:16 [PATCH] binutils: Pregenerate autoconf files Khem Raj
2020-03-26 12:45 ` Richard Purdie [this message]
2020-03-26 12:56   ` [OE-core] " Otavio Salvador
2020-03-26 17:03   ` Khem Raj
2020-03-26 18:29     ` Khem Raj
2020-03-27  0:57       ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c14fe5a594e1edd4cb678340ec27859ba9df864.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.