From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80D44C433EF for ; Tue, 19 Jul 2022 19:08:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238001AbiGSTIT (ORCPT ); Tue, 19 Jul 2022 15:08:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237815AbiGSTIR (ORCPT ); Tue, 19 Jul 2022 15:08:17 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15DE748CB9 for ; Tue, 19 Jul 2022 12:08:16 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id w17so18526677ljh.6 for ; Tue, 19 Jul 2022 12:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=nZ4qNxokp8Oym010tUgpXEtM8QhLNYwGcy1jrounDNY=; b=J2Era1ZRgZZQpzGvrd1VjlSxTixMGB0BWEy5BYEfE2PltYFcIoomXRy50m71S/cJhY BDGA8PB16da1QVvk9+gzn8gIHEO1fOpa8TcIrAnteKEe+Hc0BbCLu5iJVb9e1CCE5S6K f01QKTMJvbJeDEnU62uqNJMa430OlUXAlcwB4aBMpiCwDnHk7W4vKr7HDP1M46tSfqwG xwOOOqGBy5iwqd9+vxpnQDuORKavWQRHHV55i6ia60Ty7ql5NG5FqZu83nKrnXdfqwif 3m/LDxrAicfSs+DhvZ3CMoGPsxy9fXtvS9drfqgYPyuAr8b9bmfV1a4mamM7Y8ydstQ5 VQxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=nZ4qNxokp8Oym010tUgpXEtM8QhLNYwGcy1jrounDNY=; b=f/oiOrh/+FeFaCN1T5OzR07NahAkeZzguDRxo0IXpwsQu7VgB3IIkcCxbbiT00jwDP WJIIHhz15ZrDvybjcf3SuE0jtC112EoWOTbwxnCW0r1ckzmTXMc25M+kxiw9NjWa9dIG dIsIjTil1vIKdtJaiYOukHnXA37vi4t1H10hNV5RFKWlD0vydX0d3FmbnyR7D1yuadq7 I8IgVCXNeoHdqVQGqmqgLGMOg70biKNhAoZIPcyAXyZ7YyFpkueudnlAXp0OPmCk+cDq bPFNAi+REsaiPDUm25ootxcf0bev0k7+0zkTjKqEBEwn7j4i3jvKF6JR65u50I60kMV7 0FAQ== X-Gm-Message-State: AJIora9vE/c9grglFQNi2RP96LVBwsDYRPdZyLV0DgE2m/U3+nOn1qJR NwwPVMXnapsUpUIGGRQopIDhAg== X-Google-Smtp-Source: AGRyM1tsm/rd8/uNsLQNtDlH5vnafFeHRttp8CRT/ZcNrlz+aYtZstlK05xqQWtZz6ihy48TcXrQVg== X-Received: by 2002:a2e:870c:0:b0:25d:6833:e64d with SMTP id m12-20020a2e870c000000b0025d6833e64dmr15555680lji.71.1658257694449; Tue, 19 Jul 2022 12:08:14 -0700 (PDT) Received: from [192.168.115.193] (89-162-31-138.fiber.signal.no. [89.162.31.138]) by smtp.gmail.com with ESMTPSA id h25-20020a056512055900b0047f79c636f7sm3340153lfl.167.2022.07.19.12.08.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Jul 2022 12:08:13 -0700 (PDT) Message-ID: <9c1735bf-3f29-4bf1-f7cf-f9e211c505ac@linaro.org> Date: Tue, 19 Jul 2022 21:08:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V3 3/7] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl Content-Language: en-US To: Peng Fan , "Peng Fan (OSS)" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "l.stach@pengutronix.de" Cc: "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "laurent.pinchart@ideasonboard.com" , "marex@denx.de" , "paul.elder@ideasonboard.com" , "aford173@gmail.com" , "Markus.Niebel@ew.tq-group.com" , "alexander.stein@ew.tq-group.com" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Aisheng Dong References: <20220719055054.3855979-1-peng.fan@oss.nxp.com> <20220719055054.3855979-4-peng.fan@oss.nxp.com> <27ab24ec-61c7-cafb-6665-a16c58808649@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/07/2022 11:58, Peng Fan wrote: >>> + interconnects: >>> + items: >>> + - description: G1 decoder interconnect >>> + - description: G2 decoder interconnect >>> + - description: VC8000E encoder interconnect >>> + >>> + interconnect-names: >>> + items: >>> + - const: g1 >>> + - const: g2 >>> + - const: vc8000e >> >> Include interconnects+names in list of all properties and disallow them for >> other variants. > > I not understand well about > " Include interconnects+names in list of all properties ", could you please > explain a bit more? > > And there is already an "if" to check whether the > compatible contains " fsl,imx8mp-vpu-blk-ctrl" to make sure the interconnect > valid for i.MX8MP, so it is not valid to other variants. Defining properties in some if: clause is not really readable and maintainable. The properties should be defined in top-level properties:. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5097C433EF for ; Tue, 19 Jul 2022 19:09:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L1EOJWERpyLtq+iHriB3hCyxIRlhDWCjEITKlkAeQok=; b=AYMLe8ZVYVlU0h XcyzImT+BNJQu9JFAFuQHtcC8JI79GvlZwW5/WLq8lXWeu1HSpqgS1cNwit56LLO5+RzLTWmefmGi FMYxVoZ2nEjYS+5tPg3uWUsIizgVKmzlygoyue9+GLQfTnJfK80r/2r7v6bFa0GVFZffd0ybYXjjJ Wy+Q1raHvYKnCvN8vvTqYUEtuLyrozWTw/Vjh6URMlhgDq/MdcHnfMh4PCraHtmgpMR5RNCp9LfIM k0Q9lH5JYEZS5KwTIPW5J421OOSeZpIWNfBqQ8QLKK/YezR2CimdbSQnyKK7lRoqtJ5/tK59OEmO6 5kUn/0FWzd/w0yf4p1HA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDsZu-00BbFx-8D; Tue, 19 Jul 2022 19:08:18 +0000 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDsZs-00BbEf-85 for linux-arm-kernel@lists.infradead.org; Tue, 19 Jul 2022 19:08:17 +0000 Received: by mail-lj1-x232.google.com with SMTP id 19so18549248ljz.4 for ; Tue, 19 Jul 2022 12:08:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=nZ4qNxokp8Oym010tUgpXEtM8QhLNYwGcy1jrounDNY=; b=J2Era1ZRgZZQpzGvrd1VjlSxTixMGB0BWEy5BYEfE2PltYFcIoomXRy50m71S/cJhY BDGA8PB16da1QVvk9+gzn8gIHEO1fOpa8TcIrAnteKEe+Hc0BbCLu5iJVb9e1CCE5S6K f01QKTMJvbJeDEnU62uqNJMa430OlUXAlcwB4aBMpiCwDnHk7W4vKr7HDP1M46tSfqwG xwOOOqGBy5iwqd9+vxpnQDuORKavWQRHHV55i6ia60Ty7ql5NG5FqZu83nKrnXdfqwif 3m/LDxrAicfSs+DhvZ3CMoGPsxy9fXtvS9drfqgYPyuAr8b9bmfV1a4mamM7Y8ydstQ5 VQxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=nZ4qNxokp8Oym010tUgpXEtM8QhLNYwGcy1jrounDNY=; b=rUDDWvi03S45j2gMpeQf079J03UYbKGbadl/m3HzNG37bTK7yNH0qsSEy6c8nasCVr O3qrnXuTO8c32AN8uP6jjAHakjsl//KUbYe5/16LgsqVNWwBeHweNkDcq3dkgEzFNc69 eHwKmRH3mOV3fzb8iy3efzEL5cIl6SbgxmjjeGPMANIRVMnUQK8Dl4TJbnMVO0G/5EHM pes2yn6Kh01zVWm7UvjVnm7l5vRL6OpDKisK8HYnFDFACdjD9gNifEJg2ViL6p6NEQKf BoidOkP8X6lZzlXlODlWRwocvh4soZNkThi2KpPS6Q7Fjp2skHd/VeKYbij8FwTYq9VU 0doA== X-Gm-Message-State: AJIora+kHezAsHXFvtNzovryiLZDPLobJXQPyWQUDNI2Rentzgm/Kxaz /vcnaxJM3/5dzUCg49k2HqIAKv3hT5kT2Gx7 X-Google-Smtp-Source: AGRyM1tsm/rd8/uNsLQNtDlH5vnafFeHRttp8CRT/ZcNrlz+aYtZstlK05xqQWtZz6ihy48TcXrQVg== X-Received: by 2002:a2e:870c:0:b0:25d:6833:e64d with SMTP id m12-20020a2e870c000000b0025d6833e64dmr15555680lji.71.1658257694449; Tue, 19 Jul 2022 12:08:14 -0700 (PDT) Received: from [192.168.115.193] (89-162-31-138.fiber.signal.no. [89.162.31.138]) by smtp.gmail.com with ESMTPSA id h25-20020a056512055900b0047f79c636f7sm3340153lfl.167.2022.07.19.12.08.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Jul 2022 12:08:13 -0700 (PDT) Message-ID: <9c1735bf-3f29-4bf1-f7cf-f9e211c505ac@linaro.org> Date: Tue, 19 Jul 2022 21:08:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V3 3/7] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl Content-Language: en-US To: Peng Fan , "Peng Fan (OSS)" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "l.stach@pengutronix.de" Cc: "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "laurent.pinchart@ideasonboard.com" , "marex@denx.de" , "paul.elder@ideasonboard.com" , "aford173@gmail.com" , "Markus.Niebel@ew.tq-group.com" , "alexander.stein@ew.tq-group.com" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Aisheng Dong References: <20220719055054.3855979-1-peng.fan@oss.nxp.com> <20220719055054.3855979-4-peng.fan@oss.nxp.com> <27ab24ec-61c7-cafb-6665-a16c58808649@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220719_120816_339703_387A7D2A X-CRM114-Status: GOOD ( 12.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/07/2022 11:58, Peng Fan wrote: >>> + interconnects: >>> + items: >>> + - description: G1 decoder interconnect >>> + - description: G2 decoder interconnect >>> + - description: VC8000E encoder interconnect >>> + >>> + interconnect-names: >>> + items: >>> + - const: g1 >>> + - const: g2 >>> + - const: vc8000e >> >> Include interconnects+names in list of all properties and disallow them for >> other variants. > > I not understand well about > " Include interconnects+names in list of all properties ", could you please > explain a bit more? > > And there is already an "if" to check whether the > compatible contains " fsl,imx8mp-vpu-blk-ctrl" to make sure the interconnect > valid for i.MX8MP, so it is not valid to other variants. Defining properties in some if: clause is not really readable and maintainable. The properties should be defined in top-level properties:. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel