From: Jaroslav Kysela <perex@perex.cz>
To: kernel test robot <lkp@intel.com>,
ALSA development <alsa-devel@alsa-project.org>
Cc: Takashi Iwai <tiwai@suse.de>, Hans de Goede <hdegoede@redhat.com>,
Perry Yuan <Perry.Yuan@dell.com>,
kbuild-all@lists.01.org
Subject: Re: [PATCH 4/5] ALSA: HDA - remove the custom implementation for the audio LED trigger
Date: Thu, 11 Feb 2021 14:03:48 +0100 [thread overview]
Message-ID: <9c2bced1-54a2-4cb3-24f2-dfa278a5e88f@perex.cz> (raw)
In-Reply-To: <202102112042.XrBbhUg0-lkp@intel.com>
Dne 11. 02. 21 v 13:19 kernel test robot napsal(a):
> Hi Jaroslav,
>
> I love your patch! Perhaps something to improve:
> All warnings (new ones prefixed by >>):
>
> sound/core/control_led.c:49:19: warning: no previous prototype for 'snd_ctl_led_controls_by_access' [-Wmissing-prototypes]
> 49 | struct list_head *snd_ctl_led_controls_by_access(unsigned int access)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> sound/core/control_led.c:244:6: warning: no previous prototype for 'snd_ctl_led_hello' [-Wmissing-prototypes]
> 244 | void snd_ctl_led_hello(void)
> | ^~~~~~~~~~~~~~~~~
I'll address both issues in v2 of the patchset (snd_ctl_led_controls_by_access
function should be static and the snd_ctl_led_hello() is obsolete and it
should be removed - a piece from an internal version of my code)
Jaroslav
--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
next prev parent reply other threads:[~2021-02-11 13:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 11:13 [PATCH 0/5] ALSA: control - add generic LED trigger code Jaroslav Kysela
2021-02-11 11:13 ` [PATCH 1/5] ALSA: control - introduce snd_ctl_notify_one() helper Jaroslav Kysela
2021-02-11 11:13 ` [PATCH 2/5] ALSA: control - add layer registration routines Jaroslav Kysela
2021-02-11 11:13 ` [PATCH 3/5] ALSA: control - add generic LED trigger module as the new control layer Jaroslav Kysela
2021-02-11 11:13 ` [PATCH 4/5] ALSA: HDA - remove the custom implementation for the audio LED trigger Jaroslav Kysela
2021-02-11 12:19 ` kernel test robot
2021-02-11 12:19 ` kernel test robot
2021-02-11 13:03 ` Jaroslav Kysela [this message]
2021-02-22 7:28 ` [ALSA] a7fc56df5a: WARNING:possible_circular_locking_dependency_detected kernel test robot
2021-02-22 7:28 ` kernel test robot
2021-02-11 11:14 ` [PATCH 5/5] ALSA: control - add sysfs support to the LED trigger module Jaroslav Kysela
2021-02-11 12:43 ` kernel test robot
2021-02-11 12:43 ` kernel test robot
2021-02-11 17:15 ` [PATCH 0/5] ALSA: control - add generic LED trigger code Takashi Iwai
2021-02-11 17:53 ` Jaroslav Kysela
2021-02-12 9:23 ` Takashi Iwai
2021-02-12 10:32 ` Jaroslav Kysela
2021-02-12 12:28 ` Takashi Iwai
2021-02-14 18:55 ` Jaroslav Kysela
2021-02-15 7:50 ` Takashi Iwai
2021-02-15 17:49 ` Jaroslav Kysela
2021-02-12 20:31 ` Hans de Goede
2021-02-15 12:02 ` Hans de Goede
2021-02-15 12:35 ` Jaroslav Kysela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c2bced1-54a2-4cb3-24f2-dfa278a5e88f@perex.cz \
--to=perex@perex.cz \
--cc=Perry.Yuan@dell.com \
--cc=alsa-devel@alsa-project.org \
--cc=hdegoede@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=lkp@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.