All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
	danil.kipnis@cloud.ionos.com, jinpu.wang@cloud.ionos.com
Subject: Re: [PATCH 1/4] block: add a statistic table for io latency
Date: Thu, 28 Jan 2021 03:44:26 +0100	[thread overview]
Message-ID: <9c2c4681-41cf-94d1-12fa-3fe09bec987c@cloud.ionos.com> (raw)
In-Reply-To: <20210127171050.GA1732656@infradead.org>



On 1/27/21 18:10, Christoph Hellwig wrote:
> On Wed, Jan 27, 2021 at 03:59:27PM +0100, Guoqing Jiang wrote:
>> +config BLK_ADDITIONAL_DISKSTAT
>> +	bool "Block layer additional diskstat"
>> +	default n
> 
> n is the default default.  But more importantly I don't think having
> this as a compile time option makes much sense sense.  No one is going
> to recompile their kernel to get a few stats or to avoid the overhead
> of these stats.
> 

Ok, I will just use io_extra_stats node to dynamically control the 
stats, please let me know your thought about it.

Thanks,
Guoqin

  reply	other threads:[~2021-01-28  2:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27 14:59 [PATCH 0/4] block: add two statistic tables Guoqing Jiang
2021-01-27 14:59 ` [PATCH 1/4] block: add a statistic table for io latency Guoqing Jiang
2021-01-27 17:10   ` Christoph Hellwig
2021-01-28  2:44     ` Guoqing Jiang [this message]
2021-01-27 14:59 ` [PATCH 2/4] block: add a statistic table for io sector Guoqing Jiang
2021-01-27 14:59 ` [PATCH 3/4] block: add io_extra_stats node Guoqing Jiang
2021-01-27 14:59 ` [PATCH 4/4] block: call blk_additional_{latency,sector} only when io_extra_stats is true Guoqing Jiang
2021-01-27 17:09   ` Christoph Hellwig
2021-01-28  2:53     ` Guoqing Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c2c4681-41cf-94d1-12fa-3fe09bec987c@cloud.ionos.com \
    --to=guoqing.jiang@cloud.ionos.com \
    --cc=axboe@kernel.dk \
    --cc=danil.kipnis@cloud.ionos.com \
    --cc=hch@infradead.org \
    --cc=jinpu.wang@cloud.ionos.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.