From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755290AbdLGNkW (ORCPT ); Thu, 7 Dec 2017 08:40:22 -0500 Received: from mout.web.de ([212.227.15.4]:59000 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754837AbdLGNkT (ORCPT ); Thu, 7 Dec 2017 08:40:19 -0500 Subject: Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() To: Alan Stern , linux-usb@vger.kernel.org Cc: Joe Perches , Daniel Drake , Dmitry Fleytman , Eugene Korenevsky , Geert Uytterhoeven , Greg Kroah-Hartman , =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= , Johan Hovold , Mathias Nyman , LKML , kernel-janitors@vger.kernel.org, Oliver Neukum , Peter Chen References: From: SF Markus Elfring Message-ID: <9c32b2f1-a4d2-a079-f93c-ef6efe909449@users.sourceforge.net> Date: Thu, 7 Dec 2017 14:38:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:1DIDuecWAAcCpTmHJMoDlgWmbKDU6s9jyBVOEqLzMX6BAdHGxHE F9XJlvtbMhVSIONXRJYkujQP5ZWX7ZFEWrE2gMLa8V/TN0qurfc9HO7OyKFoMiSfOyJPF6a Qppkyg0cL9rCjKnqX9jeqsODHXdr46hu0v33liZ01wu33PezVCgY2Hz3NZ70wwk74hJNCCq 6pY/WqhX62dp+3Do7TU8w== X-UI-Out-Filterresults: notjunk:1;V01:K0:WsZOI0PM9Sw=:dArDpq4X5kolU5iIn695KG ZQ7ukTxkGvKrnQII0B8KtuJ4mZdT8e20/YU2BVEORiMa6pVYiwY2xr/sVr5P/gAMzsm9PcFzB Evq/ISUxLcUQbYXUfNTWUJvvpddrfIskHXqmxNXuD+wdG7yfw0Dg4cmg4WePZWYxlX/UKOxEr LqtkiEseOa4D5R0Q3Hz/Sbs0zVST/CF0qrq0NuvDP4wkKS73BRSX01zjF1P0bAkvVeCT7y5tI 3aYW6bqIIGQFtUP7jc2Fii3WSIxVrsVrNQ78eq/6I4vFdw/ViRBF5qpCEdhXOcuzNYtwP8uWG Qs+dWLcH4ra81eVeSEdOUSRuPWfdoROR23FiJvJ17bjhR+UKv4bYoyvwOdRnmMpJl+Jhhh+eq nvcyeP2ybjr5hMTUzNJYgoQSn8qcS0Bt+3XmkGa70vneFd1N9K2y6BbA4SeqaebXkKq5Js1IZ XU/4wLCns68KZOPS6fBq+EVHehp8PuCxB+A2i2rtMU3mzXztdD4d3tXpk2+UC5IAXazx3DYCd +DrUDByBJmB+84DYDmhsa1itkcJQeKQ+crJXIwXElOJlSSxryrjXicXJNBDJSggmCa/x0zFmw rkvAE7oIoP+CApl4rKLzpqf8RQwSPBU+NfXqQ37kq6rmRQdC1zgDjv0J/R8MDQUrwM9E/meK8 vqR6Nd7vmT/xBDMWzZF/DqXN1LENlznlrTpypzApE6MllZB1svXDvPk6frzc5DC1u/XF7x0Lx xsmm60jBrnYWEKb9GbWpVH0swrDSh8GTYZXaSrVUGEUIOU2+nj5auPiByQI8XoEYM5KqIVgF1 Gg7EECwOuIdga8Ka5HJVE2xrwqllb3oem+TMLE20blFx25p/nw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>> OOM does a dump_stack() so this function's call tree is shown. >>> >>> A call stack doesn't tell you which device was being handled. >> >> Do you find a default Linux allocation failure report insufficient then? >> >> Would you like to to achieve that the requested information can be determined >> from a backtrace? > > It is not practical to do this. I imagine that this depends on details if a backtrace could eventually be configured for your specific needs. > The memory allocation routines do not for what purpose > the memory is being allocated; Do you want an improved accounting for these purposes? > hence when a failure occurs they cannot tell what device > (or other part of the system) will be affected. I know that other programs can provide dumps for function call stacks where the parameters which were passed in previous calls could be decoded to some degree. > That's why we have a secondary error message. I am curious on how the relevance of such messages will be interpreted by other developers in this software area. Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Thu, 07 Dec 2017 13:38:19 +0000 Subject: Re: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() Message-Id: <9c32b2f1-a4d2-a079-f93c-ef6efe909449@users.sourceforge.net> List-Id: References: <97b0eeb8-834e-61ca-01dd-afbbf18697db@users.sourceforge.net> In-Reply-To: <97b0eeb8-834e-61ca-01dd-afbbf18697db@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alan Stern , linux-usb@vger.kernel.org Cc: Joe Perches , Daniel Drake , Dmitry Fleytman , Eugene Korenevsky , Geert Uytterhoeven , Greg Kroah-Hartman , =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= , Johan Hovold , Mathias Nyman , LKML , kernel-janitors@vger.kernel.org, Oliver Neukum , Peter Chen >>>> OOM does a dump_stack() so this function's call tree is shown. >>> >>> A call stack doesn't tell you which device was being handled. >> >> Do you find a default Linux allocation failure report insufficient then? >> >> Would you like to to achieve that the requested information can be determined >> from a backtrace? > > It is not practical to do this. I imagine that this depends on details if a backtrace could eventually be configured for your specific needs. > The memory allocation routines do not for what purpose > the memory is being allocated; Do you want an improved accounting for these purposes? > hence when a failure occurs they cannot tell what device > (or other part of the system) will be affected. I know that other programs can provide dumps for function call stacks where the parameters which were passed in previous calls could be decoded to some degree. > That's why we have a secondary error message. I am curious on how the relevance of such messages will be interpreted by other developers in this software area. Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt_buffer() From: SF Markus Elfring Message-Id: <9c32b2f1-a4d2-a079-f93c-ef6efe909449@users.sourceforge.net> Date: Thu, 7 Dec 2017 14:38:19 +0100 To: Alan Stern , linux-usb@vger.kernel.org Cc: Joe Perches , Daniel Drake , Dmitry Fleytman , Eugene Korenevsky , Geert Uytterhoeven , Greg Kroah-Hartman , =?UTF-8?B?R8O8bnRlciBSw7Zjaw==?= , Johan Hovold , Mathias Nyman , LKML , kernel-janitors@vger.kernel.org, Oliver Neukum , Peter Chen List-ID: Pj4+PiBPT00gZG9lcyBhIGR1bXBfc3RhY2soKSBzbyB0aGlzIGZ1bmN0aW9uJ3MgY2FsbCB0cmVl IGlzIHNob3duLgo+Pj4KPj4+IEEgY2FsbCBzdGFjayBkb2Vzbid0IHRlbGwgeW91IHdoaWNoIGRl dmljZSB3YXMgYmVpbmcgaGFuZGxlZC4KPj4KPj4gRG8geW91IGZpbmQgYSBkZWZhdWx0IExpbnV4 IGFsbG9jYXRpb24gZmFpbHVyZSByZXBvcnQgaW5zdWZmaWNpZW50IHRoZW4/Cj4+Cj4+IFdvdWxk IHlvdSBsaWtlIHRvIHRvIGFjaGlldmUgdGhhdCB0aGUgcmVxdWVzdGVkIGluZm9ybWF0aW9uIGNh biBiZSBkZXRlcm1pbmVkCj4+IGZyb20gYSBiYWNrdHJhY2U/Cj4gCj4gSXQgaXMgbm90IHByYWN0 aWNhbCB0byBkbyB0aGlzLgoKSSBpbWFnaW5lIHRoYXQgdGhpcyBkZXBlbmRzIG9uIGRldGFpbHMg aWYgYSBiYWNrdHJhY2UgY291bGQgZXZlbnR1YWxseQpiZSBjb25maWd1cmVkIGZvciB5b3VyIHNw ZWNpZmljIG5lZWRzLgoKCj4gVGhlIG1lbW9yeSBhbGxvY2F0aW9uIHJvdXRpbmVzIGRvIG5vdCBm b3Igd2hhdCBwdXJwb3NlCj4gdGhlIG1lbW9yeSBpcyBiZWluZyBhbGxvY2F0ZWQ7CgpEbyB5b3Ug d2FudCBhbiBpbXByb3ZlZCBhY2NvdW50aW5nIGZvciB0aGVzZSBwdXJwb3Nlcz8KCgo+IGhlbmNl IHdoZW4gYSBmYWlsdXJlIG9jY3VycyB0aGV5IGNhbm5vdCB0ZWxsIHdoYXQgZGV2aWNlCj4gKG9y IG90aGVyIHBhcnQgb2YgdGhlIHN5c3RlbSkgd2lsbCBiZSBhZmZlY3RlZC4KCkkga25vdyB0aGF0 IG90aGVyIHByb2dyYW1zIGNhbiBwcm92aWRlIGR1bXBzIGZvciBmdW5jdGlvbiBjYWxsCnN0YWNr cyB3aGVyZSB0aGUgcGFyYW1ldGVycyB3aGljaCB3ZXJlIHBhc3NlZCBpbiBwcmV2aW91cyBjYWxs cwpjb3VsZCBiZSBkZWNvZGVkIHRvIHNvbWUgZGVncmVlLgoKCj4gVGhhdCdzIHdoeSB3ZSBoYXZl IGEgc2Vjb25kYXJ5IGVycm9yIG1lc3NhZ2UuCgpJIGFtIGN1cmlvdXMgb24gaG93IHRoZSByZWxl dmFuY2Ugb2Ygc3VjaCBtZXNzYWdlcyB3aWxsIGJlIGludGVycHJldGVkCmJ5IG90aGVyIGRldmVs b3BlcnMgaW4gdGhpcyBzb2Z0d2FyZSBhcmVhLgoKUmVnYXJkcywKTWFya3VzCi0tLQpUbyB1bnN1 YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgt dXNiIiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9y ZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9t by1pbmZvLmh0bWwK