From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Mat Martineau <mathew.j.martineau@linux.intel.com>
Cc: pabeni@redhat.com, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next v2] mptcp: Retransmit DATA_FIN
Date: Wed, 21 Apr 2021 20:24:58 +0200 [thread overview]
Message-ID: <9c36342d-cce9-3883-3cbc-17ebb20a4c64@tessares.net> (raw)
In-Reply-To: <20210421153805.210668-1-mathew.j.martineau@linux.intel.com>
Hi Mat,
On 21/04/2021 17:38, Mat Martineau wrote:
> With this change, the MPTCP-level retransmission timer is used to resend
> DATA_FIN. The retranmit timer is not stopped while waiting for a
> MPTCP-level ACK of DATA_FIN, and retransmitted DATA_FINs are sent on all
> subflows. The retry interval starts at TCP_RTO_MIN and then doubles on
> each attempt, up to TCP_RTO_MAX.
>
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/146
> Fixes: 43b54c6ee382 ("mptcp: Use full MPTCP-level disconnect state machine")
> Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
> ---
>
> v2: Simplify timeout limits, move function to avoid -net conflict
>
> v1: Add backoff
>
> Paolo and Matthieu mentioned sending to -net instead of net-next on IRC,
> I will test out on that branch too.
Thank you for the patch!
As discussed on IRC, I just applied this patch in our tree without
Paolo's ACK. It seems you correctly addressed all the comments so no
need to wait. We can apply some squash-to patches later if needed.
- 7137c5d18e29: mptcp: Retransmit DATA_FIN
- Results: 5eaa9f1d555d..c5409d6a14e5
Builds and tests are now in progress:
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20210421T181432
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export/20210421T181432
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
prev parent reply other threads:[~2021-04-21 18:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 15:38 [PATCH mptcp-next v2] mptcp: Retransmit DATA_FIN Mat Martineau
2021-04-21 18:24 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c36342d-cce9-3883-3cbc-17ebb20a4c64@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=mathew.j.martineau@linux.intel.com \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.