From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6123C3279B for ; Fri, 6 Jul 2018 13:18:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61C7423EF6 for ; Fri, 6 Jul 2018 13:18:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61C7423EF6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933578AbeGFNSw (ORCPT ); Fri, 6 Jul 2018 09:18:52 -0400 Received: from smtp.nue.novell.com ([195.135.221.5]:38803 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932995AbeGFNSu (ORCPT ); Fri, 6 Jul 2018 09:18:50 -0400 Received: from ziggy.stardust ([37.223.136.20]) by smtp.nue.novell.com with ESMTP (TLS encrypted); Fri, 06 Jul 2018 15:18:45 +0200 Subject: Re: [v3 03/10] mfd: mtk-mmsys: Add mmsys driver To: Lee Jones Cc: Matthias Brugger , matthias.bgg@kernel.org, ulrich.hecht+renesas@gmail.com, laurent.pinchart@ideasonboard.com, ck.hu@mediatek.com, p.zabel@pengutronix.de, airlied@linux.ie, robh+dt@kernel.org, mark.rutland@arm.com, mturquette@baylibre.com, sboyd@codeaurora.org, davem@davemloft.net, gregkh@linuxfoundation.org, mchehab@kernel.org, rdunlap@infradead.org, sean.wang@mediatek.com, linux-clk@vger.kernel.org, linux@armlinux.org.uk, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20180430101826.GC5147@dell> <5269ccfd-0274-3c12-7eeb-5de923197d92@gmail.com> <20180703071103.GE20176@dell> <20180704164540.GH496@dell> <92a851a9-a12c-e773-5f43-007f4d08b7e3@suse.com> <20180705122223.GO496@dell> From: Matthias Brugger Openpgp: preference=signencrypt Autocrypt: addr=mbrugger@suse.com; prefer-encrypt=mutual; keydata= xsFNBFP1zgUBEAC21D6hk7//0kOmsUrE3eZ55kjc9DmFPKIz6l4NggqwQjBNRHIMh04BbCMY fL3eT7ZsYV5nur7zctmJ+vbszoOASXUpfq8M+S5hU2w7sBaVk5rpH9yW8CUWz2+ZpQXPJcFa OhLZuSKB1F5JcvLbETRjNzNU7B3TdS2+zkgQQdEyt7Ij2HXGLJ2w+yG2GuR9/iyCJRf10Okq gTh//XESJZ8S6KlOWbLXRE+yfkKDXQx2Jr1XuVvM3zPqH5FMg8reRVFsQ+vI0b+OlyekT/Xe 0Hwvqkev95GG6x7yseJwI+2ydDH6M5O7fPKFW5mzAdDE2g/K9B4e2tYK6/rA7Fq4cqiAw1+u EgO44+eFgv082xtBez5WNkGn18vtw0LW3ESmKh19u6kEGoi0WZwslCNaGFrS4M7OH+aOJeqK fx5dIv2CEbxc6xnHY7dwkcHikTA4QdbdFeUSuj4YhIZ+0QlDVtS1QEXyvZbZky7ur9rHkZvP ZqlUsLJ2nOqsmahMTIQ8Mgx9SLEShWqD4kOF4zNfPJsgEMB49KbS2o9jxbGB+JKupjNddfxZ HlH1KF8QwCMZEYaTNogrVazuEJzx6JdRpR3sFda/0x5qjTadwIW6Cl9tkqe2h391dOGX1eOA 1ntn9O/39KqSrWNGvm+1raHK+Ev1yPtn0Wxn+0oy1tl67TxUjQARAQABzSlNYXR0aGlhcyBC cnVnZ2VyIDxtYXR0aGlhcy5iZ2dAZ21haWwuY29tPsLBkgQTAQIAPAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AWIQTmuZIYwPLDJRwsOhfZFAuyVhMC8QUCWt3scQIZAQAKCRDZFAuy VhMC8WzRD/4onkC+gCxG+dvui5SXCJ7bGLCu0xVtiGC673Kz5Aq3heITsERHBV0BqqctOEBy ZozQQe2Hindu9lasOmwfH8+vfTK+2teCgWesoE3g3XKbrOCB4RSrQmXGC3JYx6rcvMlLV/Ch YMRR3qv04BOchnjkGtvm9aZWH52/6XfChyh7XYndTe5F2bqeTjt+kF/ql+xMc4E6pniqIfkv c0wsH4CkBHqoZl9w5e/b9MspTqsU9NszTEOFhy7p2CYw6JEa/vmzR6YDzGs8AihieIXDOfpT DUr0YUlDrwDSrlm/2MjNIPTmSGHH94ScOqu/XmGW/0q1iar/Yr0leomUOeeEzCqQtunqShtE 4Mn2uEixFL+9jiVtMjujr6mphznwpEqObPCZ3IcWqOFEz77rSL+oqFiEA03A2WBDlMm++Sve 9jpkJBLosJRhAYmQ6ey6MFO6Krylw1LXcq5z1XQQavtFRgZoruHZ3XlhT5wcfLJtAqrtfCe0 aQ0kJW+4zj9/So0uxJDAtGuOpDYnmK26dgFN0tAhVuNInEVhtErtLJHeJzFKJzNyQ4GlCaLw jKcwWcqDJcrx9R7LsCu4l2XpKiyxY6fO4O8DnSleVll9NPfAZFZvf8AIy3EQ8BokUsiuUYHz wUo6pclk55PZRaAsHDX/fNr24uC6Eh5oNQ+v4Pax/gtyyc7BTQRT9gkSARAApxtQ4zUMC512 kZ+gCiySFcIF/mAf7+l45689Tn7LI1xmPQrAYJDoqQVXcyh3utgtvBvDLmpQ+1BfEONDWc8K RP6Abo35YqBx3udAkLZgr/RmEg3+Tiof+e1PJ2zRh5zmdei5MT8biE2zVd9DYSJHZ8ltEWIA LC9lAsv9oa+2L6naC+KFF3i0m5mxklgFoSthswUnonqvclsjYaiVPoSldDrreCPzmRCUd8zn f//Z4BxtlTw3SulF8weKLJ+Hlpw8lwb3sUl6yPS6pL6UV45gyWMe677bVUtxLYOu+kiv2B/+ nrNRDs7B35y/J4t8dtK0S3M/7xtinPiYRmsnJdk+sdAe8TgGkEaooF57k1aczcJlUTBQvlYA Eg2NJnqaKg3SCJ4fEuT8rLjzuZmLkoHNumhH/mEbyKca82HvANu5C9clyQusJdU+MNRQLRmO Ad/wxGLJ0xmAye7Ozja86AIzbEmuNhNH9xNjwbwSJNZefV2SoZUv0+V9EfEVxTzraBNUZifq v6hernMQXGxs+lBjnyl624U8nnQWnA8PwJ2hI3DeQou1HypLFPeY9DfWv4xYdkyeOtGpueeB lqhtMoZ0kDw2C3vzj77nWwBgpgn1Vpf4hG/sW/CRR6tuIQWWTvUM3ACa1pgEsBvIEBiVvPxy AtL+L+Lh1Sni7w3HBk1EJvUAEQEAAcLBXwQYAQIACQUCU/YJEgIbDAAKCRDZFAuyVhMC8Qnd EACuN16mvivnWwLDdypvco5PF8w9yrfZDKW4ggf9TFVB9skzMNCuQc+tc+QM+ni2c4kKIdz2 jmcg6QytgqVum6V1OsNmpjADaQkVp5jL0tmg6/KA9Tvr07Kuv+Uo4tSrS/4djDjJnXHEp/tB +Fw7CArNtUtLlc8SuADCmMD+kBOVWktZyzkBkDfBXlTWl46T/8291lEspDWe5YW1ZAH/HdCR 1rQNZWjNCpB2Cic58CYMD1rSonCnbfUeyZYNNhNHZosl4dl7f+am87Q2x3pK0DLSoJRxWb7v ZB0uo9CzCSm3I++aYozF25xQoT+7zCx2cQi33jwvnJAK1o4VlNx36RfrxzBqc1uZGzJBCQu4 8UjmUSsTwWC3HpE/D9sM+xACs803lFUIZC5H62G059cCPAXKgsFpNMKmBAWweBkVJAisoQeX 50OP+/11ArV0cv+fOTfJj0/KwFXJaaYh3LUQNILLBNxkSrhCLl8dUg53IbHx4NfIAgqxLWGf XM8DY1aFdU79pac005PuhxCWkKTJz3gCmznnoat4GCnL5gy/m0Qk45l4PFqwWXVLo9AQg2Kp 3mlIFZ6fsEKIAN5hxlbNvNb9V2Zo5bFZjPWPFTxOteM0omUAS+QopwU0yPLLGJVf2iCmItHc UXI+r2JwH1CJjrHWeQEI2ucSKsNa8FllDmG/fQ== Message-ID: <9c368450-b89b-825b-4763-90825e93b656@suse.com> Date: Fri, 6 Jul 2018 15:18:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180705122223.GO496@dell> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/07/18 14:22, Lee Jones wrote: > On Thu, 05 Jul 2018, Matthias Brugger wrote: >> On 04/07/18 18:45, Lee Jones wrote: >>> On Wed, 04 Jul 2018, Matthias Brugger wrote: >>>> On 03/07/18 09:11, Lee Jones wrote: >>>>> On Mon, 25 Jun 2018, Matthias Brugger wrote: >>>>>> On 30/04/18 12:18, Lee Jones wrote: >>>>>>> On Fri, 27 Apr 2018, matthias.bgg@kernel.org wrote: [...] >>>>>>>> +static int mmsys_probe(struct platform_device *pdev) >>>>>>>> +{ >>>>>>>> + const struct mfd_cell *mmsys_cells; >>>>>>>> + int nr_cells; >>>>>>>> + long id; >>>>>>>> + int ret; >>>>>>>> + >>>>>>>> + id = (long) of_device_get_match_data(&pdev->dev); >>>>>>>> + if (!id) { >>>>>>>> + dev_err(&pdev->dev, "of_device_get match_data() failed\n"); >>>>>>>> + return -EINVAL; >>>>>>>> + } >>>>>>>> + >>>>>>>> + switch (id) { >>>>>>>> + case MMSYS_MT2701: >>>>>>>> + mmsys_cells = mmsys_mt2701_devs; >>>>>>>> + nr_cells = ARRAY_SIZE(mmsys_mt2701_devs); >>>>>>>> + break; >>>>>>>> + default: >>>>>>>> + return -ENODEV; >>>>>>>> + } >>>>>>>> + >>>>>>>> + ret = devm_mfd_add_devices(&pdev->dev, 0, mmsys_cells, nr_cells, >>>>>>>> + NULL, 0, NULL); >>>>>>>> + if (ret) { >>>>>>>> + dev_err(&pdev->dev, "failed to add MFD devices %d\n", ret); >>>>>>>> + return ret; >>>>>>>> + } >>>>>>>> + >>>>>>>> + return 0; >>>>>>>> +}; >>>>>>> >>>>>>> This driver is pretty pointless. It doesn't actually do anything. >>>>>>> >>>>>>> I think you just want to use "simple-mfd" instead. >>>>>>> >>>>>> >>>>>> I think the problem is, that right now we have two drivers which use the same >>>>>> devicetree binding, which are clk and drm driver. With a simple-mfd we would >>>>>> need two compatibles, and this would break backwards compatibility. >>>>> >>>>> So what functionality does this driver provide you with that you do >>>>> not have currently? >>>>> >>>> >>>> I'm not sure if I get your question. Point is, that the MMSYS implementation for >>>> mt8173 is broken, as it assumes that we can probe two drivers with the >>>> mediatek,mt8173-mmsys compatible. Somehow it used to work, but from what I >>>> understand it was a bug. So older devicetrees use just on mt8173-mmsys >>>> compatible in ther DTB. >>> >>> Okay, that is what I was getting at. Thanks for the explanation. >>> >>> Do you have a datasheet I can look at? >>> >> >> Unfortunately there is no datasheet you can get without a NDA. The only public >> available information I'm aware of is for the (not upstream supported) 96board >> [1]. And it's only the register description. You can find some more explanation >> about the MMSYS in older threads which tried to solve the very same problem [2] >> >> [1] >> https://www.96boards.org/documentation/consumer/mediatekx20/additional-docs/docs/MT6797_Register_Table_Part_2.pdf >> [2] http://lists.infradead.org/pipermail/linux-mediatek/2017-October/010979.html > > And now we have some history. Thanks for providing those. > > So my initial reaction is the one I have just confirmed for myself. > MFD is being used as a work-around in this odd use-case and really > isn't the right place for it. > > If you're adamant that you do not wish to change the Device Tree, my > suggestion is to either move the clk functionality into the DRM > driver, or register the clk driver from DRM using standard > platform_device_register() API. > Ok, I'll try to come up with a solution with a platform device for the clocks. Stay tuened. Thanks for your feedback! Matthias From mboxrd@z Thu Jan 1 00:00:00 1970 From: mbrugger@suse.com (Matthias Brugger) Date: Fri, 6 Jul 2018 15:18:44 +0200 Subject: [v3 03/10] mfd: mtk-mmsys: Add mmsys driver In-Reply-To: <20180705122223.GO496@dell> References: <20180430101826.GC5147@dell> <5269ccfd-0274-3c12-7eeb-5de923197d92@gmail.com> <20180703071103.GE20176@dell> <20180704164540.GH496@dell> <92a851a9-a12c-e773-5f43-007f4d08b7e3@suse.com> <20180705122223.GO496@dell> Message-ID: <9c368450-b89b-825b-4763-90825e93b656@suse.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/07/18 14:22, Lee Jones wrote: > On Thu, 05 Jul 2018, Matthias Brugger wrote: >> On 04/07/18 18:45, Lee Jones wrote: >>> On Wed, 04 Jul 2018, Matthias Brugger wrote: >>>> On 03/07/18 09:11, Lee Jones wrote: >>>>> On Mon, 25 Jun 2018, Matthias Brugger wrote: >>>>>> On 30/04/18 12:18, Lee Jones wrote: >>>>>>> On Fri, 27 Apr 2018, matthias.bgg at kernel.org wrote: [...] >>>>>>>> +static int mmsys_probe(struct platform_device *pdev) >>>>>>>> +{ >>>>>>>> + const struct mfd_cell *mmsys_cells; >>>>>>>> + int nr_cells; >>>>>>>> + long id; >>>>>>>> + int ret; >>>>>>>> + >>>>>>>> + id = (long) of_device_get_match_data(&pdev->dev); >>>>>>>> + if (!id) { >>>>>>>> + dev_err(&pdev->dev, "of_device_get match_data() failed\n"); >>>>>>>> + return -EINVAL; >>>>>>>> + } >>>>>>>> + >>>>>>>> + switch (id) { >>>>>>>> + case MMSYS_MT2701: >>>>>>>> + mmsys_cells = mmsys_mt2701_devs; >>>>>>>> + nr_cells = ARRAY_SIZE(mmsys_mt2701_devs); >>>>>>>> + break; >>>>>>>> + default: >>>>>>>> + return -ENODEV; >>>>>>>> + } >>>>>>>> + >>>>>>>> + ret = devm_mfd_add_devices(&pdev->dev, 0, mmsys_cells, nr_cells, >>>>>>>> + NULL, 0, NULL); >>>>>>>> + if (ret) { >>>>>>>> + dev_err(&pdev->dev, "failed to add MFD devices %d\n", ret); >>>>>>>> + return ret; >>>>>>>> + } >>>>>>>> + >>>>>>>> + return 0; >>>>>>>> +}; >>>>>>> >>>>>>> This driver is pretty pointless. It doesn't actually do anything. >>>>>>> >>>>>>> I think you just want to use "simple-mfd" instead. >>>>>>> >>>>>> >>>>>> I think the problem is, that right now we have two drivers which use the same >>>>>> devicetree binding, which are clk and drm driver. With a simple-mfd we would >>>>>> need two compatibles, and this would break backwards compatibility. >>>>> >>>>> So what functionality does this driver provide you with that you do >>>>> not have currently? >>>>> >>>> >>>> I'm not sure if I get your question. Point is, that the MMSYS implementation for >>>> mt8173 is broken, as it assumes that we can probe two drivers with the >>>> mediatek,mt8173-mmsys compatible. Somehow it used to work, but from what I >>>> understand it was a bug. So older devicetrees use just on mt8173-mmsys >>>> compatible in ther DTB. >>> >>> Okay, that is what I was getting at. Thanks for the explanation. >>> >>> Do you have a datasheet I can look at? >>> >> >> Unfortunately there is no datasheet you can get without a NDA. The only public >> available information I'm aware of is for the (not upstream supported) 96board >> [1]. And it's only the register description. You can find some more explanation >> about the MMSYS in older threads which tried to solve the very same problem [2] >> >> [1] >> https://www.96boards.org/documentation/consumer/mediatekx20/additional-docs/docs/MT6797_Register_Table_Part_2.pdf >> [2] http://lists.infradead.org/pipermail/linux-mediatek/2017-October/010979.html > > And now we have some history. Thanks for providing those. > > So my initial reaction is the one I have just confirmed for myself. > MFD is being used as a work-around in this odd use-case and really > isn't the right place for it. > > If you're adamant that you do not wish to change the Device Tree, my > suggestion is to either move the clk functionality into the DRM > driver, or register the clk driver from DRM using standard > platform_device_register() API. > Ok, I'll try to come up with a solution with a platform device for the clocks. Stay tuened. Thanks for your feedback! Matthias