From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH for 4.9 1/6] x86/hvm: Correct some address space terminology Date: Mon, 3 Apr 2017 08:24:21 +0000 Message-ID: <9c51dd2324494a2dac588f3864a1282b@AMSPEX02CL03.citrite.net> References: <1490989853-21879-1-git-send-email-andrew.cooper3@citrix.com> <1490989853-21879-2-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1490989853-21879-2-git-send-email-andrew.cooper3@citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Xen-devel Cc: Andrew Cooper , Julien Grall , "Tim (Xen.org)" , Jan Beulich List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IEFuZHJldyBDb29wZXIgW21haWx0 bzphbmRyZXcuY29vcGVyM0BjaXRyaXguY29tXQo+IFNlbnQ6IDMxIE1hcmNoIDIwMTcgMjA6NTEK PiBUbzogWGVuLWRldmVsIDx4ZW4tZGV2ZWxAbGlzdHMueGVuLm9yZz4KPiBDYzogQW5kcmV3IENv b3BlciA8QW5kcmV3LkNvb3BlcjNAY2l0cml4LmNvbT47IEphbiBCZXVsaWNoCj4gPEpCZXVsaWNo QHN1c2UuY29tPjsgVGltIChYZW4ub3JnKSA8dGltQHhlbi5vcmc+OyBQYXVsIER1cnJhbnQKPiA8 UGF1bC5EdXJyYW50QGNpdHJpeC5jb20+OyBKdWxpZW4gR3JhbGwgPGp1bGllbi5ncmFsbEBhcm0u Y29tPgo+IFN1YmplY3Q6IFtQQVRDSCBmb3IgNC45IDEvNl0geDg2L2h2bTogQ29ycmVjdCBzb21l IGFkZHJlc3Mgc3BhY2UKPiB0ZXJtaW5vbG9neQo+IAo+IFRoZSBmdW5jdGlvbiBodm1fdHJhbnNs YXRlX2xpbmVhcl9hZGRyKCkgdHJhbnNsYXRlcyBhIHZpcnR1YWwgYWRkcmVzcyB0byBhCj4gbGlu ZWFyIGFkZHJlc3MsIG5vdCBhIGxpbmVhciBhZGRyZXNzIHRvIGEgcGh5c2ljYWwgYWRkcmVzcy4g IENvcnJlY3QgaXRzIG5hbWUuCj4gCj4gQm90aCBodm1fdHJhbnNsYXRlX3ZpcnR1YWxfYWRkcigp IGFuZCBodm1lbXVsX3ZpcnR1YWxfdG9fbGluZWFyKCkgcmV0dXJuCj4gYQo+IGxpbmVhciBhZGRy ZXNzLCBub3QgYSBwaHlzaWNhbCBhZGRyZXNzLiAgQ29ycmVjdCB0aGUgcGFyYW1ldGVycyBuYW1l Lgo+IAo+IE5vIGZ1bmN0aW9uYWwgY2hhbmdlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBD b29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+CgpSZXZpZXdlZC1ieTogUGF1bCBEdXJy YW50IDxwYXVsLmR1cnJhbnRAY2l0cml4LmNvbT4KCj4gLS0tCj4gQ0M6IEphbiBCZXVsaWNoIDxK QmV1bGljaEBzdXNlLmNvbT4KPiBDQzogVGltIERlZWdhbiA8dGltQHhlbi5vcmc+Cj4gQ0M6IFBh dWwgRHVycmFudCA8cGF1bC5kdXJyYW50QGNpdHJpeC5jb20+Cj4gQ0M6IEp1bGllbiBHcmFsbCA8 anVsaWVuLmdyYWxsQGFybS5jb20+Cj4gLS0tCj4gIHhlbi9hcmNoL3g4Ni9odm0vZW11bGF0ZS5j ICAgICAgfCAxMiArKysrKystLS0tLS0KPiAgeGVuL2FyY2gveDg2L21tL3NoYWRvdy9jb21tb24u YyB8IDE2ICsrKysrKysrLS0tLS0tLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25z KCspLCAxNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2h2bS9l bXVsYXRlLmMgYi94ZW4vYXJjaC94ODYvaHZtL2VtdWxhdGUuYwo+IGluZGV4IDJkOTI5NTcuLjQw NzM3MTUgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gveDg2L2h2bS9lbXVsYXRlLmMKPiArKysgYi94 ZW4vYXJjaC94ODYvaHZtL2VtdWxhdGUuYwo+IEBAIC01MDYsNyArNTA2LDcgQEAgc3RhdGljIGlu dCBodm1lbXVsX3ZpcnR1YWxfdG9fbGluZWFyKAo+ICAgICAgdW5zaWduZWQgbG9uZyAqcmVwcywK PiAgICAgIGVudW0gaHZtX2FjY2Vzc190eXBlIGFjY2Vzc190eXBlLAo+ICAgICAgc3RydWN0IGh2 bV9lbXVsYXRlX2N0eHQgKmh2bWVtdWxfY3R4dCwKPiAtICAgIHVuc2lnbmVkIGxvbmcgKnBhZGRy KQo+ICsgICAgdW5zaWduZWQgbG9uZyAqbGluZWFyKQo+ICB7Cj4gICAgICBzdHJ1Y3Qgc2VnbWVu dF9yZWdpc3RlciAqcmVnOwo+ICAgICAgaW50IG9rYXk7Cj4gQEAgLTUxNCw3ICs1MTQsNyBAQCBz dGF0aWMgaW50IGh2bWVtdWxfdmlydHVhbF90b19saW5lYXIoCj4gCj4gICAgICBpZiAoIHNlZyA9 PSB4ODZfc2VnX25vbmUgKQo+ICAgICAgewo+IC0gICAgICAgICpwYWRkciA9IG9mZnNldDsKPiAr ICAgICAgICAqbGluZWFyID0gb2Zmc2V0Owo+ICAgICAgICAgIHJldHVybiBYODZFTVVMX09LQVk7 Cj4gICAgICB9Cj4gCj4gQEAgLTU0OSwxNiArNTQ5LDE2IEBAIHN0YXRpYyBpbnQgaHZtZW11bF92 aXJ0dWFsX3RvX2xpbmVhcigKPiAgICAgICAgICBva2F5ID0gaHZtX3ZpcnR1YWxfdG9fbGluZWFy X2FkZHIoCj4gICAgICAgICAgICAgIHNlZywgcmVnLCBvZmZzZXQgLSAoKnJlcHMgLSAxKSAqIGJ5 dGVzX3Blcl9yZXAsCj4gICAgICAgICAgICAgICpyZXBzICogYnl0ZXNfcGVyX3JlcCwgYWNjZXNz X3R5cGUsCj4gLSAgICAgICAgICAgIGh2bWVtdWxfY3R4dC0+Y3R4dC5hZGRyX3NpemUsIHBhZGRy KTsKPiAtICAgICAgICAqcGFkZHIgKz0gKCpyZXBzIC0gMSkgKiBieXRlc19wZXJfcmVwOwo+ICsg ICAgICAgICAgICBodm1lbXVsX2N0eHQtPmN0eHQuYWRkcl9zaXplLCBsaW5lYXIpOwo+ICsgICAg ICAgICpsaW5lYXIgKz0gKCpyZXBzIC0gMSkgKiBieXRlc19wZXJfcmVwOwo+ICAgICAgICAgIGlm ICggaHZtZW11bF9jdHh0LT5jdHh0LmFkZHJfc2l6ZSAhPSA2NCApCj4gLSAgICAgICAgICAgICpw YWRkciA9ICh1aW50MzJfdCkqcGFkZHI7Cj4gKyAgICAgICAgICAgICpsaW5lYXIgPSAodWludDMy X3QpKmxpbmVhcjsKPiAgICAgIH0KPiAgICAgIGVsc2UKPiAgICAgIHsKPiAgICAgICAgICBva2F5 ID0gaHZtX3ZpcnR1YWxfdG9fbGluZWFyX2FkZHIoCj4gICAgICAgICAgICAgIHNlZywgcmVnLCBv ZmZzZXQsICpyZXBzICogYnl0ZXNfcGVyX3JlcCwgYWNjZXNzX3R5cGUsCj4gLSAgICAgICAgICAg IGh2bWVtdWxfY3R4dC0+Y3R4dC5hZGRyX3NpemUsIHBhZGRyKTsKPiArICAgICAgICAgICAgaHZt ZW11bF9jdHh0LT5jdHh0LmFkZHJfc2l6ZSwgbGluZWFyKTsKPiAgICAgIH0KPiAKPiAgICAgIGlm ICggb2theSApCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9tbS9zaGFkb3cvY29tbW9uLmMK PiBiL3hlbi9hcmNoL3g4Ni9tbS9zaGFkb3cvY29tbW9uLmMKPiBpbmRleCBkOTNmMmFiLi4wM2Ni MjRkIDEwMDY0NAo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9tbS9zaGFkb3cvY29tbW9uLmMKPiArKysg Yi94ZW4vYXJjaC94ODYvbW0vc2hhZG93L2NvbW1vbi5jCj4gQEAgLTEzNiwxMyArMTM2LDEzIEBA IHN0YXRpYyBzdHJ1Y3Qgc2VnbWVudF9yZWdpc3RlciAqaHZtX2dldF9zZWdfcmVnKAo+ICAgICAg cmV0dXJuIHNlZ19yZWc7Cj4gIH0KPiAKPiAtc3RhdGljIGludCBodm1fdHJhbnNsYXRlX2xpbmVh cl9hZGRyKAo+ICtzdGF0aWMgaW50IGh2bV90cmFuc2xhdGVfdmlydHVhbF9hZGRyKAo+ICAgICAg ZW51bSB4ODZfc2VnbWVudCBzZWcsCj4gICAgICB1bnNpZ25lZCBsb25nIG9mZnNldCwKPiAgICAg IHVuc2lnbmVkIGludCBieXRlcywKPiAgICAgIGVudW0gaHZtX2FjY2Vzc190eXBlIGFjY2Vzc190 eXBlLAo+ICAgICAgc3RydWN0IHNoX2VtdWxhdGVfY3R4dCAqc2hfY3R4dCwKPiAtICAgIHVuc2ln bmVkIGxvbmcgKnBhZGRyKQo+ICsgICAgdW5zaWduZWQgbG9uZyAqbGluZWFyKQo+ICB7Cj4gICAg ICBjb25zdCBzdHJ1Y3Qgc2VnbWVudF9yZWdpc3RlciAqcmVnOwo+ICAgICAgaW50IG9rYXk7Cj4g QEAgLTE1Miw3ICsxNTIsNyBAQCBzdGF0aWMgaW50IGh2bV90cmFuc2xhdGVfbGluZWFyX2FkZHIo Cj4gICAgICAgICAgcmV0dXJuIC1QVFJfRVJSKHJlZyk7Cj4gCj4gICAgICBva2F5ID0gaHZtX3Zp cnR1YWxfdG9fbGluZWFyX2FkZHIoCj4gLSAgICAgICAgc2VnLCByZWcsIG9mZnNldCwgYnl0ZXMs IGFjY2Vzc190eXBlLCBzaF9jdHh0LT5jdHh0LmFkZHJfc2l6ZSwgcGFkZHIpOwo+ICsgICAgICAg IHNlZywgcmVnLCBvZmZzZXQsIGJ5dGVzLCBhY2Nlc3NfdHlwZSwgc2hfY3R4dC0+Y3R4dC5hZGRy X3NpemUsIGxpbmVhcik7Cj4gCj4gICAgICBpZiAoICFva2F5ICkKPiAgICAgIHsKPiBAQCAtMTgz LDcgKzE4Myw3IEBAIGh2bV9yZWFkKGVudW0geDg2X3NlZ21lbnQgc2VnLAo+ICAgICAgdW5zaWdu ZWQgbG9uZyBhZGRyOwo+ICAgICAgaW50IHJjOwo+IAo+IC0gICAgcmMgPSBodm1fdHJhbnNsYXRl X2xpbmVhcl9hZGRyKAo+ICsgICAgcmMgPSBodm1fdHJhbnNsYXRlX3ZpcnR1YWxfYWRkcigKPiAg ICAgICAgICBzZWcsIG9mZnNldCwgYnl0ZXMsIGFjY2Vzc190eXBlLCBzaF9jdHh0LCAmYWRkcik7 Cj4gICAgICBpZiAoIHJjIHx8ICFieXRlcyApCj4gICAgICAgICAgcmV0dXJuIHJjOwo+IEBAIC0y NjUsNyArMjY1LDcgQEAgaHZtX2VtdWxhdGVfd3JpdGUoZW51bSB4ODZfc2VnbWVudCBzZWcsCj4g ICAgICBpZiAoIHNlZyA9PSB4ODZfc2VnX3NzICkKPiAgICAgICAgICBwZXJmY19pbmNyKHNoYWRv d19mYXVsdF9lbXVsYXRlX3N0YWNrKTsKPiAKPiAtICAgIHJjID0gaHZtX3RyYW5zbGF0ZV9saW5l YXJfYWRkcigKPiArICAgIHJjID0gaHZtX3RyYW5zbGF0ZV92aXJ0dWFsX2FkZHIoCj4gICAgICAg ICAgc2VnLCBvZmZzZXQsIGJ5dGVzLCBodm1fYWNjZXNzX3dyaXRlLCBzaF9jdHh0LCAmYWRkcik7 Cj4gICAgICBpZiAoIHJjIHx8ICFieXRlcyApCj4gICAgICAgICAgcmV0dXJuIHJjOwo+IEBAIC0y OTEsNyArMjkxLDcgQEAgaHZtX2VtdWxhdGVfY21weGNoZyhlbnVtIHg4Nl9zZWdtZW50IHNlZywK PiAgICAgIGlmICggYnl0ZXMgPiBzaXplb2YobG9uZykgKQo+ICAgICAgICAgIHJldHVybiBYODZF TVVMX1VOSEFORExFQUJMRTsKPiAKPiAtICAgIHJjID0gaHZtX3RyYW5zbGF0ZV9saW5lYXJfYWRk cigKPiArICAgIHJjID0gaHZtX3RyYW5zbGF0ZV92aXJ0dWFsX2FkZHIoCj4gICAgICAgICAgc2Vn LCBvZmZzZXQsIGJ5dGVzLCBodm1fYWNjZXNzX3dyaXRlLCBzaF9jdHh0LCAmYWRkcik7Cj4gICAg ICBpZiAoIHJjICkKPiAgICAgICAgICByZXR1cm4gcmM7Cj4gQEAgLTM0NSw3ICszNDUsNyBAQCBj b25zdCBzdHJ1Y3QgeDg2X2VtdWxhdGVfb3BzCj4gKnNoYWRvd19pbml0X2VtdWxhdGlvbigKPiAg ICAgIC8qIEF0dGVtcHQgdG8gcHJlZmV0Y2ggd2hvbGUgaW5zdHJ1Y3Rpb24uICovCj4gICAgICBz aF9jdHh0LT5pbnNuX2J1Zl9laXAgPSByZWdzLT5yaXA7Cj4gICAgICBzaF9jdHh0LT5pbnNuX2J1 Zl9ieXRlcyA9Cj4gLSAgICAgICAgKCFodm1fdHJhbnNsYXRlX2xpbmVhcl9hZGRyKAo+ICsgICAg ICAgICghaHZtX3RyYW5zbGF0ZV92aXJ0dWFsX2FkZHIoCj4gICAgICAgICAgICAgIHg4Nl9zZWdf Y3MsIHJlZ3MtPnJpcCwgc2l6ZW9mKHNoX2N0eHQtPmluc25fYnVmKSwKPiAgICAgICAgICAgICAg aHZtX2FjY2Vzc19pbnNuX2ZldGNoLCBzaF9jdHh0LCAmYWRkcikgJiYKPiAgICAgICAgICAgIWh2 bV9mZXRjaF9mcm9tX2d1ZXN0X2xpbmVhcigKPiBAQCAtMzc0LDcgKzM3NCw3IEBAIHZvaWQgc2hh ZG93X2NvbnRpbnVlX2VtdWxhdGlvbihzdHJ1Y3QKPiBzaF9lbXVsYXRlX2N0eHQgKnNoX2N0eHQs Cj4gICAgICB7Cj4gICAgICAgICAgLyogUHJlZmV0Y2ggbW9yZSBieXRlcy4gKi8KPiAgICAgICAg ICBzaF9jdHh0LT5pbnNuX2J1Zl9ieXRlcyA9Cj4gLSAgICAgICAgICAgICghaHZtX3RyYW5zbGF0 ZV9saW5lYXJfYWRkcigKPiArICAgICAgICAgICAgKCFodm1fdHJhbnNsYXRlX3ZpcnR1YWxfYWRk cigKPiAgICAgICAgICAgICAgICAgIHg4Nl9zZWdfY3MsIHJlZ3MtPnJpcCwgc2l6ZW9mKHNoX2N0 eHQtPmluc25fYnVmKSwKPiAgICAgICAgICAgICAgICAgIGh2bV9hY2Nlc3NfaW5zbl9mZXRjaCwg c2hfY3R4dCwgJmFkZHIpICYmCj4gICAgICAgICAgICAgICAhaHZtX2ZldGNoX2Zyb21fZ3Vlc3Rf bGluZWFyKAo+IC0tCj4gMi4xLjQKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4u b3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK