From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 3/4] net/mlx5: use port sibling iterators
Date: Thu, 4 Apr 2019 12:33:44 +0100
Message-ID: <9c54c653-5d4c-4d81-b468-4e67a50cde9a@intel.com>
References: <20181130002716.27325-1-thomas@monjalon.net>
 <20190401022700.1570-1-thomas@monjalon.net>
 <20190401022700.1570-4-thomas@monjalon.net>
 <70a875eb-661d-28db-48fa-ed59e8ad80e7@intel.com>
 <BE3D930D-A196-4C8E-B947-027638E066B1@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Shahaf Shuler <shahafs@mellanox.com>,
 Thomas Monjalon <thomas@monjalon.net>,
 "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>,
 "dev@dpdk.org" <dev@dpdk.org>
To: Yongseok Koh <yskoh@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 299941B1FF
 for <dev@dpdk.org>; Thu,  4 Apr 2019 13:33:47 +0200 (CEST)
In-Reply-To: <BE3D930D-A196-4C8E-B947-027638E066B1@mellanox.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/3/2019 7:07 PM, Yongseok Koh wrote:
> 
>> On Apr 3, 2019, at 7:19 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> On 4/1/2019 3:26 AM, Thomas Monjalon wrote:
>>> Iterating over siblings was done with RTE_ETH_FOREACH_DEV()
>>> which skips the owned ports.
>>> The new iterators RTE_ETH_FOREACH_DEV_SIBLING()
>>> and RTE_ETH_FOREACH_DEV_OF() are more appropriate and more correct.
>>>
>>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>>
>> Hi Shahaf, Yongseok,
>>
>> Any comment on this patch?
> 
> Sorry for late reply.
> I know it has been merged but it looks okay to me.

Thanks, I am appending explicit ack to the patch:

Acked-by: Yongseok Koh <yskoh@mellanox.com>