All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] crypto: virtio - Select new dependencies
@ 2022-03-08 20:53 Nathan Chancellor
  2022-03-08 21:12   ` Michael S. Tsirkin
  0 siblings, 1 reply; 4+ messages in thread
From: Nathan Chancellor @ 2022-03-08 20:53 UTC (permalink / raw)
  To: Gonglei, Michael S. Tsirkin, Jason Wang
  Cc: zhenwei pi, lei he, virtualization, linux-crypto, patches,
	Nathan Chancellor

With ARCH=riscv defconfig, there are errors at link time:

  virtio_crypto_akcipher_algs.c:(.text+0x3ea): undefined reference to `mpi_free'
  virtio_crypto_akcipher_algs.c:(.text+0x48a): undefined reference to `rsa_parse_priv_key'
  virtio_crypto_akcipher_algs.c:(.text+0x4bc): undefined reference to `rsa_parse_pub_key'
  virtio_crypto_akcipher_algs.c:(.text+0x4d0): undefined reference to `mpi_read_raw_data'
  virtio_crypto_akcipher_algs.c:(.text+0x960): undefined reference to `crypto_register_akcipher'
  virtio_crypto_akcipher_algs.c:(.text+0xa3a): undefined reference to `crypto_unregister_akcipher'

The virtio crypto driver started making use of certain libraries and
algorithms without selecting them. Do so to fix these errors.

Fixes: 8a75f36b5d7a ("virtio-crypto: implement RSA algorithm")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
 drivers/crypto/virtio/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/crypto/virtio/Kconfig b/drivers/crypto/virtio/Kconfig
index b894e3a8be4f..5f8915f4a9ff 100644
--- a/drivers/crypto/virtio/Kconfig
+++ b/drivers/crypto/virtio/Kconfig
@@ -3,8 +3,11 @@ config CRYPTO_DEV_VIRTIO
 	tristate "VirtIO crypto driver"
 	depends on VIRTIO
 	select CRYPTO_AEAD
+	select CRYPTO_AKCIPHER2
 	select CRYPTO_SKCIPHER
 	select CRYPTO_ENGINE
+	select CRYPTO_RSA
+	select MPILIB
 	help
 	  This driver provides support for virtio crypto device. If you
 	  choose 'M' here, this module will be called virtio_crypto.

base-commit: c5f633abfd09491ae7ecbc7fcfca08332ad00a8b
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH -next] crypto: virtio - Select new dependencies
  2022-03-08 20:53 [PATCH -next] crypto: virtio - Select new dependencies Nathan Chancellor
@ 2022-03-08 21:12   ` Michael S. Tsirkin
  0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2022-03-08 21:12 UTC (permalink / raw)
  To: Nathan Chancellor
  Cc: Gonglei, Jason Wang, zhenwei pi, lei he, virtualization,
	linux-crypto, patches

On Tue, Mar 08, 2022 at 01:53:09PM -0700, Nathan Chancellor wrote:
> With ARCH=riscv defconfig, there are errors at link time:
> 
>   virtio_crypto_akcipher_algs.c:(.text+0x3ea): undefined reference to `mpi_free'
>   virtio_crypto_akcipher_algs.c:(.text+0x48a): undefined reference to `rsa_parse_priv_key'
>   virtio_crypto_akcipher_algs.c:(.text+0x4bc): undefined reference to `rsa_parse_pub_key'
>   virtio_crypto_akcipher_algs.c:(.text+0x4d0): undefined reference to `mpi_read_raw_data'
>   virtio_crypto_akcipher_algs.c:(.text+0x960): undefined reference to `crypto_register_akcipher'
>   virtio_crypto_akcipher_algs.c:(.text+0xa3a): undefined reference to `crypto_unregister_akcipher'
> 
> The virtio crypto driver started making use of certain libraries and
> algorithms without selecting them. Do so to fix these errors.
> 
> Fixes: 8a75f36b5d7a ("virtio-crypto: implement RSA algorithm")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Thanks! I'll squash this into the original commit so we don't
have a broken commit during bisect.
zhenwei pi, ack pls?

> ---
>  drivers/crypto/virtio/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/crypto/virtio/Kconfig b/drivers/crypto/virtio/Kconfig
> index b894e3a8be4f..5f8915f4a9ff 100644
> --- a/drivers/crypto/virtio/Kconfig
> +++ b/drivers/crypto/virtio/Kconfig
> @@ -3,8 +3,11 @@ config CRYPTO_DEV_VIRTIO
>  	tristate "VirtIO crypto driver"
>  	depends on VIRTIO
>  	select CRYPTO_AEAD
> +	select CRYPTO_AKCIPHER2
>  	select CRYPTO_SKCIPHER
>  	select CRYPTO_ENGINE
> +	select CRYPTO_RSA
> +	select MPILIB
>  	help
>  	  This driver provides support for virtio crypto device. If you
>  	  choose 'M' here, this module will be called virtio_crypto.
> 
> base-commit: c5f633abfd09491ae7ecbc7fcfca08332ad00a8b
> -- 
> 2.35.1


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH -next] crypto: virtio - Select new dependencies
@ 2022-03-08 21:12   ` Michael S. Tsirkin
  0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2022-03-08 21:12 UTC (permalink / raw)
  To: Nathan Chancellor
  Cc: lei he, patches, zhenwei pi, virtualization, linux-crypto

On Tue, Mar 08, 2022 at 01:53:09PM -0700, Nathan Chancellor wrote:
> With ARCH=riscv defconfig, there are errors at link time:
> 
>   virtio_crypto_akcipher_algs.c:(.text+0x3ea): undefined reference to `mpi_free'
>   virtio_crypto_akcipher_algs.c:(.text+0x48a): undefined reference to `rsa_parse_priv_key'
>   virtio_crypto_akcipher_algs.c:(.text+0x4bc): undefined reference to `rsa_parse_pub_key'
>   virtio_crypto_akcipher_algs.c:(.text+0x4d0): undefined reference to `mpi_read_raw_data'
>   virtio_crypto_akcipher_algs.c:(.text+0x960): undefined reference to `crypto_register_akcipher'
>   virtio_crypto_akcipher_algs.c:(.text+0xa3a): undefined reference to `crypto_unregister_akcipher'
> 
> The virtio crypto driver started making use of certain libraries and
> algorithms without selecting them. Do so to fix these errors.
> 
> Fixes: 8a75f36b5d7a ("virtio-crypto: implement RSA algorithm")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Thanks! I'll squash this into the original commit so we don't
have a broken commit during bisect.
zhenwei pi, ack pls?

> ---
>  drivers/crypto/virtio/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/crypto/virtio/Kconfig b/drivers/crypto/virtio/Kconfig
> index b894e3a8be4f..5f8915f4a9ff 100644
> --- a/drivers/crypto/virtio/Kconfig
> +++ b/drivers/crypto/virtio/Kconfig
> @@ -3,8 +3,11 @@ config CRYPTO_DEV_VIRTIO
>  	tristate "VirtIO crypto driver"
>  	depends on VIRTIO
>  	select CRYPTO_AEAD
> +	select CRYPTO_AKCIPHER2
>  	select CRYPTO_SKCIPHER
>  	select CRYPTO_ENGINE
> +	select CRYPTO_RSA
> +	select MPILIB
>  	help
>  	  This driver provides support for virtio crypto device. If you
>  	  choose 'M' here, this module will be called virtio_crypto.
> 
> base-commit: c5f633abfd09491ae7ecbc7fcfca08332ad00a8b
> -- 
> 2.35.1

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: Re: [PATCH -next] crypto: virtio - Select new dependencies
  2022-03-08 21:12   ` Michael S. Tsirkin
  (?)
@ 2022-03-09  1:55   ` zhenwei pi
  -1 siblings, 0 replies; 4+ messages in thread
From: zhenwei pi @ 2022-03-09  1:55 UTC (permalink / raw)
  To: Michael S. Tsirkin, Nathan Chancellor
  Cc: lei he, patches, virtualization, linux-crypto


[-- Attachment #1.1: Type: text/plain, Size: 1998 bytes --]

On 3/9/22 05:12, Michael S. Tsirkin wrote:
> On Tue, Mar 08, 2022 at 01:53:09PM -0700, Nathan Chancellor wrote:
>> With ARCH=riscv defconfig, there are errors at link time:
>>
>>    virtio_crypto_akcipher_algs.c:(.text+0x3ea): undefined reference to `mpi_free'
>>    virtio_crypto_akcipher_algs.c:(.text+0x48a): undefined reference to `rsa_parse_priv_key'
>>    virtio_crypto_akcipher_algs.c:(.text+0x4bc): undefined reference to `rsa_parse_pub_key'
>>    virtio_crypto_akcipher_algs.c:(.text+0x4d0): undefined reference to `mpi_read_raw_data'
>>    virtio_crypto_akcipher_algs.c:(.text+0x960): undefined reference to `crypto_register_akcipher'
>>    virtio_crypto_akcipher_algs.c:(.text+0xa3a): undefined reference to `crypto_unregister_akcipher'
>>
>> The virtio crypto driver started making use of certain libraries and
>> algorithms without selecting them. Do so to fix these errors.
>>
>> Fixes: 8a75f36b5d7a ("virtio-crypto: implement RSA algorithm")
>> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> 
> Thanks! I'll squash this into the original commit so we don't
> have a broken commit during bisect.
> zhenwei pi, ack pls?
> 
It looks good to me, thanks a lot.

>> ---
>>   drivers/crypto/virtio/Kconfig | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/crypto/virtio/Kconfig b/drivers/crypto/virtio/Kconfig
>> index b894e3a8be4f..5f8915f4a9ff 100644
>> --- a/drivers/crypto/virtio/Kconfig
>> +++ b/drivers/crypto/virtio/Kconfig
>> @@ -3,8 +3,11 @@ config CRYPTO_DEV_VIRTIO
>>   	tristate "VirtIO crypto driver"
>>   	depends on VIRTIO
>>   	select CRYPTO_AEAD
>> +	select CRYPTO_AKCIPHER2
>>   	select CRYPTO_SKCIPHER
>>   	select CRYPTO_ENGINE
>> +	select CRYPTO_RSA
>> +	select MPILIB
>>   	help
>>   	  This driver provides support for virtio crypto device. If you
>>   	  choose 'M' here, this module will be called virtio_crypto.
>>
>> base-commit: c5f633abfd09491ae7ecbc7fcfca08332ad00a8b
>> -- 
>> 2.35.1

[-- Attachment #1.2: Type: text/html, Size: 2189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 183 bytes --]

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-09  2:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-08 20:53 [PATCH -next] crypto: virtio - Select new dependencies Nathan Chancellor
2022-03-08 21:12 ` Michael S. Tsirkin
2022-03-08 21:12   ` Michael S. Tsirkin
2022-03-09  1:55   ` zhenwei pi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.