From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=ZyMj=EB=nongnu.org=qemu-devel-bounces+qemu-devel=archiver.kernel.org@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIM_INVALID,
	DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,
	NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,
	USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 851EAC4363A
	for <qemu-devel@archiver.kernel.org>; Mon, 26 Oct 2020 14:46:39 +0000 (UTC)
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id 29C2122263
	for <qemu-devel@archiver.kernel.org>; Mon, 26 Oct 2020 14:46:39 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="kP4Kjtdw"
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29C2122263
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org
Received: from localhost ([::1]:60258 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org>)
	id 1kX3le-0006FR-8B
	for qemu-devel@archiver.kernel.org; Mon, 26 Oct 2020 10:46:38 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:52254)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <kwankhede@nvidia.com>)
 id 1kX3cr-0003H4-IM
 for qemu-devel@nongnu.org; Mon, 26 Oct 2020 10:37:34 -0400
Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:18236)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <kwankhede@nvidia.com>)
 id 1kX3co-0000WD-RZ
 for qemu-devel@nongnu.org; Mon, 26 Oct 2020 10:37:33 -0400
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by
 hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
 id <B5f96df300001>; Mon, 26 Oct 2020 07:37:36 -0700
Received: from [10.40.102.184] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 26 Oct
 2020 14:37:10 +0000
Subject: Re: [PATCH v29 05/17] vfio: Add VM state change handler to know state
 of VM
To: Alex Williamson <alex.williamson@redhat.com>
References: <1603704987-20977-1-git-send-email-kwankhede@nvidia.com>
 <1603704987-20977-6-git-send-email-kwankhede@nvidia.com>
 <20201026070056.42bb04de@w520.home>
 <ce6c6864-a8a3-269e-a9c2-3fe4d2b265b8@nvidia.com>
 <20201026080257.2f9d3506@w520.home>
X-Nvconfidentiality: public
From: Kirti Wankhede <kwankhede@nvidia.com>
Message-ID: <9c5e89fc-b247-5897-ef23-d198a97b48d3@nvidia.com>
Date: Mon, 26 Oct 2020 20:07:07 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.1
MIME-Version: 1.0
In-Reply-To: <20201026080257.2f9d3506@w520.home>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
 t=1603723056; bh=Yd2diF01NySxd8/iLB7TeOX93u7QRtrs5GfS8/5jMNI=;
 h=Subject:To:CC:References:X-Nvconfidentiality:From:Message-ID:Date:
 User-Agent:MIME-Version:In-Reply-To:Content-Type:Content-Language:
 Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy;
 b=kP4KjtdwlOu3x57Rk7jB7FQ3zHXomL3X03RQipaGpPH1Cgr8YvjIbiUjyB6B1xToX
 ljyQsW7+zZP/aLQA4IR45s/6OIHnROLSh28puw0vvULjzmkTI8PWL2Ds8z/eaQ6cfx
 XTNUhEDFEQJdLAlkhffrWgbBMMwOlg1Ty5JEDUZ3vABP3g4r2njtCHgiQ96uCP+1sw
 R23Y8Q448mxjYEJcv9WTQW+fUEmpCp9A/V4+eq0sXs2v3Bx/N8UmVVVSDIuSfgZX7V
 rp+2GV2R1o7qvHo6IYl7N0wKA0DU6UEzmQgZeD0P3I4slG8WW/64qsh/TZinUytJg5
 xoz3sHWuiH05Q==
Received-SPF: pass client-ip=216.228.121.143;
 envelope-from=kwankhede@nvidia.com; helo=hqnvemgate24.nvidia.com
X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/26 10:37:29
X-ACL-Warn: Detected OS   = Windows 7 or 8 [fuzzy]
X-Spam_score_int: -92
X-Spam_score: -9.3
X-Spam_bar: ---------
X-Spam_report: (-9.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,
 DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 NICE_REPLY_A=-2.167, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
 <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
 <mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Cc: cohuck@redhat.com, cjia@nvidia.com, zhi.wang.linux@gmail.com, aik@ozlabs.ru,
 Zhengxiao.zx@Alibaba-inc.com, shuangtai.tst@alibaba-inc.com,
 qemu-devel@nongnu.org, peterx@redhat.com, eauger@redhat.com, artemp@nvidia.com,
 yi.l.liu@intel.com, quintela@redhat.com, ziye.yang@intel.com,
 armbru@redhat.com, mlevitsk@redhat.com, pasic@linux.ibm.com,
 felipe@nutanix.com, zhi.a.wang@intel.com, mcrossley@nvidia.com,
 kevin.tian@intel.com, yan.y.zhao@intel.com, dgilbert@redhat.com,
 changpeng.liu@intel.com, eskultet@redhat.com, Ken.Xue@amd.com,
 jonathan.davies@nutanix.com, pbonzini@redhat.com, dnigam@nvidia.com
Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org
Sender: "Qemu-devel"
 <qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org>



On 10/26/2020 7:32 PM, Alex Williamson wrote:
> On Mon, 26 Oct 2020 19:18:51 +0530
> Kirti Wankhede <kwankhede@nvidia.com> wrote:
> 
>> On 10/26/2020 6:30 PM, Alex Williamson wrote:
>>> On Mon, 26 Oct 2020 15:06:15 +0530
>>> Kirti Wankhede <kwankhede@nvidia.com> wrote:
>>>    
>>>> VM state change handler is called on change in VM's state. Based on
>>>> VM state, VFIO device state should be changed.
>>>> Added read/write helper functions for migration region.
>>>> Added function to set device_state.
>>>>
>>>> Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com>
>>>> Reviewed-by: Neo Jia <cjia@nvidia.com>
>>>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>>>> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>>>> ---
>>>>    hw/vfio/migration.c           | 158 ++++++++++++++++++++++++++++++++++++++++++
>>>>    hw/vfio/trace-events          |   2 +
>>>>    include/hw/vfio/vfio-common.h |   4 ++
>>>>    3 files changed, 164 insertions(+)
>>>>
>>>> diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
>>>> index fd7faf423cdc..65ce735d667b 100644
>>>> --- a/hw/vfio/migration.c
>>>> +++ b/hw/vfio/migration.c
>>> [snip]
>>>> @@ -64,6 +216,9 @@ static int vfio_migration_init(VFIODevice *vbasedev,
>>>>            ret = -EINVAL;
>>>>            goto err;
>>>>        }
>>>> +
>>>> +    migration->vm_state = qemu_add_vm_change_state_handler(vfio_vmstate_change,
>>>> +                                                           vbasedev);
>>>>        return 0;
>>>>    
>>>>    err:
>>>
>>> Fails to build, @migration is not defined.  We could use
>>> vbasedev->migration or pull defining and setting @migration from patch
>>> 06.  Thanks,
>>>    
>>
>> Pulling and setting migration from patch 06 seems better option.
>> Should I resend patch 5 & 6 only?
> 
> I've resolved this locally as patch 05:
> 
> @@ -38,6 +190,7 @@ static int vfio_migration_init(VFIODevice *vbasedev,
>   {
>       int ret;
>       Object *obj;
> +    VFIOMigration *migration;
>   
>       if (!vbasedev->ops->vfio_get_object) {
>           return -EINVAL;
> @@ -64,6 +217,10 @@ static int vfio_migration_init(VFIODevice *vbasedev,
>           ret = -EINVAL;
>           goto err;
>       }
> +
> +    migration = vbasedev->migration;
> +    migration->vm_state = qemu_add_vm_change_state_handler(vfio_vmstate_change,
> +                                                           vbasedev);
>       return 0;
>   
>   err:
> 
> patch 06:
> 
> @@ -219,8 +243,11 @@ static int vfio_migration_init(VFIODevice *vbasedev,
>       }
>   
>       migration = vbasedev->migration;
> +    migration->vbasedev = vbasedev;
>       migration->vm_state = qemu_add_vm_change_state_handler(vfio_vmstate_change,
>                                                              vbasedev);
> +    migration->migration_state.notify = vfio_migration_state_notifier;
> +    add_migration_state_change_notifier(&migration->migration_state);
>       return 0;
>   
>   err:
> 
> If you're satisfied with that, no need to resend.  Thanks,
> 

Yes, this is exactly I was going to send.
Thanks for fixing it.

Thanks,
Kirti