From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1744384-1526544941-2-14656986910858348430 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.248, MAILING_LIST_MULTI -1, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='net', MailFrom='org' X-Spam-charsets: plain='utf-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1526544940; b=KQKjcgDlGQxqw4WfSgdRoCCIV7kQPfPmhnv+g3jV4CcAT7ZBky fVfwis0oux07tIMmO15lVcg0Yq0QGdYwlEPDbf08PHOxNNTffHmiQ8c63nHh9CyU /jUzGAAMQqVNb8TvlBvY9f7ACeHBeVlU4yIP2KCqDzLNCvg/ZXEu9cvm+eLnSApn CZ46xp0m/50SaSzKpAEc+6EImL3WN1xRPoisEJPkHYkeH1u4UzPQBU+ayJnxvB9N vo7K7VRgx5DtLAPhHaio3rFa9xigO6fWC5IOvMFxsgsTkEYe2RvPCeXcItxrUzlR g9GDrRKre+V0mPaW2sMCjkYfeIbZ3gcLS/1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:subject:to:cc:references:message-id :date:mime-version:in-reply-to:content-type :content-transfer-encoding:sender:list-id; s=fm2; t=1526544940; bh=vOFd2BlBXWeLmXYU2jVtAE0Rtexa3T7jt+YalmeqXWQ=; b=DGto/ZUHi47u T1r3PIzwjCpuwjEQQ/TxWXhCu0mWhEd6ECRwE3IpWmB5lQHjETaF96pn8ud5ABjR 6MiGSYuMN9N81laPhcBFOI7bIxabvcTDXHed1DO0Suo+/V0G8OygIYnYjMoTJg7A rj3lA5Kbluqb2fYhBUNQNVRAFTHCZrz+1o1Tg8vzbYqEMeCNbfTXhTxKq8Us452P UvVy3qG89Sslg16BXedfadDhRLKE8OvLYmD9bnDxiXcnBhqOyHG85YUtg1uukc9c dD2T+Ys4ntBYljwG1Qzal1KsK82CpGareC8FfHu77s0uGWBZuT9mLFNZkUSvh5bs iNHdOHYYDQ== ARC-Authentication-Results: i=1; mx4.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=godking.net; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=godking.net header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx4.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=godking.net; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=godking.net header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfLsms8F5sgWgss6BHi1pOTPEsOc7QYe+b6uAXlovp37SucN7ifPm/Orf6eh6lBFy5DtG+PCb3v/6c3upUnqr6CRhivGBxfS0bzQhN95nNHe42v2z8Tx8 eQhLoCymT+167EUcRgPjk8t4XkY/T2tR09CfzHkhOiFfmhDTXV43KDUwGfw8yantsGmDweCcTqXHqeJYg+3ERXmPpq1qbDDYi0bwj523eEATd6UhHBdXqZEU X-CM-Analysis: v=2.3 cv=JLoVTfCb c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=IkcTkHD0fZMA:10 a=VUJBJC2UJ8kA:10 a=20KFwNOVAAAA:8 a=97dSWYl1AAAA:8 a=FXmwvOYqAAAA:8 a=VwQbUJbxAAAA:8 a=LmxMlfOCb3ZnksLFJhwA:9 a=QEXdDO2ut3YA:10 a=x8gzFH9gYPwA:10 a=OJayMvquMdr9gCXU5-l_:22 a=kXiaH_QbUnwHKQcifsFq:22 a=AjGcO6oz07-iQ99wixmX:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752391AbeEQIPN (ORCPT ); Thu, 17 May 2018 04:15:13 -0400 Received: from s18231873.onlinehome-server.info ([217.160.179.168]:56514 "EHLO godking.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752296AbeEQIPK (ORCPT ); Thu, 17 May 2018 04:15:10 -0400 From: Alexander Kappner Subject: Re: [PATCH] usb-storage: Add quirks to make G-Technology "G-Drive" work To: Alan Stern Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org References: Message-ID: <9c638d96-d2b4-cf19-d7e8-4ef93549bd79@godking.net> Date: Thu, 17 May 2018 01:15:04 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Hi Alan, thanks for reviewing. (This is my first contribution that touches usb-storage, so please bear with me.) > That's kind of weird. Does the drive work under Windows in UAS mode? On the Windows 10 VM that I just spun up for testing this, access to the drive uses "usbstor.inf" (rather than "uaspstor.sys"). So I believe the answer is no. > If so, why are the WRITE(16) commands failing under Linux? I don't know exactly why they're failing, but another entry in the unusual_uas.h shows another SimpleTech device (only with a slightly different product ID) needing the same UAS quirk (see https://bugzilla.redhat.com/show_bug.cgi?id=1124119). So my guess is those drives are just buggy. > That doesn't quite make sense. Since you prevent the uas driver from > binding to this device, it will end up using usb-storage no matter how > the kernel was built. Therefore the second quirk flag has to go into > unusual_devs.h no matter what. Yes that's what I was trying to get at. So even though the UAS flag would conceptually belong into unusual_uas, I'm putting both into unusual_devs to avoid having to create two separate entries for the same device. > You don't describe the second quirk flag at all. Are you sure it is > needed? Yes. Without this flag, the device keeps throwing similar errors on usb-storage. That's the same result I get on a host that doesn't have UAS compiled in. Here's a dmesg: [ 2.183472] usb 3-1: New USB device found, idVendor=4971, idProduct=8024, bcdDevice=24.03 [ 2.184285] usb 3-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [ 2.184980] usb 3-1: Product: G-DRIVE [ 2.185447] usb 3-1: Manufacturer: HGST [ 2.185829] usb 3-1: SerialNumber: AA015010004C [ 2.195509] usb-storage 3-1:1.0: USB Mass Storage device detected [ 2.198668] Floppy drive(s): fd0 is 2.88M AMI BIOS [ 2.202981] scsi host2: usb-storage 3-1:1.0 ... [ 3.233085] scsi 2:0:0:0: Direct-Access G-DRIVE 2403 PQ: 0 ANSI: 6 [ 3.234514] sd 2:0:0:0: Attached scsi generic sg1 type 0 [ 3.235465] sd 2:0:0:0: [sda] Very big device. Trying to use READ CAPACITY(16). [ 3.236847] sd 2:0:0:0: [sda] 7814037168 512-byte logical blocks: (4.00 TB/3.64 TiB) [ 3.237794] sd 2:0:0:0: [sda] 4096-byte physical blocks [ 3.241255] sd 2:0:0:0: [sda] Write Protect is off [ 3.242096] sd 2:0:0:0: [sda] Mode Sense: 47 00 10 08 [ 3.243595] sd 2:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA [ 3.257893] sda: sda1 sda9 [ 3.261402] sd 2:0:0:0: [sda] Attached SCSI disk ... [ 92.433428] sd 2:0:0:0: [sda] tag#0 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE [ 92.434759] sd 2:0:0:0: [sda] tag#0 Sense Key : Illegal Request [current] [ 92.435637] sd 2:0:0:0: [sda] tag#0 Add. Sense: Invalid field in cdb [ 92.436401] sd 2:0:0:0: [sda] tag#0 CDB: Write(16) 8a 08 00 00 00 00 00 00 00 00 00 00 00 08 00 00 [ 92.437493] print_req_error: critical target error, dev sda, sector 0 [ 92.438211] Buffer I/O error on dev sda, logical block 0, lost sync page write [ 92.516692] EXT4-fs (sda): mounted filesystem with ordered data mode. Opts: (null) [ 101.449311] sd 2:0:0:0: [sda] tag#0 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE [ 101.450598] sd 2:0:0:0: [sda] tag#0 Sense Key : Illegal Request [current] [ 101.451401] sd 2:0:0:0: [sda] tag#0 Add. Sense: Invalid field in cdb [ 101.452041] sd 2:0:0:0: [sda] tag#0 CDB: Write(16) 8a 08 00 00 00 00 e8 c4 00 18 00 00 00 08 00 00 [ 101.452906] print_req_error: critical target error, dev sda, sector 3905159192 [ 101.453593] print_req_error: critical target error, dev sda, sector 3905159192 [ 101.454889] Aborting journal on device sda-8. [ 101.457103] sd 2:0:0:0: [sda] tag#0 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE [ 101.457988] sd 2:0:0:0: [sda] tag#0 Sense Key : Illegal Request [current] [ 101.458637] sd 2:0:0:0: [sda] tag#0 Add. Sense: Invalid field in cdb [ 101.459250] sd 2:0:0:0: [sda] tag#0 CDB: Write(16) 8a 08 00 00 00 00 e8 c4 00 00 00 00 00 08 00 00 Source code comments describe this as a known problem (scsiglue.c:182): /* * Some devices don't like MODE SENSE with page=0x3f, * which is the command used for checking if a device * is write-protected. Now that we tell the sd driver * to do a 192-byte transfer with this command the * majority of devices work fine, but a few still can't * handle it. The sd driver will simply assume those * devices are write-enabled. */ if (us->fflags & US_FL_NO_WP_DETECT) sdev->skip_ms_page_3f = 1; --agk On 05/16/2018 01:55 PM, Alan Stern wrote: > On Wed, 16 May 2018, Alexander Kappner wrote: > >> The "G-Drive" (sold by G-Technology) external USB 3.0 drive >> hangs on write access under UAS: >> >> [ 136.079121] sd 15:0:0:0: [sdi] tag#0 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE >> [ 136.079144] sd 15:0:0:0: [sdi] tag#0 Sense Key : Illegal Request [current] >> [ 136.079152] sd 15:0:0:0: [sdi] tag#0 Add. Sense: Invalid field in cdb >> [ 136.079176] sd 15:0:0:0: [sdi] tag#0 CDB: Write(16) 8a 08 00 00 00 00 00 00 00 00 00 00 00 08 00 00 >> [ 136.079180] print_req_error: critical target error, dev sdi, sector 0 >> [ 136.079183] Buffer I/O error on dev sdi, logical block 0, lost sync page write >> [ 136.173148] EXT4-fs (sdi): mounted filesystem with ordered data mode. Opts: (null) >> [ 140.583998] sd 15:0:0:0: [sdi] tag#0 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE >> [ 140.584010] sd 15:0:0:0: [sdi] tag#0 Sense Key : Illegal Request [current] >> [ 140.584016] sd 15:0:0:0: [sdi] tag#0 Add. Sense: Invalid field in cdb >> [ 140.584022] sd 15:0:0:0: [sdi] tag#0 CDB: Write(16) 8a 08 00 00 00 00 e8 c4 00 18 00 00 00 08 00 00 >> [ 140.584025] print_req_error: critical target error, dev sdi, sector 3905159192 >> [ 140.584044] print_req_error: critical target error, dev sdi, sector 3905159192 >> [ 140.584052] Aborting journal on device sdi-8. > > That's kind of weird. Does the drive work under Windows in UAS mode? > If so, why are the WRITE(16) commands failing under Linux? > >> The proposed patch adds compatibility quirks. Because the drive requires two >> quirks (one to disable UAS, and another to work with usb-storage), adding this >> under unusual_devs.h and not unusual_uas.h so kernels compiled without UAS >> receive the quirk. > > That doesn't quite make sense. Since you prevent the uas driver from > binding to this device, it will end up using usb-storage no matter how > the kernel was built. Therefore the second quirk flag has to go into > unusual_devs.h no matter what. > >> With the patch, the drive works reliably >> (tested on NEC Corporation uPD720200 USB 3.0 host controller). > > You don't describe the second quirk flag at all. Are you sure it is > needed? > >> Signed-off-by: Alexander Kappner >> --- >> drivers/usb/storage/unusual_devs.h | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h >> index 747d3a9..b8661a1 100644 >> --- a/drivers/usb/storage/unusual_devs.h >> +++ b/drivers/usb/storage/unusual_devs.h >> @@ -2321,6 +2321,15 @@ UNUSUAL_DEV( 0x4146, 0xba01, 0x0100, 0x0100, >> "Micro Mini 1GB", >> USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_NOT_LOCKABLE ), >> >> +/* "G-DRIVE" external HDD hangs on write without these. >> + * Reported-by: Alexander Kappner >> + */ >> +UNUSUAL_DEV(0x4971, 0x8024, 0x0000, 0x9999, >> + "SimpleTech", >> + "External HDD", >> + USB_SC_DEVICE, USB_PR_DEVICE, NULL, >> + US_FL_IGNORE_UAS | US_FL_NO_WP_DETECT), >> + >> /* >> * Nick Bowler >> * SCSI stack spams (otherwise harmless) error messages. >> From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb-storage: Add quirks to make G-Technology "G-Drive" work From: Alexander Kappner Message-Id: <9c638d96-d2b4-cf19-d7e8-4ef93549bd79@godking.net> Date: Thu, 17 May 2018 01:15:04 -0700 To: Alan Stern Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org List-ID: SGkgQWxhbiwKCnRoYW5rcyBmb3IgcmV2aWV3aW5nLiAoVGhpcyBpcyBteSBmaXJzdCBjb250cmli dXRpb24gdGhhdCB0b3VjaGVzIAp1c2Itc3RvcmFnZSwgc28gcGxlYXNlIGJlYXIgd2l0aCBtZS4p Cgo+IFRoYXQncyBraW5kIG9mIHdlaXJkLiAgRG9lcyB0aGUgZHJpdmUgd29yayB1bmRlciBXaW5k b3dzIGluIFVBUyBtb2RlPyAgCgpPbiB0aGUgV2luZG93cyAxMCBWTSB0aGF0IEkganVzdCBzcHVu IHVwIGZvciB0ZXN0aW5nIHRoaXMsIGFjY2VzcyB0byB0aGUgCmRyaXZlIHVzZXMgInVzYnN0b3Iu aW5mIiAocmF0aGVyIHRoYW4gInVhc3BzdG9yLnN5cyIpLiBTbyBJIGJlbGlldmUgdGhlIAphbnN3 ZXIgaXMgbm8uIAoKPiBJZiBzbywgd2h5IGFyZSB0aGUgV1JJVEUoMTYpIGNvbW1hbmRzIGZhaWxp bmcgdW5kZXIgTGludXg/CgpJIGRvbid0IGtub3cgZXhhY3RseSB3aHkgdGhleSdyZSBmYWlsaW5n LCBidXQgYW5vdGhlciBlbnRyeSBpbiB0aGUgCnVudXN1YWxfdWFzLmggc2hvd3MgYW5vdGhlciBT aW1wbGVUZWNoIGRldmljZSAob25seSB3aXRoIGEgc2xpZ2h0bHkgCmRpZmZlcmVudCBwcm9kdWN0 IElEKSBuZWVkaW5nIHRoZSBzYW1lIFVBUyBxdWlyayAoc2VlIApodHRwczovL2J1Z3ppbGxhLnJl ZGhhdC5jb20vc2hvd19idWcuY2dpP2lkPTExMjQxMTkpLiBTbyBteSBndWVzcyBpcyB0aG9zZSAK ZHJpdmVzIGFyZSBqdXN0IGJ1Z2d5LiAKCj4gVGhhdCBkb2Vzbid0IHF1aXRlIG1ha2Ugc2Vuc2Uu ICBTaW5jZSB5b3UgcHJldmVudCB0aGUgdWFzIGRyaXZlciBmcm9tIAo+IGJpbmRpbmcgdG8gdGhp cyBkZXZpY2UsIGl0IHdpbGwgZW5kIHVwIHVzaW5nIHVzYi1zdG9yYWdlIG5vIG1hdHRlciBob3cg Cj4gdGhlIGtlcm5lbCB3YXMgYnVpbHQuICBUaGVyZWZvcmUgdGhlIHNlY29uZCBxdWlyayBmbGFn IGhhcyB0byBnbyBpbnRvIAo+IHVudXN1YWxfZGV2cy5oIG5vIG1hdHRlciB3aGF0LgoKWWVzIHRo YXQncyB3aGF0IEkgd2FzIHRyeWluZyB0byBnZXQgYXQuIFNvIGV2ZW4gdGhvdWdoIHRoZSBVQVMg ZmxhZyB3b3VsZCAKY29uY2VwdHVhbGx5IGJlbG9uZyBpbnRvIHVudXN1YWxfdWFzLCBJJ20gcHV0 dGluZyBib3RoIGludG8gdW51c3VhbF9kZXZzIHRvIAphdm9pZCBoYXZpbmcgdG8gY3JlYXRlIHR3 byBzZXBhcmF0ZSBlbnRyaWVzIGZvciB0aGUgc2FtZSBkZXZpY2UuCgo+IFlvdSBkb24ndCBkZXNj cmliZSB0aGUgc2Vjb25kIHF1aXJrIGZsYWcgYXQgYWxsLiAgQXJlIHlvdSBzdXJlIGl0IGlzIAo+ IG5lZWRlZD8KClllcy4gV2l0aG91dCB0aGlzIGZsYWcsIHRoZSBkZXZpY2Uga2VlcHMgdGhyb3dp bmcgc2ltaWxhciBlcnJvcnMgb24gCnVzYi1zdG9yYWdlLiBUaGF0J3MgdGhlIHNhbWUgcmVzdWx0 IEkgZ2V0IG9uIGEgaG9zdCB0aGF0IGRvZXNuJ3QgaGF2ZSBVQVMgCmNvbXBpbGVkIGluLiBIZXJl J3MgYSBkbWVzZzoKClsgICAgMi4xODM0NzJdIHVzYiAzLTE6IE5ldyBVU0IgZGV2aWNlIGZvdW5k LCBpZFZlbmRvcj00OTcxLCBpZFByb2R1Y3Q9ODAyNCwgYmNkRGV2aWNlPTI0LjAzClsgICAgMi4x ODQyODVdIHVzYiAzLTE6IE5ldyBVU0IgZGV2aWNlIHN0cmluZ3M6IE1mcj0xLCBQcm9kdWN0PTIs IFNlcmlhbE51bWJlcj0zClsgICAgMi4xODQ5ODBdIHVzYiAzLTE6IFByb2R1Y3Q6IEctRFJJVkUK WyAgICAyLjE4NTQ0N10gdXNiIDMtMTogTWFudWZhY3R1cmVyOiBIR1NUClsgICAgMi4xODU4Mjld IHVzYiAzLTE6IFNlcmlhbE51bWJlcjogQUEwMTUwMTAwMDRDClsgICAgMi4xOTU1MDldIHVzYi1z dG9yYWdlIDMtMToxLjA6IFVTQiBNYXNzIFN0b3JhZ2UgZGV2aWNlIGRldGVjdGVkClsgICAgMi4x OTg2NjhdIEZsb3BweSBkcml2ZShzKTogZmQwIGlzIDIuODhNIEFNSSBCSU9TClsgICAgMi4yMDI5 ODFdIHNjc2kgaG9zdDI6IHVzYi1zdG9yYWdlIDMtMToxLjAKLi4uClsgICAgMy4yMzMwODVdIHNj c2kgMjowOjA6MDogRGlyZWN0LUFjY2VzcyAgICAgRy1EUklWRSAgICAgICAgICAgICAgICAgICAy NDAzIFBROiAwIEFOU0k6IDYKWyAgICAzLjIzNDUxNF0gc2QgMjowOjA6MDogQXR0YWNoZWQgc2Nz aSBnZW5lcmljIHNnMSB0eXBlIDAKWyAgICAzLjIzNTQ2NV0gc2QgMjowOjA6MDogW3NkYV0gVmVy eSBiaWcgZGV2aWNlLiBUcnlpbmcgdG8gdXNlIFJFQUQgQ0FQQUNJVFkoMTYpLgpbICAgIDMuMjM2 ODQ3XSBzZCAyOjA6MDowOiBbc2RhXSA3ODE0MDM3MTY4IDUxMi1ieXRlIGxvZ2ljYWwgYmxvY2tz OiAoNC4wMCBUQi8zLjY0IFRpQikKWyAgICAzLjIzNzc5NF0gc2QgMjowOjA6MDogW3NkYV0gNDA5 Ni1ieXRlIHBoeXNpY2FsIGJsb2NrcwpbICAgIDMuMjQxMjU1XSBzZCAyOjA6MDowOiBbc2RhXSBX cml0ZSBQcm90ZWN0IGlzIG9mZgpbICAgIDMuMjQyMDk2XSBzZCAyOjA6MDowOiBbc2RhXSBNb2Rl IFNlbnNlOiA0NyAwMCAxMCAwOApbICAgIDMuMjQzNTk1XSBzZCAyOjA6MDowOiBbc2RhXSBXcml0 ZSBjYWNoZTogZW5hYmxlZCwgcmVhZCBjYWNoZTogZW5hYmxlZCwgc3VwcG9ydHMgRFBPIGFuZCBG VUEKWyAgICAzLjI1Nzg5M10gIHNkYTogc2RhMSBzZGE5ClsgICAgMy4yNjE0MDJdIHNkIDI6MDow OjA6IFtzZGFdIEF0dGFjaGVkIFNDU0kgZGlzawouLi4KWyAgIDkyLjQzMzQyOF0gc2QgMjowOjA6 MDogW3NkYV0gdGFnIzAgRkFJTEVEIFJlc3VsdDogaG9zdGJ5dGU9RElEX09LIGRyaXZlcmJ5dGU9 RFJJVkVSX1NFTlNFClsgICA5Mi40MzQ3NTldIHNkIDI6MDowOjA6IFtzZGFdIHRhZyMwIFNlbnNl IEtleSA6IElsbGVnYWwgUmVxdWVzdCBbY3VycmVudF0gClsgICA5Mi40MzU2MzddIHNkIDI6MDow OjA6IFtzZGFdIHRhZyMwIEFkZC4gU2Vuc2U6IEludmFsaWQgZmllbGQgaW4gY2RiClsgICA5Mi40 MzY0MDFdIHNkIDI6MDowOjA6IFtzZGFdIHRhZyMwIENEQjogV3JpdGUoMTYpIDhhIDA4IDAwIDAw IDAwIDAwIDAwIDAwIDAwIDAwIDAwIDAwIDAwIDA4IDAwIDAwClsgICA5Mi40Mzc0OTNdIHByaW50 X3JlcV9lcnJvcjogY3JpdGljYWwgdGFyZ2V0IGVycm9yLCBkZXYgc2RhLCBzZWN0b3IgMApbICAg OTIuNDM4MjExXSBCdWZmZXIgSS9PIGVycm9yIG9uIGRldiBzZGEsIGxvZ2ljYWwgYmxvY2sgMCwg bG9zdCBzeW5jIHBhZ2Ugd3JpdGUKWyAgIDkyLjUxNjY5Ml0gRVhUNC1mcyAoc2RhKTogbW91bnRl ZCBmaWxlc3lzdGVtIHdpdGggb3JkZXJlZCBkYXRhIG1vZGUuIE9wdHM6IChudWxsKQpbICAxMDEu NDQ5MzExXSBzZCAyOjA6MDowOiBbc2RhXSB0YWcjMCBGQUlMRUQgUmVzdWx0OiBob3N0Ynl0ZT1E SURfT0sgZHJpdmVyYnl0ZT1EUklWRVJfU0VOU0UKWyAgMTAxLjQ1MDU5OF0gc2QgMjowOjA6MDog W3NkYV0gdGFnIzAgU2Vuc2UgS2V5IDogSWxsZWdhbCBSZXF1ZXN0IFtjdXJyZW50XSAKWyAgMTAx LjQ1MTQwMV0gc2QgMjowOjA6MDogW3NkYV0gdGFnIzAgQWRkLiBTZW5zZTogSW52YWxpZCBmaWVs ZCBpbiBjZGIKWyAgMTAxLjQ1MjA0MV0gc2QgMjowOjA6MDogW3NkYV0gdGFnIzAgQ0RCOiBXcml0 ZSgxNikgOGEgMDggMDAgMDAgMDAgMDAgZTggYzQgMDAgMTggMDAgMDAgMDAgMDggMDAgMDAKWyAg MTAxLjQ1MjkwNl0gcHJpbnRfcmVxX2Vycm9yOiBjcml0aWNhbCB0YXJnZXQgZXJyb3IsIGRldiBz ZGEsIHNlY3RvciAzOTA1MTU5MTkyClsgIDEwMS40NTM1OTNdIHByaW50X3JlcV9lcnJvcjogY3Jp dGljYWwgdGFyZ2V0IGVycm9yLCBkZXYgc2RhLCBzZWN0b3IgMzkwNTE1OTE5MgpbICAxMDEuNDU0 ODg5XSBBYm9ydGluZyBqb3VybmFsIG9uIGRldmljZSBzZGEtOC4KWyAgMTAxLjQ1NzEwM10gc2Qg MjowOjA6MDogW3NkYV0gdGFnIzAgRkFJTEVEIFJlc3VsdDogaG9zdGJ5dGU9RElEX09LIGRyaXZl cmJ5dGU9RFJJVkVSX1NFTlNFClsgIDEwMS40NTc5ODhdIHNkIDI6MDowOjA6IFtzZGFdIHRhZyMw IFNlbnNlIEtleSA6IElsbGVnYWwgUmVxdWVzdCBbY3VycmVudF0gClsgIDEwMS40NTg2MzddIHNk IDI6MDowOjA6IFtzZGFdIHRhZyMwIEFkZC4gU2Vuc2U6IEludmFsaWQgZmllbGQgaW4gY2RiClsg IDEwMS40NTkyNTBdIHNkIDI6MDowOjA6IFtzZGFdIHRhZyMwIENEQjogV3JpdGUoMTYpIDhhIDA4 IDAwIDAwIDAwIDAwIGU4IGM0IDAwIDAwIDAwIDAwIDAwIDA4IDAwIDAwCgpTb3VyY2UgY29kZSBj b21tZW50cyBkZXNjcmliZSB0aGlzIGFzIGEga25vd24gcHJvYmxlbSAoc2NzaWdsdWUuYzoxODIp OgoKICAgICAgICAgICAgICAgIC8qCiAgICAgICAgICAgICAgICAgKiBTb21lIGRldmljZXMgZG9u J3QgbGlrZSBNT0RFIFNFTlNFIHdpdGggcGFnZT0weDNmLAogICAgICAgICAgICAgICAgICogd2hp Y2ggaXMgdGhlIGNvbW1hbmQgdXNlZCBmb3IgY2hlY2tpbmcgaWYgYSBkZXZpY2UKICAgICAgICAg ICAgICAgICAqIGlzIHdyaXRlLXByb3RlY3RlZC4gIE5vdyB0aGF0IHdlIHRlbGwgdGhlIHNkIGRy aXZlcgogICAgICAgICAgICAgICAgICogdG8gZG8gYSAxOTItYnl0ZSB0cmFuc2ZlciB3aXRoIHRo aXMgY29tbWFuZCB0aGUKICAgICAgICAgICAgICAgICAqIG1ham9yaXR5IG9mIGRldmljZXMgd29y ayBmaW5lLCBidXQgYSBmZXcgc3RpbGwgY2FuJ3QKICAgICAgICAgICAgICAgICAqIGhhbmRsZSBp dC4gIFRoZSBzZCBkcml2ZXIgd2lsbCBzaW1wbHkgYXNzdW1lIHRob3NlCiAgICAgICAgICAgICAg ICAgKiBkZXZpY2VzIGFyZSB3cml0ZS1lbmFibGVkLgogICAgICAgICAgICAgICAgICovCiAgICAg ICAgICAgICAgICBpZiAodXMtPmZmbGFncyAmIFVTX0ZMX05PX1dQX0RFVEVDVCkKICAgICAgICAg ICAgICAgICAgICAgICAgc2Rldi0+c2tpcF9tc19wYWdlXzNmID0gMTsKCi0tYWdrIAoKCgpPbiAw NS8xNi8yMDE4IDAxOjU1IFBNLCBBbGFuIFN0ZXJuIHdyb3RlOgo+IE9uIFdlZCwgMTYgTWF5IDIw MTgsIEFsZXhhbmRlciBLYXBwbmVyIHdyb3RlOgo+IAo+PiBUaGUgIkctRHJpdmUiIChzb2xkIGJ5 IEctVGVjaG5vbG9neSkgZXh0ZXJuYWwgVVNCIDMuMCBkcml2ZQo+PiAgaGFuZ3Mgb24gd3JpdGUg YWNjZXNzIHVuZGVyIFVBUzoKPj4KPj4gWyAgMTM2LjA3OTEyMV0gc2QgMTU6MDowOjA6IFtzZGld IHRhZyMwIEZBSUxFRCBSZXN1bHQ6IGhvc3RieXRlPURJRF9PSyBkcml2ZXJieXRlPURSSVZFUl9T RU5TRQo+PiBbICAxMzYuMDc5MTQ0XSBzZCAxNTowOjA6MDogW3NkaV0gdGFnIzAgU2Vuc2UgS2V5 IDogSWxsZWdhbCBSZXF1ZXN0IFtjdXJyZW50XQo+PiBbICAxMzYuMDc5MTUyXSBzZCAxNTowOjA6 MDogW3NkaV0gdGFnIzAgQWRkLiBTZW5zZTogSW52YWxpZCBmaWVsZCBpbiBjZGIKPj4gWyAgMTM2 LjA3OTE3Nl0gc2QgMTU6MDowOjA6IFtzZGldIHRhZyMwIENEQjogV3JpdGUoMTYpIDhhIDA4IDAw IDAwIDAwIDAwIDAwIDAwIDAwIDAwIDAwIDAwIDAwIDA4IDAwIDAwCj4+IFsgIDEzNi4wNzkxODBd IHByaW50X3JlcV9lcnJvcjogY3JpdGljYWwgdGFyZ2V0IGVycm9yLCBkZXYgc2RpLCBzZWN0b3Ig MAo+PiBbICAxMzYuMDc5MTgzXSBCdWZmZXIgSS9PIGVycm9yIG9uIGRldiBzZGksIGxvZ2ljYWwg YmxvY2sgMCwgbG9zdCBzeW5jIHBhZ2Ugd3JpdGUKPj4gWyAgMTM2LjE3MzE0OF0gRVhUNC1mcyAo c2RpKTogbW91bnRlZCBmaWxlc3lzdGVtIHdpdGggb3JkZXJlZCBkYXRhIG1vZGUuIE9wdHM6IChu dWxsKQo+PiBbICAxNDAuNTgzOTk4XSBzZCAxNTowOjA6MDogW3NkaV0gdGFnIzAgRkFJTEVEIFJl c3VsdDogaG9zdGJ5dGU9RElEX09LIGRyaXZlcmJ5dGU9RFJJVkVSX1NFTlNFCj4+IFsgIDE0MC41 ODQwMTBdIHNkIDE1OjA6MDowOiBbc2RpXSB0YWcjMCBTZW5zZSBLZXkgOiBJbGxlZ2FsIFJlcXVl c3QgW2N1cnJlbnRdCj4+IFsgIDE0MC41ODQwMTZdIHNkIDE1OjA6MDowOiBbc2RpXSB0YWcjMCBB ZGQuIFNlbnNlOiBJbnZhbGlkIGZpZWxkIGluIGNkYgo+PiBbICAxNDAuNTg0MDIyXSBzZCAxNTow OjA6MDogW3NkaV0gdGFnIzAgQ0RCOiBXcml0ZSgxNikgOGEgMDggMDAgMDAgMDAgMDAgZTggYzQg MDAgMTggMDAgMDAgMDAgMDggMDAgMDAKPj4gWyAgMTQwLjU4NDAyNV0gcHJpbnRfcmVxX2Vycm9y OiBjcml0aWNhbCB0YXJnZXQgZXJyb3IsIGRldiBzZGksIHNlY3RvciAzOTA1MTU5MTkyCj4+IFsg IDE0MC41ODQwNDRdIHByaW50X3JlcV9lcnJvcjogY3JpdGljYWwgdGFyZ2V0IGVycm9yLCBkZXYg c2RpLCBzZWN0b3IgMzkwNTE1OTE5Mgo+PiBbICAxNDAuNTg0MDUyXSBBYm9ydGluZyBqb3VybmFs IG9uIGRldmljZSBzZGktOC4KPiAKPiBUaGF0J3Mga2luZCBvZiB3ZWlyZC4gIERvZXMgdGhlIGRy aXZlIHdvcmsgdW5kZXIgV2luZG93cyBpbiBVQVMgbW9kZT8gIAo+IElmIHNvLCB3aHkgYXJlIHRo ZSBXUklURSgxNikgY29tbWFuZHMgZmFpbGluZyB1bmRlciBMaW51eD8KPiAKPj4gVGhlIHByb3Bv c2VkIHBhdGNoIGFkZHMgY29tcGF0aWJpbGl0eSBxdWlya3MuIEJlY2F1c2UgdGhlIGRyaXZlIHJl cXVpcmVzIHR3bwo+PiBxdWlya3MgKG9uZSB0byBkaXNhYmxlIFVBUywgYW5kIGFub3RoZXIgdG8g d29yayB3aXRoIHVzYi1zdG9yYWdlKSwgYWRkaW5nIHRoaXMKPj4gdW5kZXIgdW51c3VhbF9kZXZz LmggYW5kIG5vdCB1bnVzdWFsX3Vhcy5oIHNvIGtlcm5lbHMgY29tcGlsZWQgd2l0aG91dCBVQVMK Pj4gcmVjZWl2ZSB0aGUgcXVpcmsuCj4gCj4gVGhhdCBkb2Vzbid0IHF1aXRlIG1ha2Ugc2Vuc2Uu ICBTaW5jZSB5b3UgcHJldmVudCB0aGUgdWFzIGRyaXZlciBmcm9tIAo+IGJpbmRpbmcgdG8gdGhp cyBkZXZpY2UsIGl0IHdpbGwgZW5kIHVwIHVzaW5nIHVzYi1zdG9yYWdlIG5vIG1hdHRlciBob3cg Cj4gdGhlIGtlcm5lbCB3YXMgYnVpbHQuICBUaGVyZWZvcmUgdGhlIHNlY29uZCBxdWlyayBmbGFn IGhhcyB0byBnbyBpbnRvIAo+IHVudXN1YWxfZGV2cy5oIG5vIG1hdHRlciB3aGF0Lgo+IAo+PiAg V2l0aCB0aGUgcGF0Y2gsIHRoZSBkcml2ZSB3b3JrcyByZWxpYWJseQo+PiAodGVzdGVkIG9uIE5F QyBDb3Jwb3JhdGlvbiB1UEQ3MjAyMDAgVVNCIDMuMCBob3N0IGNvbnRyb2xsZXIpLgo+IAo+IFlv dSBkb24ndCBkZXNjcmliZSB0aGUgc2Vjb25kIHF1aXJrIGZsYWcgYXQgYWxsLiAgQXJlIHlvdSBz dXJlIGl0IGlzIAo+IG5lZWRlZD8KPiAKPj4gU2lnbmVkLW9mZi1ieTogQWxleGFuZGVyIEthcHBu ZXIgPGFna0Bnb2RraW5nLm5ldD4KPj4gLS0tCj4+ICBkcml2ZXJzL3VzYi9zdG9yYWdlL3VudXN1 YWxfZGV2cy5oIHwgOCArKysrKysrKwo+PiAgMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygr KQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2Ivc3RvcmFnZS91bnVzdWFsX2RldnMuaCBi L2RyaXZlcnMvdXNiL3N0b3JhZ2UvdW51c3VhbF9kZXZzLmgKPj4gaW5kZXggNzQ3ZDNhOS4uYjg2 NjFhMSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy91c2Ivc3RvcmFnZS91bnVzdWFsX2RldnMuaAo+ PiArKysgYi9kcml2ZXJzL3VzYi9zdG9yYWdlL3VudXN1YWxfZGV2cy5oCj4+IEBAIC0yMzIxLDYg KzIzMjEsMTUgQEAgVU5VU1VBTF9ERVYoICAweDQxNDYsIDB4YmEwMSwgMHgwMTAwLCAweDAxMDAs Cj4+ICAJCSJNaWNybyBNaW5pIDFHQiIsCj4+ICAJCVVTQl9TQ19ERVZJQ0UsIFVTQl9QUl9ERVZJ Q0UsIE5VTEwsIFVTX0ZMX05PVF9MT0NLQUJMRSApLAo+PiAgCj4+ICsvKiAiRy1EUklWRSIgZXh0 ZXJuYWwgSEREIGhhbmdzIG9uIHdyaXRlIHdpdGhvdXQgdGhlc2UuCj4+ICsgKiBSZXBvcnRlZC1i eTogQWxleGFuZGVyIEthcHBuZXIgPGFna0Bnb2RraW5nLm5ldD4KPj4gKyAqLwo+PiArVU5VU1VB TF9ERVYoMHg0OTcxLCAweDgwMjQsIDB4MDAwMCwgMHg5OTk5LAo+PiArCQkiU2ltcGxlVGVjaCIs Cj4+ICsJCSJFeHRlcm5hbCBIREQiLAo+PiArCQlVU0JfU0NfREVWSUNFLCBVU0JfUFJfREVWSUNF LCBOVUxMLAo+PiArCQlVU19GTF9JR05PUkVfVUFTIHwgVVNfRkxfTk9fV1BfREVURUNUKSwKPj4g Kwo+PiAgLyoKPj4gICAqIE5pY2sgQm93bGVyIDxuYm93bGVyQGVsbGlwdGljdGVjaC5jb20+Cj4+ ICAgKiBTQ1NJIHN0YWNrIHNwYW1zIChvdGhlcndpc2UgaGFybWxlc3MpIGVycm9yIG1lc3NhZ2Vz Lgo+PgotLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVu c3Vic2NyaWJlIGxpbnV4LXVzYiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9t b0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2Vy bmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCg==