From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E42B9C433DF for ; Tue, 2 Jun 2020 12:22:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B607A2053B for ; Tue, 2 Jun 2020 12:22:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=xs4all.nl header.i=@xs4all.nl header.b="mnj2X7Bt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728071AbgFBMW1 (ORCPT ); Tue, 2 Jun 2020 08:22:27 -0400 Received: from lb1-smtp-cloud8.xs4all.net ([194.109.24.21]:45571 "EHLO lb1-smtp-cloud8.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728091AbgFBMV2 (ORCPT ); Tue, 2 Jun 2020 08:21:28 -0400 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud8.xs4all.net with ESMTPA id g5uyjjRB3nv5ng5v2jpLOD; Tue, 02 Jun 2020 14:21:26 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s1; t=1591100486; bh=wnxhpBOR8cxLlCxEru5iXAFOeqCtZF0eI6TnTRpTQ4k=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=mnj2X7BtqgiwxsqKNO/Gme6ym8NfylrxRhcToLZ2Jvv3pXnELWguDd0MQ9SrPJeic vBE6fp1/oDqTDT7zfU1aJIr6L05uNZZsm9ctGubcWavmUJSJoVeCm/BfHyfUkQKDfG M6UOwKF68yUJWQ1KuAyMkME94sS4Mta/H0wBl4FwJPDnK0H2oY7K6ertG+WQDjqRvX r+SrtwlqUBAl/omOC0/PeSNBQebgliirOc9ujm2zrJtrdRXA/SEP5ril8AAEPGKoCZ udHUGJm/1/hjH8ahdoBAn0JXxrFwvZolOBk+KY6KtHLWruzIkBiLCV1pIfOyplId4J EZRKDh9MFG0Bw== Subject: Re: [PATCH v6 03/14] videobuf2: handle V4L2 buffer cache flags To: Sergey Senozhatsky Cc: Hans Verkuil , Mauro Carvalho Chehab , Tomasz Figa , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky References: <20200514160153.3646-1-sergey.senozhatsky@gmail.com> <20200514160153.3646-4-sergey.senozhatsky@gmail.com> <20200602101834.GA617@jagdpanzerIV.localdomain> <9ec2618b-0cce-b00e-08cf-b579d9aa1d5d@xs4all.nl> <20200602121049.GB617@jagdpanzerIV.localdomain> From: Hans Verkuil Message-ID: <9c6a347e-1cbf-3486-896a-124375fd225c@xs4all.nl> Date: Tue, 2 Jun 2020 14:21:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200602121049.GB617@jagdpanzerIV.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfB8xLrDohS5YChC2UdUEKUAgITcrA2xd5BVFjYQiOblLsFTmwikPFUXRvD8jTyG5ep3cDCjG/Sv7pz4guYWvnkNJzSSsVCsnsguovEkVK1jP6L7uNMQP b+dT3G6UJ8Ihk2lGIa6OeA727A4s97n5qF+bN9c2DrNvROnxRG8sOkO/wZxl2Jk8Ajtn+Er1SyiVHVNzbXyLJKPunFQ9g5psaAP2AjWAR63W6n+Lw5H9Cnnt s2wo1Uc2dfybHIUk6O7jw/xoCMctsfNNeJtz+DLSOkhwBLu7a72V1Ay2P9FoHi1bCOFPD7oaOZIVuub73834fNhQ1QuMTB17gnYIuWzo7AG/fDXO8XZMWiAw C2ZpRGCs4QpOBWib4oQzgf7osEyUNSfhT1MTDEUCpVU9D1XcdFI= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/06/2020 14:10, Sergey Senozhatsky wrote: > On (20/06/02 12:27), Hans Verkuil wrote: > [..] >>> Sorry, Hans, do you suggest to have something like this: >>> >>> if (q->memory == VB2_MEMORY_DMABUF) { >>> vb->need_cache_sync_on_finish = 0; >>> vb->need_cache_sync_on_prepare = 0; >>> b->flags &= ~V4L2_BUF_FLAG_NO_CACHE_INVALIDATE; >>> b->flags &= ~V4L2_BUF_FLAG_NO_CACHE_CLEAN; >>> return; >>> } >>> >>> I didn't clear the ->flags there because we clear the vb flush/sync >>> flags: ->need_cache_sync_on_finish/prepare are zeros for DMABUF memory >>> type. Which is equivalent to passing V4L2_BUF_FLAG_NO_CACHE_INVALIDATE >>> V4L2_BUF_FLAG_NO_CACHE_CLEAN. IOW we would clearing both "vb's do cache >>> sync" and request's "do not cache sync". >> >> Ah, yes. In that case the v4l-utils patch is likely wrong. >> Can you take a look at that patch? > > Hans, are we talking about "v4l2-utils: test cache_hints for MMAP queues" > patch? I can take a look, yes. Yes, that's the one. Hans