From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1f1YzP-0005nj-Lw for mharc-grub-devel@gnu.org; Thu, 29 Mar 2018 10:57:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f1YzM-0005lO-VA for grub-devel@gnu.org; Thu, 29 Mar 2018 10:57:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f1YzI-0002p8-5P for grub-devel@gnu.org; Thu, 29 Mar 2018 10:57:17 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:45886) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f1YzH-0002nl-VI for grub-devel@gnu.org; Thu, 29 Mar 2018 10:57:12 -0400 Received: by mail-wr0-f196.google.com with SMTP id u11so5663426wri.12 for ; Thu, 29 Mar 2018 07:57:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9mQSgmZcOb3rsbPpLWz/iPpOw74vbZ8kxSO76WMANYs=; b=BxtjQ3xUf8txOXAjjqi9NoNvqSpxpwQHifgEcc/5FdaswKRDYLyHduxpEJ/9mEA8RH k0Ccl1bAjDaCaJ3z279SAanmwDou8yil6y33cM+bMS8zvQ5vY8pVIbTWkbpGmTsXnpXa UCKGenkRYmIRWVDgJBdXPFmzppualDnNtaEpw2zWuqXmLJ1ImI+OtMYgIAiu0yLt8QTr gRWDqiorQrQ7qlVUu6Wj/YbZIZHO/CapaFbl3pLEH2W7L8y32VZZ8yt5yaLLTxYZfBsO XjIjf07Ag3YAI5VKZboK5ur9CQpF1SIcBp+R3cARCjdfPbROFUVQpznjgGLtsPwgJZ02 ytdg== X-Gm-Message-State: AElRT7GGXESnQI6mfWEMXPs/Wig5yfoNPr4GwkXJOu4tfwroLnDfhq2e 5qX1EO2OmCKO/4omKmB8slrzJw== X-Google-Smtp-Source: AIpwx49KXRWjJnCq8gwE7VzW0ABclP6kxpCGmg2UcNcNLQ5aogYme2Ks8kSDD7UdDuUymAAUTncXyA== X-Received: by 10.223.184.68 with SMTP id u4mr6550828wrf.154.1522335430288; Thu, 29 Mar 2018 07:57:10 -0700 (PDT) Received: from shalem.localdomain (546A5441.cm-12-3b.dynamic.ziggo.nl. [84.106.84.65]) by smtp.gmail.com with ESMTPSA id 67sm5420424wra.9.2018.03.29.07.57.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Mar 2018 07:57:09 -0700 (PDT) Subject: Re: [PATCH 1/4] Add new "version" command To: Olaf Hering , The development of GNU GRUB Cc: Daniel Kiper References: <20180328145028.21555-1-hdegoede@redhat.com> <20180328145028.21555-2-hdegoede@redhat.com> <20180329075302.GB28579@aepfle.de> From: Hans de Goede Message-ID: <9c6f5546-9513-8e77-403f-1e306398c8bc@redhat.com> Date: Thu, 29 Mar 2018 16:57:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180329075302.GB28579@aepfle.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.128.196 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 14:57:17 -0000 Hi, On 29-03-18 09:53, Olaf Hering wrote: > On Wed, Mar 28, Hans de Goede wrote: > >> + grub_printf ("%s, build %s %s\n", PACKAGE_STRING, __DATE__, __TIME__); > > NACK. > > Debian sells something what they call "reproducible build". Check their > website why usage of __DATE__ and __TIME__ is a bad thing. > SUSE does not want to republish an otherwise unchanged grub2 package > just because there was a need to rebuild the package. Good point, lets drop this patch then, as without the date I don't think there is much value in it and I don't feel like spending time on this to come up with another solution. Regards, Hans