All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <gmazyland@gmail.com>
To: Mike Snitzer <snitzer@redhat.com>, Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [dm-devel] use regular gendisk registration in device mapper
Date: Tue, 27 Jul 2021 22:38:16 +0200	[thread overview]
Message-ID: <9c719e1d-f8da-f1f3-57a9-3802aa1312d4@gmail.com> (raw)
In-Reply-To: <YQAxyjrGJpl7UkNG@redhat.com>

On 27/07/2021 18:18, Mike Snitzer wrote:
> On Tue, Jul 27 2021 at 12:02P -0400,
> Christoph Hellwig <hch@lst.de> wrote:
> 
>> On Tue, Jul 27, 2021 at 11:58:46AM -0400, Mike Snitzer wrote:
>>>> This did not make a different to my testing
>>>> using dmsetup and the lvm2 tools.
>>>
>>> I'll try these changes running through the lvm2 testsuite.
>>
>> Btw, is ther documentation on how to run it somewhere?  I noticed
>> tests, old-tests and unit-tests directories, but no obvious way
>> to run them.
> 
> I haven't tracked how it has changed in a while, but I always run:
> make check_local
> 
> (but to do that you first need to ./configure how your distro does
> it... so that all targets are enabled, etc. Then: make).
> 
> Will revisit this shortly and let you know if my process needed to
> change at all due to lvm2 changes.

BTW it would be also nice to run cryptsetup testsuite as root - we do a lot
of DM operations there (and we depend on sysfs on some places).

You can just run configure, make and then make check.

Thanks,
Milan

WARNING: multiple messages have this Message-ID (diff)
From: Milan Broz <gmazyland@gmail.com>
To: Mike Snitzer <snitzer@redhat.com>, Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [dm-devel] use regular gendisk registration in device mapper
Date: Tue, 27 Jul 2021 22:38:16 +0200	[thread overview]
Message-ID: <9c719e1d-f8da-f1f3-57a9-3802aa1312d4@gmail.com> (raw)
In-Reply-To: <YQAxyjrGJpl7UkNG@redhat.com>

On 27/07/2021 18:18, Mike Snitzer wrote:
> On Tue, Jul 27 2021 at 12:02P -0400,
> Christoph Hellwig <hch@lst.de> wrote:
> 
>> On Tue, Jul 27, 2021 at 11:58:46AM -0400, Mike Snitzer wrote:
>>>> This did not make a different to my testing
>>>> using dmsetup and the lvm2 tools.
>>>
>>> I'll try these changes running through the lvm2 testsuite.
>>
>> Btw, is ther documentation on how to run it somewhere?  I noticed
>> tests, old-tests and unit-tests directories, but no obvious way
>> to run them.
> 
> I haven't tracked how it has changed in a while, but I always run:
> make check_local
> 
> (but to do that you first need to ./configure how your distro does
> it... so that all targets are enabled, etc. Then: make).
> 
> Will revisit this shortly and let you know if my process needed to
> change at all due to lvm2 changes.

BTW it would be also nice to run cryptsetup testsuite as root - we do a lot
of DM operations there (and we depend on sysfs on some places).

You can just run configure, make and then make check.

Thanks,
Milan

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


  reply	other threads:[~2021-07-27 20:38 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-25  5:54 use regular gendisk registration in device mapper Christoph Hellwig
2021-07-25  5:54 ` [dm-devel] " Christoph Hellwig
2021-07-25  5:54 ` [PATCH 1/8] block: make the block holder code optional Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-29 16:25   ` Mike Snitzer
2021-07-29 16:25     ` [dm-devel] " Mike Snitzer
2021-07-25  5:54 ` [PATCH 2/8] block: remove the extra kobject reference in bd_link_disk_holder Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-29 16:27   ` Mike Snitzer
2021-07-29 16:27     ` [dm-devel] " Mike Snitzer
2021-07-25  5:54 ` [PATCH 3/8] block: look up holders by bdev Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-25  5:54 ` [PATCH 4/8] block: support delayed holder registration Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-27 16:06   ` Mike Snitzer
2021-07-27 16:06     ` [dm-devel] " Mike Snitzer
2021-07-28  6:54     ` Christoph Hellwig
2021-07-28  6:54       ` [dm-devel] " Christoph Hellwig
2021-07-29 16:32   ` Mike Snitzer
2021-07-29 16:32     ` [dm-devel] " Mike Snitzer
2021-07-25  5:54 ` [PATCH 5/8] dm: cleanup cleanup_mapped_device Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-29 16:33   ` Mike Snitzer
2021-07-29 16:33     ` [dm-devel] " Mike Snitzer
2021-07-25  5:54 ` [PATCH 6/8] dm: move setting md->type into dm_setup_md_queue Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-29 16:34   ` Mike Snitzer
2021-07-29 16:34     ` [dm-devel] " Mike Snitzer
2021-07-25  5:54 ` [PATCH 7/8] dm: delay registering the gendisk Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-29 16:36   ` Mike Snitzer
2021-07-29 16:36     ` [dm-devel] " Mike Snitzer
2021-07-25  5:54 ` [PATCH 8/8] block: remove support for delayed queue registrations Christoph Hellwig
2021-07-25  5:54   ` [dm-devel] " Christoph Hellwig
2021-07-29 16:37   ` Mike Snitzer
2021-07-29 16:37     ` [dm-devel] " Mike Snitzer
2021-07-27 15:58 ` use regular gendisk registration in device mapper Mike Snitzer
2021-07-27 15:58   ` [dm-devel] " Mike Snitzer
2021-07-27 16:02   ` Christoph Hellwig
2021-07-27 16:02     ` [dm-devel] " Christoph Hellwig
2021-07-27 16:18     ` Mike Snitzer
2021-07-27 16:18       ` [dm-devel] " Mike Snitzer
2021-07-27 20:38       ` Milan Broz [this message]
2021-07-27 20:38         ` Milan Broz
2021-07-28  7:06         ` Christoph Hellwig
2021-07-28  7:06           ` Christoph Hellwig
2021-07-28  8:37           ` Milan Broz
2021-07-28  8:37             ` Milan Broz
2021-07-28 11:24             ` Christoph Hellwig
2021-07-28 11:24               ` Christoph Hellwig
2021-07-29 15:01               ` Milan Broz
2021-07-29 15:01                 ` Milan Broz
2021-07-28 16:17         ` Mike Snitzer
2021-07-28 16:17           ` [dm-devel] " Mike Snitzer
2021-07-29  7:50           ` Milan Broz
2021-07-29  7:50             ` [dm-devel] " Milan Broz
2021-07-27 22:52       ` Mike Snitzer
2021-07-27 22:52         ` [dm-devel] " Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c719e1d-f8da-f1f3-57a9-3802aa1312d4@gmail.com \
    --to=gmazyland@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.