From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68FAEC04A68 for ; Wed, 27 Jul 2022 13:15:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232853AbiG0NPh (ORCPT ); Wed, 27 Jul 2022 09:15:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231228AbiG0NPg (ORCPT ); Wed, 27 Jul 2022 09:15:36 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AEFD026AF6 for ; Wed, 27 Jul 2022 06:15:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658927731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+U2SMjrAZx6a3vXMCUjxlR0K/3DAi/IYsuGYocVm8PM=; b=BrtCn2yqmPK2MB4wJdxYVqz4Zzrf9V4ppgdbwt3quJ0HCwxLylHq4Sm36DZOVO2g4K+zce wnbsGDFOk65K81sJApK4UpBxSXk8tCmYisryrbRza/RVhM+pENy3+k8d3l0hHVtQEokUvq JrAh82wYsUVo8cx+FB1fO0Ret3Tf7Fw= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-178-kvPi4HlROpefEaDvqPQBWQ-1; Wed, 27 Jul 2022 09:15:30 -0400 X-MC-Unique: kvPi4HlROpefEaDvqPQBWQ-1 Received: by mail-ej1-f72.google.com with SMTP id nc23-20020a1709071c1700b0072b94109144so5080650ejc.2 for ; Wed, 27 Jul 2022 06:15:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+U2SMjrAZx6a3vXMCUjxlR0K/3DAi/IYsuGYocVm8PM=; b=ArfjDORnXDcNeZNqEh3lSd5u4++dxrJ1uT8WDyTQMz1EMXrPGWin1R8LK0MsmcXoY4 ECdvtOGZ9Jf67o6MlSdqxQhGLaK5GOju7hzgAuBg++dOBmR8xhoDHP0slLk2d5mnlzK4 aFZ50lqVl5mtDbv1ImeLuoOOa4gzhVI/Am5IapmLjDurCpdWWR3yyPjd+1O9Gymlseux 88RHtgNcWl6lflvMQOi6EEWMjKdM10Bm1OCkyZdcb/XjTavydkpGxv3UY8jLCn3RuWMj VYNju/+wpCcszLwMK+7vktDknMMWCWTX1rnQdd5mSRqZP4DydP0Jk5KMTzDOKxhoQ356 5g/w== X-Gm-Message-State: AJIora/e/RQKdNHu1mGlloC77j7ed1pi70T1SKKtqu22jsUPI/T1yzDX s/Mu5Bg6Mo4fDiVBW4MtLB7Sgf4vWiDEMe4KuoZQU+Rx6hGKXY4R4BsDXAKNEn6wDdLavairND+ fYzL58a316BB/+lHmZ2vpgA== X-Received: by 2002:aa7:c599:0:b0:43b:b7c8:36ff with SMTP id g25-20020aa7c599000000b0043bb7c836ffmr23067787edq.110.1658927729163; Wed, 27 Jul 2022 06:15:29 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uQBCa2+G+jTdUedn1Ozel7kHw3Vtt+HOUWRygOCweoJHcBFw76XKlCNA93hHF3POGePgt8YQ== X-Received: by 2002:aa7:c599:0:b0:43b:b7c8:36ff with SMTP id g25-20020aa7c599000000b0043bb7c836ffmr23067763edq.110.1658927729007; Wed, 27 Jul 2022 06:15:29 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id u17-20020a1709061db100b0072aeda86ac3sm7689731ejh.149.2022.07.27.06.15.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Jul 2022 06:15:28 -0700 (PDT) Message-ID: <9c7c86da-9114-8d68-38f0-ec8284b79af0@redhat.com> Date: Wed, 27 Jul 2022 15:15:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/2] gpiolib: acpi: Add a quirk for Asus UM325UAZ Content-Language: en-US To: Mario Limonciello , Mika Westerberg , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski Cc: Pavel Krc , linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220719142142.247-1-mario.limonciello@amd.com> <20220719142142.247-2-mario.limonciello@amd.com> From: Hans de Goede In-Reply-To: <20220719142142.247-2-mario.limonciello@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, On 7/19/22 16:21, Mario Limonciello wrote: > Asus UM325UAZ has GPIO 18 programmed as both an interrupt and a wake > source, but confirmed with internal team on this design this pin is > floating and shouldn't have been programmed. This causes lots of > spurious IRQs on the system and horrendous battery life. > > Add a quirk to ignore attempts to program this pin on this system. > > Reported-and-tested-by: Pavel Krc > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216208 > Signed-off-by: Mario Limonciello Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/gpio/gpiolib-acpi.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c > index 375942d92d6f..2149713ea8f1 100644 > --- a/drivers/gpio/gpiolib-acpi.c > +++ b/drivers/gpio/gpiolib-acpi.c > @@ -1586,6 +1586,20 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = { > .ignore_wake = "INT33FF:01@0", > }, > }, > + { > + /* > + * Interrupt storm caused from edge triggered floating pin > + * Found in BIOS UX325UAZ.300 > + * https://bugzilla.kernel.org/show_bug.cgi?id=216208 > + */ > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > + DMI_MATCH(DMI_PRODUCT_NAME, "ZenBook UX325UAZ_UM325UAZ"), > + }, > + .driver_data = &(struct acpi_gpiolib_dmi_quirk) { > + .ignore_interrupt = "AMDI0030:00@18", > + }, > + }, > {} /* Terminating entry */ > }; >