From: Johannes Berg <johannes@sipsolutions.net>
To: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>,
Arend van Spriel <arend.vanspriel@broadcom.com>
Subject: Re: [RFC PATCH] mac80211/cfg80211: update bss channel on channel switch
Date: Mon, 25 Mar 2019 17:18:10 +0100 [thread overview]
Message-ID: <9c7d400791aee24497f33fd1695770a88bb82fc8.camel@sipsolutions.net> (raw)
In-Reply-To: <20190325154443.elzp5n6nfngtg5vk@bars>
On Mon, 2019-03-25 at 15:44 +0000, Sergey Matyukevich wrote:
> > >
> > I worry slightly about locking too, since there's no protection on the
> > wdev->current_bss pointer here.
>
> Ok, I will add WARN_ON. As for locking, this function is supposed to be
> called with wdev->mtx held, see ASSERT_WDEV_LOCK. Do you think this may
> not be enough ?
Oops, no, that's definitely sufficient. I missed it.
> I need to check mwifiex more carefully, but other cfg80211_ch_switch_notify
> users (mac80211, ath6kl, qtnfmac) seem to do that locking properly.
Well I guess they'd assert and then do something unsafe, so wouldn't
worry about it.
johannes
prev parent reply other threads:[~2019-03-25 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 15:19 [RFC PATCH] mac80211/cfg80211: update bss channel on channel switch Sergey Matyukevich
2019-03-23 12:32 ` Johannes Berg
2019-03-25 15:44 ` Sergey Matyukevich
2019-03-25 16:18 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c7d400791aee24497f33fd1695770a88bb82fc8.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=igor.mitsyanko.os@quantenna.com \
--cc=linux-wireless@vger.kernel.org \
--cc=sergey.matyukevich.os@quantenna.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.