All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yonghong Song <yhs@fb.com>
To: Andrii Nakryiko <andriin@fb.com>,
	Song Liu <songliubraving@fb.com>, Alexei Starovoitov <ast@fb.com>,
	Martin Lau <kafai@fb.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"daniel@iogearbox.net" <daniel@iogearbox.net>,
	"andrii.nakryiko@gmail.com" <andrii.nakryiko@gmail.com>
Subject: Re: [PATCH bpf-next 2/2] btf: expose API to work with raw btf data
Date: Tue, 5 Feb 2019 22:01:47 +0000	[thread overview]
Message-ID: <9c81e3e3-069c-3525-19b6-fd58b7be976c@fb.com> (raw)
In-Reply-To: <20190205194856.967463-3-andriin@fb.com>



On 2/5/19 11:48 AM, Andrii Nakryiko wrote:
> This patch exposes two new APIs btf__get_raw_data_size() and
> btf__get_raw_data() that allows to get a copy of raw BTF data out of
> struct btf. This is useful for external programs that need to manipulate
> raw data, e.g., pahole using btf__dedup() to deduplicate BTF type info
> and then writing it back to file.
> 
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>
> Acked-by: Song Liu <songliubraving@fb.com>

Acked-by: Yonghong Song <yhs@fb.com>

> ---
>   tools/lib/bpf/btf.c      | 10 ++++++++++
>   tools/lib/bpf/btf.h      |  2 ++
>   tools/lib/bpf/libbpf.map |  2 ++
>   3 files changed, 14 insertions(+)
> 
> diff --git a/tools/lib/bpf/btf.c b/tools/lib/bpf/btf.c
> index 065d51fa63e5..6491d440c9a7 100644
> --- a/tools/lib/bpf/btf.c
> +++ b/tools/lib/bpf/btf.c
> @@ -437,6 +437,16 @@ int btf__fd(const struct btf *btf)
>   	return btf->fd;
>   }
>   
> +__u32 btf__get_raw_data_size(const struct btf *btf)
> +{
> +	return btf->data_size;
> +}
> +
> +void btf__get_raw_data(const struct btf *btf, char *data)
> +{
> +	memcpy(data, btf->data, btf->data_size);
> +}
> +
>   void btf__get_strings(const struct btf *btf, const char **strings,
>   		      __u32 *str_len)
>   {
> diff --git a/tools/lib/bpf/btf.h b/tools/lib/bpf/btf.h
> index e8410887f93a..d46f680b9416 100644
> --- a/tools/lib/bpf/btf.h
> +++ b/tools/lib/bpf/btf.h
> @@ -66,6 +66,8 @@ LIBBPF_API const struct btf_type *btf__type_by_id(const struct btf *btf,
>   LIBBPF_API __s64 btf__resolve_size(const struct btf *btf, __u32 type_id);
>   LIBBPF_API int btf__resolve_type(const struct btf *btf, __u32 type_id);
>   LIBBPF_API int btf__fd(const struct btf *btf);
> +LIBBPF_API __u32 btf__get_raw_data_size(const struct btf *btf);
> +LIBBPF_API void btf__get_raw_data(const struct btf *btf, char *data);
>   LIBBPF_API void btf__get_strings(const struct btf *btf, const char **strings,
>   				 __u32 *str_len);
>   LIBBPF_API const char *btf__name_by_offset(const struct btf *btf, __u32 offset);
> diff --git a/tools/lib/bpf/libbpf.map b/tools/lib/bpf/libbpf.map
> index ffa1fe044f6a..873a26cd714d 100644
> --- a/tools/lib/bpf/libbpf.map
> +++ b/tools/lib/bpf/libbpf.map
> @@ -137,6 +137,8 @@ LIBBPF_0.0.2 {
>   		btf__load;
>   		btf__get_map_kv_tids;
>   		btf__get_nr_types;
> +		btf__get_raw_data;
> +		btf__get_raw_data_size;
>   		btf__get_strings;
>   		btf_ext__free;
>   		btf_ext__func_info_rec_size;
> 

      reply	other threads:[~2019-02-05 22:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-05 19:48 [PATCH bpf-next 0/2] tools/btf: extends libbpf APIs to work with btf w/o kernel Andrii Nakryiko
2019-02-05 19:48 ` [PATCH bpf-next 1/2] btf: separate btf creation and loading Andrii Nakryiko
2019-02-05 21:25   ` Yonghong Song
2019-02-05 22:34     ` Andrii Nakryiko
2019-02-05 19:48 ` [PATCH bpf-next 2/2] btf: expose API to work with raw btf data Andrii Nakryiko
2019-02-05 22:01   ` Yonghong Song [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c81e3e3-069c-3525-19b6-fd58b7be976c@fb.com \
    --to=yhs@fb.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@fb.com \
    --cc=daniel@iogearbox.net \
    --cc=kafai@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=songliubraving@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.