From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lHcou-0006uo-Og for mharc-grub-devel@gnu.org; Wed, 03 Mar 2021 20:30:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHcot-0006rL-A0 for grub-devel@gnu.org; Wed, 03 Mar 2021 20:30:27 -0500 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:39906) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHcol-0001r6-E5 for grub-devel@gnu.org; Wed, 03 Mar 2021 20:30:27 -0500 Received: by mail-pl1-x62a.google.com with SMTP id j6so1577509plx.6 for ; Wed, 03 Mar 2021 17:30:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=67tELQmYXjII3zxmdvNOXPe3+GVxAFqpIsZc482qPDA=; b=D9BdQmeVNM3c5toKt4wiqL96kAnQt7K3rhTeYNkRdQv10/jfPf0UIg+kLSjZYS1cRA BSYUb8hgh4UW/RuyuzLIlSYvKjKcmNJnRS5UEn0VHS4Gf2azSWC2oYxB4QdLEg+s4Rji 4a33agR+x6fc7Af0vDi5pf+k2xp2DRD2D1g64d9ev/UwPitzmXlcDbrugk36icNOINIH QbCapysfuktxzF78PO13DJjA1ragdUbMXd99NAaoOaQGm4U6drNKcEdUw+HXjeGaR+3U Vf1OH+VMsLY2VvfvknR2TbM0fthk+oZlR+fy/RchSMjU2eej3CpkonP4xZTLpRT8bh1q Fg2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=67tELQmYXjII3zxmdvNOXPe3+GVxAFqpIsZc482qPDA=; b=nN4DNcrynXviLqDmc3RNHAXCiK5rVVU7oLOygVbKBFkxHvSyJ1fcQOl+jI1Tq3WZuP ql8nOO8EtHLN9TxUZT3MCx0sMEUTkjuhPW4/bokHS0H+CCux28Z8LjRLYloyE8lVHAo3 ExMC/TMEgtxgmO1gupC9b9Qr6bsyn24Gu8ZRbhzsQFAREeqmOzAOcW5hyIFqj1AebzwW f52BeLkXzmetdph9QWQgwn7Ol+QzFtm+naJAaOlRxx3ImZ4yudIiSYA5pvr9anpzFzYg SV1swwv5W4ebqlfc3Aj4aXZ4rOzKEhYkP064Ob7FLefYspY3nCL20KcqLTKONtlv6J4J ECYw== X-Gm-Message-State: AOAM532Bnm2tjbVYVknqSwG6t2ZKLzM7xTI9Y4cuRhFSjyCMp1gj1SkR vbBfNNpMG9F3jg25O92ziIzd6pBEWuzzOA== X-Google-Smtp-Source: ABdhPJw91wuDgvdiuRFXHXQTR8yH2M+ZFzhIV1G5Nr8gAk4LJ/1HWTpSPvmo/70Tq7i2wLdcRlsG3A== X-Received: by 2002:a17:902:d64d:b029:de:8aaa:d6ba with SMTP id y13-20020a170902d64db02900de8aaad6bamr1767135plh.0.1614821417810; Wed, 03 Mar 2021 17:30:17 -0800 (PST) Received: from localhost.localdomain ([2605:a601:aac5:3700:a76b:9596:1e1a:28ee]) by smtp.gmail.com with ESMTPSA id c193sm318190pfc.180.2021.03.03.17.30.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 17:30:17 -0800 (PST) From: Glenn Washburn To: grub-devel@gnu.org, Daniel Kiper Cc: Glenn Washburn Subject: [PATCH v5 13/13] error: Do compile-time format string checking on grub_error Date: Wed, 3 Mar 2021 19:29:18 -0600 Message-Id: <9cb1964f14072f149aeb172c04c1c616d21d71ef.1614820843.git.development@efficientek.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=development@efficientek.com; helo=mail-pl1-x62a.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Mar 2021 01:30:27 -0000 This should help prevent format string errors and thus improve the quality of error reporting. Signed-off-by: Glenn Washburn --- include/grub/err.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/grub/err.h b/include/grub/err.h index 24ba9f5f5..b08d5d0de 100644 --- a/include/grub/err.h +++ b/include/grub/err.h @@ -85,7 +85,8 @@ struct grub_error_saved extern grub_err_t EXPORT_VAR(grub_errno); extern char EXPORT_VAR(grub_errmsg)[GRUB_MAX_ERRMSG]; -grub_err_t EXPORT_FUNC(grub_error) (grub_err_t n, const char *fmt, ...); +grub_err_t EXPORT_FUNC(grub_error) (grub_err_t n, const char *fmt, ...) + __attribute__ ((format (GNU_PRINTF, 2, 3))); void EXPORT_FUNC(grub_fatal) (const char *fmt, ...) __attribute__ ((noreturn)); void EXPORT_FUNC(grub_error_push) (void); int EXPORT_FUNC(grub_error_pop) (void); -- 2.27.0