From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE707C43460 for ; Wed, 31 Mar 2021 21:37:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A02F61075 for ; Wed, 31 Mar 2021 21:37:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232511AbhCaVgq (ORCPT ); Wed, 31 Mar 2021 17:36:46 -0400 Received: from mga06.intel.com ([134.134.136.31]:39282 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229812AbhCaVgR (ORCPT ); Wed, 31 Mar 2021 17:36:17 -0400 IronPort-SDR: RhnTJeUHR6djQZQaYxoLtzS66zHDWMqAsutxspldzJOsYH5vvcCyQhIITBPK7BPdPl4Fz0CbfU WTlMTJ8r3TSw== X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="253432328" X-IronPort-AV: E=Sophos;i="5.81,295,1610438400"; d="scan'208";a="253432328" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2021 14:36:17 -0700 IronPort-SDR: PuB3JKqewoBHbFhYMerf7tLLZ/xNJUhXA/KrG4R7zioEodkvLZg/l1kTu3TTO5XZMt6EDnAsGb 0kPKfLJM8KSA== X-IronPort-AV: E=Sophos;i="5.81,295,1610438400"; d="scan'208";a="377432689" Received: from rchatre-mobl3.amr.corp.intel.com (HELO [10.212.177.63]) ([10.212.177.63]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2021 14:36:16 -0700 Subject: Re: [PATCH v2 02/24] x86/resctrl: Split struct rdt_domain To: James Morse , x86@kernel.org, linux-kernel@vger.kernel.org Cc: Fenghua Yu , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , Babu Moger , shameerali.kolothum.thodi@huawei.com, Jamie Iles , D Scott Phillips OS References: <20210312175849.8327-1-james.morse@arm.com> <20210312175849.8327-3-james.morse@arm.com> From: Reinette Chatre Message-ID: <9cb3f9c9-8295-6e40-9f98-1944b9b3c59b@intel.com> Date: Wed, 31 Mar 2021 14:36:15 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210312175849.8327-3-james.morse@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi James, On 3/12/2021 9:58 AM, James Morse wrote: > resctrl is the defacto Linux ABI for SoC resource partitioning features. > To support it on another architecture, it needs to be abstracted from > the features provided by Intel RDT and AMD PQoS, and moved to /fs/. > > Split struct rdt_domain up too. Move everything that that is particular s/that that/that/ > to resctrl into a new header file. resctrl code paths touching a 'hw' > struct indicates where an abstraction is needed. Similar to previous patch it would help to explain how this split was chosen. For example, why are the CPUs to which a resource is associated not considered a hardware property? Thank you Reinette