From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: fam@euphon.net, berrange@redhat.com,
"David Hildenbrand" <david@redhat.com>,
f4bug@amsat.org, "Peter Xu" <peterx@redhat.com>,
stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com,
"Pavel Dovgalyuk" <pavel.dovgalyuk@ispras.ru>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
aurelien@aurel32.net
Subject: Re: [PATCH v3 2/8] accel/tcg: suppress IRQ check for special TBs
Date: Mon, 29 Nov 2021 15:34:51 +0100 [thread overview]
Message-ID: <9cb5c50d-114d-d515-c60f-17d3ccfe66ab@linaro.org> (raw)
In-Reply-To: <20211129140932.4115115-3-alex.bennee@linaro.org>
On 11/29/21 3:09 PM, Alex Bennée wrote:
> When we set cpu->cflags_next_tb it is because we want to carefully
> control the execution of the next TB. Currently there is a race that
> causes the second stage of watchpoint handling to get ignored if an
> IRQ is processed before we finish executing the instruction that
> triggers the watchpoint. Use the new CF_NOIRQ facility to avoid the
> race.
>
> We also suppress IRQs when handling precise self modifying code to
> avoid unnecessary bouncing.
>
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> Cc: Pavel Dovgalyuk<pavel.dovgalyuk@ispras.ru>
> Fixes:https://gitlab.com/qemu-project/qemu/-/issues/245
>
> ---
> v2
> - split the CF_NOIRQ implementation
> - only apply CF_NOIRQ for watchpoints/SMC handling
> - minor reword of commit
> v3
> - add additional two cases of | CF_NOIRQ
> ---
> accel/tcg/cpu-exec.c | 9 +++++++++
> accel/tcg/translate-all.c | 4 ++--
> softmmu/physmem.c | 4 ++--
> 3 files changed, 13 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-11-29 14:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 14:09 [PATCH for 6.2 v3 0/8] more tcg, plugin, test and build fixes (pre-PR) Alex Bennée
2021-11-29 14:09 ` [PATCH v3 1/8] accel/tcg: introduce CF_NOIRQ Alex Bennée
2021-11-29 14:09 ` [PATCH v3 2/8] accel/tcg: suppress IRQ check for special TBs Alex Bennée
2021-11-29 14:34 ` Richard Henderson [this message]
2021-11-29 14:09 ` [PATCH v3 3/8] tests/avocado: fix tcg_plugin mem access count test Alex Bennée
2021-11-29 14:09 ` [PATCH v3 4/8] plugins/meson.build: fix linker issue with weird paths Alex Bennée
2021-11-29 14:09 ` [PATCH v3 5/8] gdbstub: handle a potentially racing TaskState Alex Bennée
2021-11-29 14:09 ` [PATCH v3 6/8] MAINTAINERS: Remove me as a reviewer for the build and test/avocado Alex Bennée
2021-11-29 14:09 ` [PATCH v3 7/8] MAINTAINERS: Add section for Aarch64 GitLab custom runner Alex Bennée
2021-11-29 14:09 ` [PATCH v3 8/8] tests/plugin/syscall.c: fix compiler warnings Alex Bennée
2021-11-29 14:36 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cb5c50d-114d-d515-c60f-17d3ccfe66ab@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=david@redhat.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=pavel.dovgalyuk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.