From: Jason Wang <jasowang@redhat.com>
To: "Eugenio Pérez" <eperezma@redhat.com>, qemu-devel@nongnu.org
Cc: Parav Pandit <parav@mellanox.com>,
Zhu Lingshan <lingshan.zhu@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Harpreet Singh Anand <hanand@xilinx.com>,
Gautam Dawar <gdawar@xilinx.com>, Eli Cohen <eli@mellanox.com>,
Eric Blake <eblake@redhat.com>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
Cornelia Huck <cohuck@redhat.com>,
Stefano Garzarella <sgarzare@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>, Cindy Lu <lulu@redhat.com>,
Liuxiangdong <liuxiangdong5@huawei.com>
Subject: Re: [PATCH v4 4/7] vdpa: add NetClientState->start() callback
Date: Tue, 26 Jul 2022 10:52:57 +0800 [thread overview]
Message-ID: <9cbd4657-2c60-be8c-efce-7c2af47398a0@redhat.com> (raw)
In-Reply-To: <20220722111245.3403062-5-eperezma@redhat.com>
在 2022/7/22 19:12, Eugenio Pérez 写道:
> It allows per-net client operations right after device's successful
> start.
>
> Vhost-vdpa net will use it to add the CVQ buffers to restore the device
> status.
>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> ---
> include/net/net.h | 2 ++
> hw/net/vhost_net.c | 7 +++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/include/net/net.h b/include/net/net.h
> index 523136c7ac..ad9e80083a 100644
> --- a/include/net/net.h
> +++ b/include/net/net.h
> @@ -44,6 +44,7 @@ typedef struct NICConf {
>
> typedef void (NetPoll)(NetClientState *, bool enable);
> typedef bool (NetCanReceive)(NetClientState *);
> +typedef int (NetStart)(NetClientState *);
> typedef ssize_t (NetReceive)(NetClientState *, const uint8_t *, size_t);
> typedef ssize_t (NetReceiveIOV)(NetClientState *, const struct iovec *, int);
> typedef void (NetCleanup) (NetClientState *);
> @@ -71,6 +72,7 @@ typedef struct NetClientInfo {
> NetReceive *receive_raw;
> NetReceiveIOV *receive_iov;
> NetCanReceive *can_receive;
> + NetStart *start;
I think we probably need a better name here. (start should go with
DRIVER_OK or SET_VRING_ENABLE)
How about load or other (not a native speaker).
Thanks
> NetCleanup *cleanup;
> LinkStatusChanged *link_status_changed;
> QueryRxFilter *query_rx_filter;
> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> index ccac5b7a64..ddd9ee0441 100644
> --- a/hw/net/vhost_net.c
> +++ b/hw/net/vhost_net.c
> @@ -274,6 +274,13 @@ static int vhost_net_start_one(struct vhost_net *net,
> }
> }
> }
> +
> + if (net->nc->info->start) {
> + r = net->nc->info->start(net->nc);
> + if (r < 0) {
> + goto fail;
> + }
> + }
> return 0;
> fail:
> file.fd = -1;
next prev parent reply other threads:[~2022-07-26 2:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 11:12 [PATCH v4 0/7] NIC vhost-vdpa state restore via Shadow CVQ Eugenio Pérez
2022-07-22 11:12 ` [PATCH v4 1/7] vhost: stop transfer elem ownership in vhost_handle_guest_kick Eugenio Pérez
2022-07-22 11:12 ` [PATCH v4 2/7] vdpa: Extract vhost_vdpa_net_cvq_add from vhost_vdpa_net_handle_ctrl_avail Eugenio Pérez
2022-07-26 2:50 ` Jason Wang
2022-08-01 7:35 ` Eugenio Perez Martin
2022-07-22 11:12 ` [PATCH v4 3/7] vdpa: Make vhost_vdpa_net_cvq_map_elem accept any out sg Eugenio Pérez
2022-07-25 8:48 ` Jason Wang
2022-08-01 6:42 ` Eugenio Perez Martin
2022-07-22 11:12 ` [PATCH v4 4/7] vdpa: add NetClientState->start() callback Eugenio Pérez
2022-07-26 2:52 ` Jason Wang [this message]
2022-08-01 8:02 ` Eugenio Perez Martin
2022-07-22 11:12 ` [PATCH v4 5/7] vdpa: Reorder net_vhost_vdpa_info Eugenio Pérez
2022-07-22 11:12 ` [PATCH v4 6/7] vdpa: Add virtio-net mac address via CVQ at start Eugenio Pérez
2022-07-25 9:32 ` Jason Wang
2022-08-01 7:09 ` Eugenio Perez Martin
2022-08-02 17:37 ` Eugenio Perez Martin
2022-07-22 11:12 ` [PATCH v4 7/7] vdpa: Delete CVQ migration blocker Eugenio Pérez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cbd4657-2c60-be8c-efce-7c2af47398a0@redhat.com \
--to=jasowang@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=cohuck@redhat.com \
--cc=eblake@redhat.com \
--cc=eli@mellanox.com \
--cc=eperezma@redhat.com \
--cc=gdawar@xilinx.com \
--cc=hanand@xilinx.com \
--cc=lingshan.zhu@intel.com \
--cc=liuxiangdong5@huawei.com \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=parav@mellanox.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.