From: Alex Elder <elder@linaro.org>
To: Jiri Slaby <jslaby@suse.cz>, gregkh@linuxfoundation.org
Cc: Alex Elder <elder@kernel.org>,
linux-staging@lists.linux.dev, Johan Hovold <johan@kernel.org>,
linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org,
linux-serial@vger.kernel.org, David Lin <dtwlin@gmail.com>
Subject: Re: [greybus-dev] [PATCH 14/16] tty: drivers/staging/, stop using tty_flip_buffer_push
Date: Tue, 14 Sep 2021 08:19:33 -0500 [thread overview]
Message-ID: <9cd19a7d-797f-4951-c29a-c263f69a6631@linaro.org> (raw)
In-Reply-To: <20210914091415.17918-7-jslaby@suse.cz>
On 9/14/21 4:14 AM, Jiri Slaby wrote:
> Since commit a9c3f68f3cd8d (tty: Fix low_latency BUG) in 2014,
> tty_flip_buffer_push() is only a wrapper to tty_schedule_flip(). We are
> going to remove the former, so call the latter directly in
> drivers/staging/.
For "greybus/uart.c", looks good.
Reviewed-by: Alex Elder <elder@linaro.org>
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: David Lin <dtwlin@gmail.com>
> Cc: Johan Hovold <johan@kernel.org>
> Cc: Alex Elder <elder@kernel.org>
> Cc: linux-staging@lists.linux.dev
> Cc: greybus-dev@lists.linaro.org
> ---
> drivers/staging/fwserial/fwserial.c | 4 ++--
> drivers/staging/gdm724x/gdm_tty.c | 2 +-
> drivers/staging/greybus/uart.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c
> index e8fa7f53cd5e..b2d3f95edbc3 100644
> --- a/drivers/staging/fwserial/fwserial.c
> +++ b/drivers/staging/fwserial/fwserial.c
> @@ -518,7 +518,7 @@ static void fwtty_emit_breaks(struct work_struct *work)
> if (c < t)
> break;
> }
> - tty_flip_buffer_push(&port->port);
> + tty_schedule_flip(&port->port);
>
> if (port->mstatus & (UART_LSR_BI << 24))
> schedule_delayed_work(&port->emit_breaks, FREQ_BREAKS);
> @@ -565,7 +565,7 @@ static int fwtty_rx(struct fwtty_port *port, unsigned char *data, size_t len)
>
> c = tty_insert_flip_string_fixed_flag(&port->port, data, TTY_NORMAL, n);
> if (c > 0)
> - tty_flip_buffer_push(&port->port);
> + tty_schedule_flip(&port->port);
> n -= c;
>
> if (n) {
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index 04df6f9f5403..95a3b4e61fec 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -129,7 +129,7 @@ static int gdm_tty_recv_complete(void *data,
> if (data && len) {
> if (tty_buffer_request_room(&gdm->port, len) == len) {
> tty_insert_flip_string(&gdm->port, data, len);
> - tty_flip_buffer_push(&gdm->port);
> + tty_schedule_flip(&gdm->port);
> } else {
> return TO_HOST_BUFFER_REQUEST_FAIL;
> }
> diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
> index e6d860a9678e..2bdc2401b652 100644
> --- a/drivers/staging/greybus/uart.c
> +++ b/drivers/staging/greybus/uart.c
> @@ -122,7 +122,7 @@ static int gb_uart_receive_data_handler(struct gb_operation *op)
> recv_data_size, count);
> }
> if (count)
> - tty_flip_buffer_push(port);
> + tty_schedule_flip(port);
> return 0;
> }
>
>
next prev parent reply other threads:[~2021-09-14 13:19 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 9:11 [PATCH 01/16] tty: unexport tty_ldisc_release Jiri Slaby
2021-09-14 9:11 ` [PATCH 02/16] tty: remove flags from struct tty_ldisc_ops Jiri Slaby
2021-09-14 9:11 ` [PATCH 03/16] tty: remove extern from functions in tty headers Jiri Slaby
2021-09-14 9:11 ` [PATCH 04/16] tty: make tty_ldisc_ops::hangup return void Jiri Slaby
2021-09-15 8:05 ` Marc Kleine-Budde
2021-09-15 11:48 ` Mark Brown
2021-09-21 3:59 ` Dmitry Torokhov
2021-09-14 9:11 ` [PATCH 05/16] tty: remove file from tty_mode_ioctl Jiri Slaby
2021-09-15 8:05 ` Marc Kleine-Budde
2021-09-14 9:11 ` [PATCH 06/16] tty: remove file from n_tty_ioctl_helper Jiri Slaby
2021-09-14 9:15 ` Krzysztof Kozlowski
2021-09-14 9:11 ` [PATCH 07/16] tty: remove file from tty_ldisc_ops::ioctl and compat_ioctl Jiri Slaby
2021-09-14 9:16 ` Krzysztof Kozlowski
2021-09-15 8:02 ` Marc Kleine-Budde
2021-09-21 4:00 ` Dmitry Torokhov
2021-09-21 10:52 ` Jiri Slaby
2021-09-21 11:36 ` Greg KH
2021-09-21 15:51 ` Jiri Slaby
2021-09-22 15:01 ` Greg KH
2021-09-14 9:14 ` [PATCH 08/16] tty: drivers/tty/serial/, stop using tty_flip_buffer_push Jiri Slaby
2021-09-14 9:14 ` [PATCH 09/16] tty: drivers/tty/, " Jiri Slaby
2021-09-14 16:06 ` David Sterba
2021-09-14 9:14 ` [PATCH 10/16] tty: drivers/usb/serial/, " Jiri Slaby
2021-09-14 9:14 ` [PATCH 11/16] tty: drivers/usb/, " Jiri Slaby
2021-09-14 9:14 ` [PATCH 12/16] tty: arch/, " Jiri Slaby
2021-09-15 8:10 ` Max Filippov
2021-09-15 8:10 ` Max Filippov
2021-09-14 9:14 ` [PATCH 13/16] tty: drivers/s390/char/, " Jiri Slaby
2021-09-14 9:14 ` [PATCH 14/16] tty: drivers/staging/, " Jiri Slaby
2021-09-14 13:19 ` Alex Elder [this message]
2021-09-14 9:14 ` [PATCH 15/16] tty: the rest, " Jiri Slaby
2021-09-14 11:58 ` Samuel Iglesias Gonsálvez
2021-09-14 9:14 ` [PATCH 16/16] tty: drop tty_flip_buffer_push Jiri Slaby
2021-09-16 10:03 ` Johan Hovold
2021-09-22 6:57 ` Jiri Slaby
2021-09-23 8:32 ` Johan Hovold
2021-11-18 7:54 ` Jiri Slaby
2021-11-18 8:10 ` Johan Hovold
2021-09-14 9:17 ` [PATCH 08/16] tty: drivers/tty/serial/, stop using tty_flip_buffer_push Krzysztof Kozlowski
2021-09-14 12:54 ` Uwe Kleine-König
2021-09-14 13:53 ` Richard Genoud
2021-09-15 17:00 ` Tobias Klauser
2021-09-15 17:53 ` Andreas Färber
2021-09-15 23:43 ` Andrew Jeffery
2021-09-16 7:13 ` Nicolas Ferre
2021-09-16 7:32 ` Chunyan Zhang
2021-09-16 7:48 ` Neil Armstrong
2021-09-16 12:54 ` Russell King (Oracle)
2021-09-16 20:30 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cd19a7d-797f-4951-c29a-c263f69a6631@linaro.org \
--to=elder@linaro.org \
--cc=dtwlin@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.