From: Bart Van Assche <bvanassche@acm.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
sathya.prakash@broadcom.com
Cc: sreekanth.reddy@broadcom.com,
suganath-prabu.subramani@broadcom.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, MPT-FusionLinux.pdl@broadcom.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: mpt3sas: make mpt3sas_dev_attrs static
Date: Tue, 19 Oct 2021 09:36:53 -0700 [thread overview]
Message-ID: <9cdf9d31-cb90-0792-29e8-52339c1e1043@acm.org> (raw)
In-Reply-To: <1634639239-2892-1-git-send-email-jiapeng.chong@linux.alibaba.com>
On 10/19/21 3:27 AM, Jiapeng Chong wrote:
> From: chongjiapeng <jiapeng.chong@linux.alibaba.com>
>
> This symbol is not used outside of mpt3sas_ctl.c, so marks it static.
>
> Fixes the following sparse warning:
>
> drivers/scsi/mpt3sas/mpt3sas_ctl.c:3988:18: warning: symbol
> 'mpt3sas_dev_attrs' was not declared. Should it be static?
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: 1bb3ca27d2ca ("scsi: mpt3sas: Switch to attribute groups")
> Signed-off-by: chongjiapeng <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/scsi/mpt3sas/mpt3sas_ctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_ctl.c b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
> index 0aabc9761be1..05b6c6a073c3 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_ctl.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
> @@ -3985,7 +3985,7 @@ sas_ncq_prio_enable_store(struct device *dev,
> }
> static DEVICE_ATTR_RW(sas_ncq_prio_enable);
>
> -struct attribute *mpt3sas_dev_attrs[] = {
> +static struct attribute *mpt3sas_dev_attrs[] = {
> &dev_attr_sas_address.attr,
> &dev_attr_sas_device_handle.attr,
> &dev_attr_sas_ncq_prio_supported.attr,
>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2021-10-19 16:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 10:27 [PATCH] scsi: mpt3sas: make mpt3sas_dev_attrs static Jiapeng Chong
2021-10-19 16:36 ` Bart Van Assche [this message]
2021-10-20 1:58 ` Himanshu Madhani
2021-10-21 2:58 ` Martin K. Petersen
2021-10-27 4:00 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cdf9d31-cb90-0792-29e8-52339c1e1043@acm.org \
--to=bvanassche@acm.org \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.