From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8262C63777 for ; Fri, 20 Nov 2020 11:25:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E73222253 for ; Fri, 20 Nov 2020 11:25:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728177AbgKTLZQ (ORCPT ); Fri, 20 Nov 2020 06:25:16 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:7962 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728129AbgKTLZQ (ORCPT ); Fri, 20 Nov 2020 06:25:16 -0500 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4CcvN926DKzhdJ2; Fri, 20 Nov 2020 19:24:57 +0800 (CST) Received: from [127.0.0.1] (10.57.60.129) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.487.0; Fri, 20 Nov 2020 19:25:03 +0800 Subject: Re: [PATCH] tty: serial: replace spin_lock_irqsave by spin_lock in hard IRQ To: Johan Hovold , Tian Tao CC: , , , , , , References: <1605776489-16283-1-git-send-email-tiantao6@hisilicon.com> From: "tiantao (H)" Message-ID: <9ce93d7b-f769-58ed-e6bf-95c34bd0123e@huawei.com> Date: Fri, 20 Nov 2020 19:25:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.57.60.129] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2020/11/20 16:23, Johan Hovold дµÀ: > On Thu, Nov 19, 2020 at 05:01:29PM +0800, Tian Tao wrote: >> The code has been in a irq-disabled context since it is hard IRQ. There >> is no necessity to do it again. >> >> Signed-off-by: Tian Tao >> --- >> drivers/tty/serial/owl-uart.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/tty/serial/owl-uart.c b/drivers/tty/serial/owl-uart.c >> index c149f8c3..472fdaf 100644 >> --- a/drivers/tty/serial/owl-uart.c >> +++ b/drivers/tty/serial/owl-uart.c >> @@ -251,10 +251,9 @@ static void owl_uart_receive_chars(struct uart_port *port) >> static irqreturn_t owl_uart_irq(int irq, void *dev_id) >> { >> struct uart_port *port = dev_id; >> - unsigned long flags; >> u32 stat; >> >> - spin_lock_irqsave(&port->lock, flags); >> + spin_lock(&port->lock); > > Same thing here; this will break with forced irq threading (i.e. > "threadirqs") since the console code can still end up being called from > interrupt context. As the following code shows, owl_uart_irq does not run in the irq threading context. ret = request_irq(port->irq, owl_uart_irq, IRQF_TRIGGER_HIGH, "owl-uart", port); if (ret) return ret; > >> stat = owl_uart_read(port, OWL_UART_STAT); >> >> @@ -268,7 +267,7 @@ static irqreturn_t owl_uart_irq(int irq, void *dev_id) >> stat |= OWL_UART_STAT_RIP | OWL_UART_STAT_TIP; >> owl_uart_write(port, stat, OWL_UART_STAT); >> >> - spin_unlock_irqrestore(&port->lock, flags); >> + spin_unlock(&port->lock); >> >> return IRQ_HANDLED; >> } > > Johan > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFF5FC5519F for ; Fri, 20 Nov 2020 11:25:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6397122244 for ; Fri, 20 Nov 2020 11:25:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="wg52MQCP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6397122244 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lRk/ziaUvdeZtK4p7EGXJmJjCWXS4S4MKPy+6kbmwxY=; b=wg52MQCPv6bQW4m7BwcPGoBA5 T3obkktvh8INr3M1bPqpQyiwj+A0iTg9EJkAfxHDjVok8mOEUPZgpM+mHQDYekCly1trKL5F1As8D 8+DAGpDvIlaYUn+8Efi06uZpdi875IGDS2M5L/KkGR2XveGvH0A17BkG0R10eatM6F0lZSgDECCKB 9r3C/Th2hUICeJTjg7B/EYuZOxAEAk/jTisScxAzES941KJyiEagQaBb0rGv9qrAGxUoJGgMD0JkC J2xoNtkNU0PWWzHInGYICIL3K8rgznLgTOpAtG6vY+Hk3/6UzODh1aspM7yF1OjIERoz0CYCNVOkc 3Od/t/mPA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg4XY-0000BK-CX; Fri, 20 Nov 2020 11:25:20 +0000 Received: from szxga06-in.huawei.com ([45.249.212.32]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg4XV-00009y-QK for linux-arm-kernel@lists.infradead.org; Fri, 20 Nov 2020 11:25:19 +0000 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4CcvN926DKzhdJ2; Fri, 20 Nov 2020 19:24:57 +0800 (CST) Received: from [127.0.0.1] (10.57.60.129) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.487.0; Fri, 20 Nov 2020 19:25:03 +0800 Subject: Re: [PATCH] tty: serial: replace spin_lock_irqsave by spin_lock in hard IRQ To: Johan Hovold , Tian Tao References: <1605776489-16283-1-git-send-email-tiantao6@hisilicon.com> From: "tiantao (H)" Message-ID: <9ce93d7b-f769-58ed-e6bf-95c34bd0123e@huawei.com> Date: Fri, 20 Nov 2020 19:25:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.57.60.129] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201120_062518_148524_5762EEE5 X-CRM114-Status: GOOD ( 13.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, manivannan.sadhasivam@linaro.org, jirislaby@kernel.org, afaerber@suse.de, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="gbk"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgrU2iAyMDIwLzExLzIwIDE2OjIzLCBKb2hhbiBIb3ZvbGQg0LS1wDoKPiBPbiBUaHUsIE5vdiAx OSwgMjAyMCBhdCAwNTowMToyOVBNICswODAwLCBUaWFuIFRhbyB3cm90ZToKPj4gVGhlIGNvZGUg aGFzIGJlZW4gaW4gYSBpcnEtZGlzYWJsZWQgY29udGV4dCBzaW5jZSBpdCBpcyBoYXJkIElSUS4g VGhlcmUKPj4gaXMgbm8gbmVjZXNzaXR5IHRvIGRvIGl0IGFnYWluLgo+Pgo+PiBTaWduZWQtb2Zm LWJ5OiBUaWFuIFRhbyA8dGlhbnRhbzZAaGlzaWxpY29uLmNvbT4KPj4gLS0tCj4+ICAgZHJpdmVy cy90dHkvc2VyaWFsL293bC11YXJ0LmMgfCA1ICsrLS0tCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDIg aW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv dHR5L3NlcmlhbC9vd2wtdWFydC5jIGIvZHJpdmVycy90dHkvc2VyaWFsL293bC11YXJ0LmMKPj4g aW5kZXggYzE0OWY4YzMuLjQ3MmZkYWYgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvdHR5L3Nlcmlh bC9vd2wtdWFydC5jCj4+ICsrKyBiL2RyaXZlcnMvdHR5L3NlcmlhbC9vd2wtdWFydC5jCj4+IEBA IC0yNTEsMTAgKzI1MSw5IEBAIHN0YXRpYyB2b2lkIG93bF91YXJ0X3JlY2VpdmVfY2hhcnMoc3Ry dWN0IHVhcnRfcG9ydCAqcG9ydCkKPj4gICBzdGF0aWMgaXJxcmV0dXJuX3Qgb3dsX3VhcnRfaXJx KGludCBpcnEsIHZvaWQgKmRldl9pZCkKPj4gICB7Cj4+ICAgCXN0cnVjdCB1YXJ0X3BvcnQgKnBv cnQgPSBkZXZfaWQ7Cj4+IC0JdW5zaWduZWQgbG9uZyBmbGFnczsKPj4gICAJdTMyIHN0YXQ7Cj4+ ICAgCj4+IC0Jc3Bpbl9sb2NrX2lycXNhdmUoJnBvcnQtPmxvY2ssIGZsYWdzKTsKPj4gKwlzcGlu X2xvY2soJnBvcnQtPmxvY2spOwo+IAo+IFNhbWUgdGhpbmcgaGVyZTsgdGhpcyB3aWxsIGJyZWFr IHdpdGggZm9yY2VkIGlycSB0aHJlYWRpbmcgKGkuZS4KPiAidGhyZWFkaXJxcyIpIHNpbmNlIHRo ZSBjb25zb2xlIGNvZGUgY2FuIHN0aWxsIGVuZCB1cCBiZWluZyBjYWxsZWQgZnJvbQo+IGludGVy cnVwdCBjb250ZXh0LgpBcyB0aGUgZm9sbG93aW5nIGNvZGUgc2hvd3MsIG93bF91YXJ0X2lycSBk b2VzIG5vdCBydW4gaW4gdGhlIGlycSAKdGhyZWFkaW5nIGNvbnRleHQuCiAgcmV0ID0gcmVxdWVz dF9pcnEocG9ydC0+aXJxLCBvd2xfdWFydF9pcnEsIElSUUZfVFJJR0dFUl9ISUdILAogICAgICAg ICAgICAgICAgICAgICAgICAgIm93bC11YXJ0IiwgcG9ydCk7CiAgICAgICAgIGlmIChyZXQpCiAg ICAgICAgICAgICAgICAgcmV0dXJuIHJldDsKCj4gCj4+ICAgCXN0YXQgPSBvd2xfdWFydF9yZWFk KHBvcnQsIE9XTF9VQVJUX1NUQVQpOwo+PiAgIAo+PiBAQCAtMjY4LDcgKzI2Nyw3IEBAIHN0YXRp YyBpcnFyZXR1cm5fdCBvd2xfdWFydF9pcnEoaW50IGlycSwgdm9pZCAqZGV2X2lkKQo+PiAgIAlz dGF0IHw9IE9XTF9VQVJUX1NUQVRfUklQIHwgT1dMX1VBUlRfU1RBVF9USVA7Cj4+ICAgCW93bF91 YXJ0X3dyaXRlKHBvcnQsIHN0YXQsIE9XTF9VQVJUX1NUQVQpOwo+PiAgIAo+PiAtCXNwaW5fdW5s b2NrX2lycXJlc3RvcmUoJnBvcnQtPmxvY2ssIGZsYWdzKTsKPj4gKwlzcGluX3VubG9jaygmcG9y dC0+bG9jayk7Cj4+ICAgCj4+ICAgCXJldHVybiBJUlFfSEFORExFRDsKPj4gICB9Cj4gCj4gSm9o YW4KPiAKPiAuCj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo=