All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yuan-Chi Pang <fu3mo6goo@gmail.com>, johannes@sipsolutions.net
Cc: davem@davemloft.net, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mac80211: fix to follow standard
Date: Tue, 28 Aug 2018 12:23:35 +0300	[thread overview]
Message-ID: <9cedcd76-2a05-00dd-2651-3b42d98a3692@cogentembedded.com> (raw)
In-Reply-To: <1535423074-130862-1-git-send-email-fu3mo6goo@gmail.com>

Hello!

On 8/28/2018 5:24 AM, Yuan-Chi Pang wrote:

> IEEE 802.11-2016 14.10.8.3 HWMP sequence numbering says:
> If it is a target mesh STA, it shall update its own HWMP SN to
> maximum (current HWMP SN, target HWMP SN in the PREQ element) + 1
> immediately before it generates a PREP element in response to a
> PREQ element.
> 
> Signed-off-by: Yuan-Chi Pang <fu3mo6goo@gmail.com>
> ---
>   net/mac80211/mesh_hwmp.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c
> index 35ad398..6c21a26 100644
> --- a/net/mac80211/mesh_hwmp.c
> +++ b/net/mac80211/mesh_hwmp.c
> @@ -572,6 +572,11 @@ static void hwmp_preq_frame_process(struct ieee80211_sub_if_data *sdata,
>   		forward = false;
>   		reply = true;
>   		target_metric = 0;
> +
> +		if (SN_GT(target_sn, ifmsh->sn)) {
> +			ifmsh->sn = target_sn;
> +		}

    No need for {} enclosing a single statement.

[...]

MBR, Sergei

  reply	other threads:[~2018-08-28 13:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-28  2:24 [PATCH] mac80211: fix to follow standard Yuan-Chi Pang
2018-08-28  9:23 ` Sergei Shtylyov [this message]
2018-08-28 12:44 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9cedcd76-2a05-00dd-2651-3b42d98a3692@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=davem@davemloft.net \
    --cc=fu3mo6goo@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.