From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB866C6FA8B for ; Mon, 19 Sep 2022 22:06:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229717AbiISWG1 (ORCPT ); Mon, 19 Sep 2022 18:06:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbiISWGZ (ORCPT ); Mon, 19 Sep 2022 18:06:25 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7D8248EB7 for ; Mon, 19 Sep 2022 15:06:23 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id c11so1222246wrp.11 for ; Mon, 19 Sep 2022 15:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=ixw7chpePOC+MLhrlMTpQHvviDIReReYqRXhDHS+LsE=; b=MTU+cL6hp6f9T9hHZK1qtBuS4UE3E75gmwhW8YWLDfnyfkP1ZKR7ntjgL9f0ZWI1Bq h4h6f8vzgNpa2NCsEFmvTDW7Kq/T1u03RvC+tw7QqBTnX7Z0nDH5FAm+U6asPpf8w2WS OBXDbSBf8oEB5Vjyp5az62OxCA9OfmgUUcmDFCXBC9wDo3r8XMj8N+6EX4IHYQu5Cj5S 4vBKLvNSGuldmPRo6coz7S7mCgTq40Sni6ak5grfz2ir3PaPyjm5BcbMiA02hEJVU8tq dEFV87LXthpwMdUgc63el5Lf4vRgJM6Tmkw8YnCLpTmX3iU/seH7aJ6FCVAQF+98caCj UnFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=ixw7chpePOC+MLhrlMTpQHvviDIReReYqRXhDHS+LsE=; b=pSAPn0PTW3gX48Gf3ecAcEDORgGUpbRQoJM/uVle1+KHK4cMVH+cSKfy13POAvL07y 99tCwsQKKsdhtxsq6/keAV4YB2ZQJ8G6SoRL7Kj05Njjnc2E72gAnY/+x1PMqhIe5nk4 lSD5KT32KSRJ/7oYeNR5tv6eUjXlks0VBNi00s03MoZ2dCah95GWDiQvIQOl/7Xo4lav W+YnWhkeLkdjHFH1+xnQAH951Bud8XIdSRw/PQr70KJCd6BfQU6ZSh92/s7KiTaI9V6E OcufPoCb+AISQEhBPlJI8+PYJCrR4y/lTh+UFinH1pybrcwKWDvNm2Fn/nYjOmVsFVSA vDkw== X-Gm-Message-State: ACrzQf1o6MiX2iDH6CfOXlzz7QZtXmzAGkdULeQQPRx7SdC/b1o1w1gY uXADiRY2DjpegPhjTnVfL45qBQ== X-Google-Smtp-Source: AMsMyM6xghtZubWcuL/UbtqUKWsZPmma3Wxd7oe7RWho2DnwtH1o58uPfquQMMN7QbsOio3L8ivREA== X-Received: by 2002:adf:d206:0:b0:228:64c1:c3fb with SMTP id j6-20020adfd206000000b0022864c1c3fbmr12014163wrh.260.1663625182237; Mon, 19 Sep 2022 15:06:22 -0700 (PDT) Received: from [192.168.0.17] (cpc152649-stkp13-2-0-cust121.10-2.cable.virginm.net. [86.15.83.122]) by smtp.gmail.com with ESMTPSA id h21-20020a05600c351500b003b491f99a25sm16756983wmq.22.2022.09.19.15.06.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 15:06:21 -0700 (PDT) Message-ID: <9d021e83-774f-3524-a65d-0ef0f74c8545@sifive.com> Date: Mon, 19 Sep 2022 23:06:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [RFC v4 08/10] pwm: dwc: add of/platform support Content-Language: en-GB To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , Thierry Reding , Krzysztof Kozlowski , Greentime Hu , jarkko.nikula@linux.intel.com, William Salmon , Jude Onyenegecha References: <20220816211454.237751-1-ben.dooks@sifive.com> <20220816211454.237751-9-ben.dooks@sifive.com> <20220915072430.bhpwk6iyqmyz6oie@pengutronix.de> From: Ben Dooks In-Reply-To: <20220915072430.bhpwk6iyqmyz6oie@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/09/2022 08:24, Uwe Kleine-König wrote: > Hello, > > On Tue, Aug 16, 2022 at 10:14:52PM +0100, Ben Dooks wrote: >> The dwc pwm controller can be used in non-PCI systems, so allow >> either platform or OF based probing. >> >> Signed-off-by: Ben Dooks >> --- >> v4: >> - split the of code out of the core >> - moved the compile test code earlier >> - fixed review comments >> - used NS_PER_SEC >> - use devm_clk_get_enabled >> v3: >> - changed compatible name >> --- >> drivers/pwm/Kconfig | 9 +++++ >> drivers/pwm/Makefile | 1 + >> drivers/pwm/pwm-dwc-of.c | 78 ++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 88 insertions(+) >> create mode 100644 drivers/pwm/pwm-dwc-of.c >> >> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig >> index a9f1c554db2b..f1735653365f 100644 >> --- a/drivers/pwm/Kconfig >> +++ b/drivers/pwm/Kconfig >> @@ -192,6 +192,15 @@ config PWM_DWC_PCI >> To compile this driver as a module, choose M here: the module >> will be called pwm-dwc-pci. >> >> +config PWM_DWC_OF >> + tristate "DesignWare PWM Controller (OF bus) > > There is a missing " which results in: > > drivers/pwm/Kconfig:196:warning: multi-line strings not supported > > Best regards > Uwe Thanks, fixed.