From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:55093 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752817AbdBTOhU (ORCPT ); Mon, 20 Feb 2017 09:37:20 -0500 Subject: Re: [PATCH] bcache: Make gc wakeup sane, remove set_task_state() To: Greg KH References: <1485177612-40394-1-git-send-email-colyli@suse.de> <20170123141634.GA12980@kroah.com> <20170123145407.GA24796@kroah.com> <20170220123137.GA28408@kroah.com> <20170220131258.hb2cg5myd2erbliq@kmo-pixel> <20170220140611.GA16122@kroah.com> Cc: Kent Overstreet , stable@vger.kernel.org From: Coly Li Message-ID: <9d02d389-c432-bddb-f592-018db38372c7@suse.de> Date: Mon, 20 Feb 2017 22:36:13 +0800 MIME-Version: 1.0 In-Reply-To: <20170220140611.GA16122@kroah.com> Content-Type: multipart/mixed; boundary="------------7029CF43F89BC639E5969774" Sender: stable-owner@vger.kernel.org List-ID: This is a multi-part message in MIME format. --------------7029CF43F89BC639E5969774 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 2017/2/20 下午10:06, Greg KH wrote: > On Mon, Feb 20, 2017 at 04:12:58AM -0900, Kent Overstreet wrote: >> On Mon, Feb 20, 2017 at 01:31:37PM +0100, Greg KH wrote: >>> On Mon, Jan 23, 2017 at 03:54:07PM +0100, Greg KH wrote: >>>> Kent, any hints? >>> >>> Without a response from the maintainer, I can't apply this... >>> >>> greg k-h >> >> Sorry I missed this - yes, this patch should be safe to apply and it does fix >> that crash. The relevant code hasn't been changed in ages, 4.4 is definitely >> fine. > > Ok, I've queued this up for 4.9, but for 4.4 it does not apply. Coly, > can you provide a working backport for 4.4-stable? Greg, It is because the 'commit 29e6c57cc78e ("bcache: bch_gc_thread() is not freezable")' remove a "try_to_freeze()" in bch_gc_thread(), which happens in v4.7. I just rebase Kent's fix to v4.4 kernel, solve the conflict. Could you please check and try the attached patch ? Thanks. Coly --------------7029CF43F89BC639E5969774 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="0001-bcache-Make-gc-wakeup-sane-remove-set_task_state.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-bcache-Make-gc-wakeup-sane-remove-set_task_state.patch" U3ViamVjdDogW1BBVENIXSBiY2FjaGU6IE1ha2UgZ2Mgd2FrZXVwIHNhbmUsIHJlbW92ZSBz ZXRfdGFza19zdGF0ZSgpCgpTaWduZWQtb2ZmLWJ5OiBLZW50IE92ZXJzdHJlZXQgPGtlbnQu b3ZlcnN0cmVldEBnbWFpbC5jb20+Ci0tLQogZHJpdmVycy9tZC9iY2FjaGUvYmNhY2hlLmgg IHwgIDQgKystLQogZHJpdmVycy9tZC9iY2FjaGUvYnRyZWUuYyAgIHwgNDAgKysrKysrKysr KysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLQogZHJpdmVycy9tZC9iY2FjaGUvYnRy ZWUuaCAgIHwgIDMgKy0tCiBkcml2ZXJzL21kL2JjYWNoZS9yZXF1ZXN0LmMgfCAgNCArLS0t CiBkcml2ZXJzL21kL2JjYWNoZS9zdXBlci5jICAgfCAgMiArKwogNSBmaWxlcyBjaGFuZ2Vk LCAyNiBpbnNlcnRpb25zKCspLCAyNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2 ZXJzL21kL2JjYWNoZS9iY2FjaGUuaCBiL2RyaXZlcnMvbWQvYmNhY2hlL2JjYWNoZS5oCmlu ZGV4IDZiNDIwYTUuLmMzZWEwM2MgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvbWQvYmNhY2hlL2Jj YWNoZS5oCisrKyBiL2RyaXZlcnMvbWQvYmNhY2hlL2JjYWNoZS5oCkBAIC00MjUsNyArNDI1 LDcgQEAgc3RydWN0IGNhY2hlIHsKIAkgKiB1bnRpbCBhIGdjIGZpbmlzaGVzIC0gb3RoZXJ3 aXNlIHdlIGNvdWxkIHBvaW50bGVzc2x5IGJ1cm4gYSB0b24gb2YKIAkgKiBjcHUKIAkgKi8K LQl1bnNpZ25lZAkJaW52YWxpZGF0ZV9uZWVkc19nYzoxOworCXVuc2lnbmVkCQlpbnZhbGlk YXRlX25lZWRzX2djOwogCiAJYm9vbAkJCWRpc2NhcmQ7IC8qIEdldCByaWQgb2Y/ICovCiAK QEAgLTU5Myw4ICs1OTMsOCBAQCBzdHJ1Y3QgY2FjaGVfc2V0IHsKIAogCS8qIENvdW50cyBo b3cgbWFueSBzZWN0b3JzIGJpb19pbnNlcnQgaGFzIGFkZGVkIHRvIHRoZSBjYWNoZSAqLwog CWF0b21pY190CQlzZWN0b3JzX3RvX2djOworCXdhaXRfcXVldWVfaGVhZF90CWdjX3dhaXQ7 CiAKLQl3YWl0X3F1ZXVlX2hlYWRfdAltb3ZpbmdfZ2Nfd2FpdDsKIAlzdHJ1Y3Qga2V5YnVm CQltb3ZpbmdfZ2Nfa2V5czsKIAkvKiBOdW1iZXIgb2YgbW92aW5nIEdDIGJpb3MgaW4gZmxp Z2h0ICovCiAJc3RydWN0IHNlbWFwaG9yZQltb3ZpbmdfaW5fZmxpZ2h0OwpkaWZmIC0tZ2l0 IGEvZHJpdmVycy9tZC9iY2FjaGUvYnRyZWUuYyBiL2RyaXZlcnMvbWQvYmNhY2hlL2J0cmVl LmMKaW5kZXggODMzOTJmOC4uYjVlY2NiNSAxMDA2NDQKLS0tIGEvZHJpdmVycy9tZC9iY2Fj aGUvYnRyZWUuYworKysgYi9kcml2ZXJzL21kL2JjYWNoZS9idHJlZS5jCkBAIC0xNzYxLDMz ICsxNzYxLDM0IEBAIHN0YXRpYyB2b2lkIGJjaF9idHJlZV9nYyhzdHJ1Y3QgY2FjaGVfc2V0 ICpjKQogCWJjaF9tb3ZpbmdfZ2MoYyk7CiB9CiAKLXN0YXRpYyBpbnQgYmNoX2djX3RocmVh ZCh2b2lkICphcmcpCitzdGF0aWMgYm9vbCBnY19zaG91bGRfcnVuKHN0cnVjdCBjYWNoZV9z ZXQgKmMpCiB7Ci0Jc3RydWN0IGNhY2hlX3NldCAqYyA9IGFyZzsKIAlzdHJ1Y3QgY2FjaGUg KmNhOwogCXVuc2lnbmVkIGk7CiAKLQl3aGlsZSAoMSkgewotYWdhaW46Ci0JCWJjaF9idHJl ZV9nYyhjKTsKKwlmb3JfZWFjaF9jYWNoZShjYSwgYywgaSkKKwkJaWYgKGNhLT5pbnZhbGlk YXRlX25lZWRzX2djKQorCQkJcmV0dXJuIHRydWU7CiAKLQkJc2V0X2N1cnJlbnRfc3RhdGUo VEFTS19JTlRFUlJVUFRJQkxFKTsKLQkJaWYgKGt0aHJlYWRfc2hvdWxkX3N0b3AoKSkKLQkJ CWJyZWFrOworCWlmIChhdG9taWNfcmVhZCgmYy0+c2VjdG9yc190b19nYykgPCAwKQorCQly ZXR1cm4gdHJ1ZTsKIAotCQltdXRleF9sb2NrKCZjLT5idWNrZXRfbG9jayk7CisJcmV0dXJu IGZhbHNlOworfQogCi0JCWZvcl9lYWNoX2NhY2hlKGNhLCBjLCBpKQotCQkJaWYgKGNhLT5p bnZhbGlkYXRlX25lZWRzX2djKSB7Ci0JCQkJbXV0ZXhfdW5sb2NrKCZjLT5idWNrZXRfbG9j ayk7Ci0JCQkJc2V0X2N1cnJlbnRfc3RhdGUoVEFTS19SVU5OSU5HKTsKLQkJCQlnb3RvIGFn YWluOwotCQkJfQorc3RhdGljIGludCBiY2hfZ2NfdGhyZWFkKHZvaWQgKmFyZykKK3sKKwlz dHJ1Y3QgY2FjaGVfc2V0ICpjID0gYXJnOwogCi0JCW11dGV4X3VubG9jaygmYy0+YnVja2V0 X2xvY2spOworCXdoaWxlICgxKSB7CisJCXdhaXRfZXZlbnRfaW50ZXJydXB0aWJsZShjLT5n Y193YWl0LAorCQkJICAga3RocmVhZF9zaG91bGRfc3RvcCgpIHx8IGdjX3Nob3VsZF9ydW4o YykpOwogCi0JCXRyeV90b19mcmVlemUoKTsKLQkJc2NoZWR1bGUoKTsKKwkJaWYgKGt0aHJl YWRfc2hvdWxkX3N0b3AoKSkKKwkJCWJyZWFrOworCisJCXNldF9nY19zZWN0b3JzKGMpOwor CQliY2hfYnRyZWVfZ2MoYyk7CiAJfQogCiAJcmV0dXJuIDA7CkBAIC0xNzk1LDExICsxNzk2 LDEwIEBAIGFnYWluOgogCiBpbnQgYmNoX2djX3RocmVhZF9zdGFydChzdHJ1Y3QgY2FjaGVf c2V0ICpjKQogewotCWMtPmdjX3RocmVhZCA9IGt0aHJlYWRfY3JlYXRlKGJjaF9nY190aHJl YWQsIGMsICJiY2FjaGVfZ2MiKTsKKwljLT5nY190aHJlYWQgPSBrdGhyZWFkX3J1bihiY2hf Z2NfdGhyZWFkLCBjLCAiYmNhY2hlX2djIik7CiAJaWYgKElTX0VSUihjLT5nY190aHJlYWQp KQogCQlyZXR1cm4gUFRSX0VSUihjLT5nY190aHJlYWQpOwogCi0Jc2V0X3Rhc2tfc3RhdGUo Yy0+Z2NfdGhyZWFkLCBUQVNLX0lOVEVSUlVQVElCTEUpOwogCXJldHVybiAwOwogfQogCmRp ZmYgLS1naXQgYS9kcml2ZXJzL21kL2JjYWNoZS9idHJlZS5oIGIvZHJpdmVycy9tZC9iY2Fj aGUvYnRyZWUuaAppbmRleCA1YzM5MWZhLi45YjgwNDE3IDEwMDY0NAotLS0gYS9kcml2ZXJz L21kL2JjYWNoZS9idHJlZS5oCisrKyBiL2RyaXZlcnMvbWQvYmNhY2hlL2J0cmVlLmgKQEAg LTI2MCw4ICsyNjAsNyBAQCB2b2lkIGJjaF9pbml0aWFsX21hcmtfa2V5KHN0cnVjdCBjYWNo ZV9zZXQgKiwgaW50LCBzdHJ1Y3QgYmtleSAqKTsKIAogc3RhdGljIGlubGluZSB2b2lkIHdh a2VfdXBfZ2Moc3RydWN0IGNhY2hlX3NldCAqYykKIHsKLQlpZiAoYy0+Z2NfdGhyZWFkKQot CQl3YWtlX3VwX3Byb2Nlc3MoYy0+Z2NfdGhyZWFkKTsKKwl3YWtlX3VwKCZjLT5nY193YWl0 KTsKIH0KIAogI2RlZmluZSBNQVBfRE9ORQkwCmRpZmYgLS1naXQgYS9kcml2ZXJzL21kL2Jj YWNoZS9yZXF1ZXN0LmMgYi9kcml2ZXJzL21kL2JjYWNoZS9yZXF1ZXN0LmMKaW5kZXggMjVm YTg0NC4uMjQxMGRmMSAxMDA2NDQKLS0tIGEvZHJpdmVycy9tZC9iY2FjaGUvcmVxdWVzdC5j CisrKyBiL2RyaXZlcnMvbWQvYmNhY2hlL3JlcXVlc3QuYwpAQCAtMTk2LDEwICsxOTYsOCBA QCBzdGF0aWMgdm9pZCBiY2hfZGF0YV9pbnNlcnRfc3RhcnQoc3RydWN0IGNsb3N1cmUgKmNs KQogCXN0cnVjdCBkYXRhX2luc2VydF9vcCAqb3AgPSBjb250YWluZXJfb2YoY2wsIHN0cnVj dCBkYXRhX2luc2VydF9vcCwgY2wpOwogCXN0cnVjdCBiaW8gKmJpbyA9IG9wLT5iaW8sICpu OwogCi0JaWYgKGF0b21pY19zdWJfcmV0dXJuKGJpb19zZWN0b3JzKGJpbyksICZvcC0+Yy0+ c2VjdG9yc190b19nYykgPCAwKSB7Ci0JCXNldF9nY19zZWN0b3JzKG9wLT5jKTsKKwlpZiAo YXRvbWljX3N1Yl9yZXR1cm4oYmlvX3NlY3RvcnMoYmlvKSwgJm9wLT5jLT5zZWN0b3JzX3Rv X2djKSA8IDApCiAJCXdha2VfdXBfZ2Mob3AtPmMpOwotCX0KIAogCWlmIChvcC0+YnlwYXNz KQogCQlyZXR1cm4gYmNoX2RhdGFfaW52YWxpZGF0ZShjbCk7CmRpZmYgLS1naXQgYS9kcml2 ZXJzL21kL2JjYWNoZS9zdXBlci5jIGIvZHJpdmVycy9tZC9iY2FjaGUvc3VwZXIuYwppbmRl eCA2NzlhMDkzLi44MWZlZjIzIDEwMDY0NAotLS0gYS9kcml2ZXJzL21kL2JjYWNoZS9zdXBl ci5jCisrKyBiL2RyaXZlcnMvbWQvYmNhY2hlL3N1cGVyLmMKQEAgLTE0NzQsNiArMTQ3NCw3 IEBAIHN0cnVjdCBjYWNoZV9zZXQgKmJjaF9jYWNoZV9zZXRfYWxsb2Moc3RydWN0IGNhY2hl X3NiICpzYikKIAltdXRleF9pbml0KCZjLT5idWNrZXRfbG9jayk7CiAJaW5pdF93YWl0cXVl dWVfaGVhZCgmYy0+YnRyZWVfY2FjaGVfd2FpdCk7CiAJaW5pdF93YWl0cXVldWVfaGVhZCgm Yy0+YnVja2V0X3dhaXQpOworCWluaXRfd2FpdHF1ZXVlX2hlYWQoJmMtPmdjX3dhaXQpOwog CXNlbWFfaW5pdCgmYy0+dXVpZF93cml0ZV9tdXRleCwgMSk7CiAKIAlzcGluX2xvY2tfaW5p dCgmYy0+YnRyZWVfZ2NfdGltZS5sb2NrKTsKQEAgLTE1MzIsNiArMTUzMyw3IEBAIHN0YXRp YyB2b2lkIHJ1bl9jYWNoZV9zZXQoc3RydWN0IGNhY2hlX3NldCAqYykKIAogCWZvcl9lYWNo X2NhY2hlKGNhLCBjLCBpKQogCQljLT5uYnVja2V0cyArPSBjYS0+c2IubmJ1Y2tldHM7CisJ c2V0X2djX3NlY3RvcnMoYyk7CiAKIAlpZiAoQ0FDSEVfU1lOQygmYy0+c2IpKSB7CiAJCUxJ U1RfSEVBRChqb3VybmFsKTsKLS0gCjIuMTAuMgoK --------------7029CF43F89BC639E5969774--