From: Yanjun Zhu <yanjun.zhu@linux.dev>
To: Kamal Heib <kamalheib1@gmail.com>, Jason Gunthorpe <jgg@ziepe.ca>
Cc: Zhu Yanjun <zyjzyj2000@gmail.com>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
Doug Ledford <dledford@redhat.com>
Subject: Re: [PATCH for-rc] RDMA/rxe: Fix failure during driver load
Date: Wed, 2 Jun 2021 22:04:18 +0800 [thread overview]
Message-ID: <9d05b6fd-e9e5-f830-7b92-3b0428bc0711@linux.dev> (raw)
In-Reply-To: <YLeDL+Omy8QdI+Q+@kheib-workstation>
在 2021/6/2 21:10, Kamal Heib 写道:
> On Tue, Jun 01, 2021 at 02:01:32PM -0300, Jason Gunthorpe wrote:
>> On Tue, Jun 01, 2021 at 11:59:44PM +0800, Zhu Yanjun wrote:
>>> On Tue, Jun 1, 2021 at 5:09 PM Kamal Heib <kamalheib1@gmail.com> wrote:
>>>> On Tue, Jun 01, 2021 at 04:11:08PM +0800, Zhu Yanjun wrote:
>>>>> On Tue, Jun 1, 2021 at 3:56 PM kamal heib <kamalheib1@gmail.com> wrote:
>>>>>>
>>>>>>
>>>>>>> On 1 Jun 2021, at 10:45, Zhu Yanjun <zyjzyj2000@gmail.com> wrote:
>>>>>>>
>>>>>>> On Tue, Jun 1, 2021 at 1:58 PM Kamal Heib <kamalheib1@gmail.com> wrote:
>>>>>>>> To avoid the following failure when trying to load the rdma_rxe module
>>>>>>>> while IPv6 is disabled, Add a check to make sure that IPv6 is enabled
>>>>>>>> before trying to create the IPv6 UDP tunnel.
>>>>>>>>
>>>>>>>> $ modprobe rdma_rxe
>>>>>>>> modprobe: ERROR: could not insert 'rdma_rxe': Operation not permitted
>>>>>>> About this problem, this link:
>>>>>>> https://patchwork.kernel.org/project/linux-rdma/patch/20210413234252.12209-1-yanjun.zhu@intel.com/
>>>>>>> also tries to solve ipv6 problem.
>>>>>>>
>>>>>>> Zhu Yanjun
>>>>>>>
>>>>>> Yes, but this patch is fixing the problem more cleanly and I’ve tested it.
>>> Please check this link
>>> https://lore.kernel.org/linux-rdma/20210326012723.41769-1-yanjun.zhu@intel.com/T/
>>> carefully.
>>>
>>> Please pay attention to the comments from Jason Gunthorpe
>> I think the comment still holds, the correct fix is to detect the -97
>> errno down in the call chain and just ignore ipv6 support in this
>> case.
>>
>> Jason
> OK, Could you please tell me what do you think about the following:
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c
> index 01662727dca0..144d9e1c1c3d 100644
> --- a/drivers/infiniband/sw/rxe/rxe_net.c
> +++ b/drivers/infiniband/sw/rxe/rxe_net.c
> @@ -208,6 +208,11 @@ static struct socket *rxe_setup_udp_tunnel(struct net *net, __be16 port,
> /* Create UDP socket */
> err = udp_sock_create(net, &udp_cfg, &sock);
> if (err < 0) {
> + if (ipv6 && (err == -EAFNOSUPPORT)) {
> + pr_warn("IPv6 is not supported can not create UDP socket\n");
> + return NULL;
The returned value is changed.
Zhu Yanjun
> + }
> +
> pr_err("failed to create udp socket. err = %d\n", err);
> return ERR_PTR(err);
> }
>
>
> Thanks,
> Kamal
next prev parent reply other threads:[~2021-06-02 14:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 5:56 [PATCH for-rc] RDMA/rxe: Fix failure during driver load Kamal Heib
2021-06-01 7:45 ` Zhu Yanjun
2021-06-01 7:56 ` kamal heib
2021-06-01 8:11 ` Zhu Yanjun
2021-06-01 9:09 ` Kamal Heib
2021-06-01 15:59 ` Zhu Yanjun
2021-06-01 17:01 ` Jason Gunthorpe
2021-06-02 7:22 ` Zhu Yanjun
2021-06-02 13:10 ` Kamal Heib
2021-06-02 14:04 ` Yanjun Zhu [this message]
2021-06-02 23:31 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d05b6fd-e9e5-f830-7b92-3b0428bc0711@linux.dev \
--to=yanjun.zhu@linux.dev \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kamalheib1@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.