From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 520E4C11F65 for ; Wed, 30 Jun 2021 08:27:08 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E9F161CA2 for ; Wed, 30 Jun 2021 08:27:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E9F161CA2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 04EC782BD5; Wed, 30 Jun 2021 10:27:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=walle.cc header.i=@walle.cc header.b="GtVbOp6X"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AA20082BD8; Wed, 30 Jun 2021 10:27:02 +0200 (CEST) Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EF28F82BB2 for ; Wed, 30 Jun 2021 10:26:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@walle.cc Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 30FA92225B; Wed, 30 Jun 2021 10:26:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1625041618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4D2c4qRM7Q5+1o796yutNRhs9qrvUbQK6h/Yx7invbI=; b=GtVbOp6XoP3iyj/P/pmjjnXNmSt6mtY21DM+2SfWVy1Ng/SfwIx/qHXwz1mgT0gEFy1wyI XfcYa+UL0q0YV7d6FDOKcslNzyjHgUR083wLBGSLjmoBrk1Qne6w6J2z3RoqxdpLpMGy7P RzvWZyjKjl+u8mMRPXvv3ZaUF/DZz/4= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 30 Jun 2021 10:26:57 +0200 From: Michael Walle To: u-boot@lists.denx.de, Ramon Fried , Vladimir Oltean , Priyanka Jain Subject: Re: [PATCH v2] board: sl28: add DSA support for variant 2 In-Reply-To: <20210623115602.5015-1-michael@walle.cc> References: <20210623115602.5015-1-michael@walle.cc> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <9d1873bbe6909811f6be546a0004030b@walle.cc> X-Sender: michael@walle.cc X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Am 2021-06-23 13:56, schrieb Michael Walle: > Now that u-boot gained DSA support, and it is already enabled for the > kontron_sl28 board, add the last missing piece and enable the > corresponding devices it in the device tree. > > Signed-off-by: Michael Walle > --- > changes since v1: > - renamed ethernet alias stem, because it was changed in > commit 82a3c9ef20d43d97416589854b4bbcb4c2450c24 ("net: use the same > alias stem for ethernet as linux") > > Now that the mentioned commit made it finally into u-boot. We can move > forward here. It would be nice if this would still make it into > 2021.07, > given that this is only a device tree change for a this particular > board. Can this please go through the net queue? By chance, I've seen this patch: https://patchwork.ozlabs.org/project/uboot/patch/20210629175317.2607470-5-vladimir.oltean@nxp.com/ Now I'm lucky that I have the following chunk, otherwise the patch wouldn't work. +&enetc2 { + status = "okay"; +}; In any case, I'd retest this patch today based on u-boot-net/master (together with Vladimirs new patch series which configures the autoneg at probe time). -michael > > .../fsl-ls1028a-kontron-sl28-var2-u-boot.dtsi | 7 ++++ > .../arm/dts/fsl-ls1028a-kontron-sl28-var2.dts | 40 +++++++++++++++++++ > 2 files changed, 47 insertions(+) > > diff --git a/arch/arm/dts/fsl-ls1028a-kontron-sl28-var2-u-boot.dtsi > b/arch/arm/dts/fsl-ls1028a-kontron-sl28-var2-u-boot.dtsi > index 79b771e074..4e0ce3f77d 100644 > --- a/arch/arm/dts/fsl-ls1028a-kontron-sl28-var2-u-boot.dtsi > +++ b/arch/arm/dts/fsl-ls1028a-kontron-sl28-var2-u-boot.dtsi > @@ -1,2 +1,9 @@ > // SPDX-License-Identifier: GPL-2.0+ > #include "fsl-ls1028a-kontron-sl28-u-boot.dtsi" > + > +/ { > + aliases { > + ethernet0 = &mscc_felix_port0; > + ethernet1 = &mscc_felix_port1; > + }; > +}; > diff --git a/arch/arm/dts/fsl-ls1028a-kontron-sl28-var2.dts > b/arch/arm/dts/fsl-ls1028a-kontron-sl28-var2.dts > index 1ea1265bcf..7a3aa21408 100644 > --- a/arch/arm/dts/fsl-ls1028a-kontron-sl28-var2.dts > +++ b/arch/arm/dts/fsl-ls1028a-kontron-sl28-var2.dts > @@ -22,4 +22,44 @@ > /delete-property/ phy-handle; > }; > > +&enetc2 { > + status = "okay"; > +}; > + > +&mscc_felix { > + status = "okay"; > +}; > + > +&mscc_felix_port0 { > + label = "gbe0"; > + phy-handle = <&phy0>; > + phy-mode = "sgmii"; > + status = "okay"; > +}; > + > +&mscc_felix_port1 { > + label = "gbe1"; > + phy-handle = <&phy1>; > + phy-mode = "sgmii"; > + status = "okay"; > +}; > + > +&mscc_felix_port4 { > + ethernet = <&enetc2>; > + status = "okay"; > +}; > + > /delete-node/ &phy0; > +&mdio0 { > + phy0: ethernet-phy@5 { > + reg = <0x5>; > + eee-broken-1000t; > + eee-broken-100tx; > + }; > + > + phy1: ethernet-phy@4 { > + reg = <0x4>; > + eee-broken-1000t; > + eee-broken-100tx; > + }; > +}; -- -michael