From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932088AbcE0QGQ (ORCPT ); Fri, 27 May 2016 12:06:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34217 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755824AbcE0QGJ (ORCPT ); Fri, 27 May 2016 12:06:09 -0400 Subject: Re: [PATCH 3/3] pvclock: Add a new wrapper function to only get variable flags To: Andy Lutomirski , Minfei Huang References: <1464329832-4638-1-git-send-email-mnghuan@gmail.com> <1464329832-4638-3-git-send-email-mnghuan@gmail.com> Cc: Borislav Petkov , Andrew Lutomirski , "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , X86 ML , "linux-kernel@vger.kernel.org" From: Paolo Bonzini Message-ID: <9d18b1a3-90b4-6969-6bda-b7556d8264a6@redhat.com> Date: Fri, 27 May 2016 18:06:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 27 May 2016 16:06:09 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/05/2016 17:40, Andy Lutomirski wrote: > On Thu, May 26, 2016 at 11:17 PM, Minfei Huang wrote: >> There is a generic function __pvclock_read_cycles to be used to get both >> flags and cycles. For function pvclock_read_flags, it's useless to get >> cycles value. To make this function be more effective, add a new wrapper >> function to only get variable flags. > > Why not just get rid of this function entirely? I agree. If you want to abstract the retry logic, perhaps you can add pvclock_read_{begin,retry} functions like seqlock_read_{begin,retry}? Thanks, Paolo