From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 10 May 2019 13:59:19 +0200 Subject: [U-Boot] [PATCH 05/14] arm: socfpga: Move Stratix10 and Agilex system manager common code In-Reply-To: <1557467688-73706-6-git-send-email-ley.foon.tan@intel.com> References: <1557467688-73706-1-git-send-email-ley.foon.tan@intel.com> <1557467688-73706-6-git-send-email-ley.foon.tan@intel.com> Message-ID: <9d252b99-da5e-460c-cb35-1f0b58cc3311@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 5/10/19 7:54 AM, Ley Foon Tan wrote: > Move Stratix10 and Agilex system manager common code to system_manager.h. > > Signed-off-by: Ley Foon Tan This becomes quite a bit of ifdeffery . Why don't you have the system_manager.h include system_manager_$soc.h like e.g. here? http://git.denx.de/?p=u-boot.git;a=blob;f=arch/arm/mach-rmobile/include/mach/rmobile.h -- Best regards, Marek Vasut