From: Nikolay Borisov <nborisov@suse.com>
To: Johannes Thumshirn <jthumshirn@suse.de>, David Sterba <dsterba@suse.com>
Cc: Linux BTRFS Mailinglist <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 0/4] Small coding style cleanups
Date: Fri, 18 Oct 2019 15:02:13 +0300 [thread overview]
Message-ID: <9d3d5d3b-25ae-a2bf-c59d-8cd13a2bb84a@suse.com> (raw)
In-Reply-To: <20191018095823.15282-1-jthumshirn@suse.de>
On 18.10.19 г. 12:58 ч., Johannes Thumshirn wrote:
> Here are some minor coding style cleanups which I think are neat as they make
> some functions a bit easier to read.
>
> None of these patches is really needed though.
>
> The patches have no regressions with regrads to the basline
> btrfs-devel/misc-next on an xfstests -g auto run.
>
> A gitweb preview can be found at
> https://git.kernel.org/pub/scm/linux/kernel/git/jth/linux.git/log/?h=btrfs-raid-cleanups
>
> Note I did rebase the branch because one patch did not have a changelog.
>
> Johannes Thumshirn (4):
> btrfs: reduce indentation in lock_stripe_add
> btrfs: remove pointless local variable in lock_stripe_add()
> btrfs: reduce indentation in btrfs_may_alloc_data_chunk
> btrfs: remove pointless indentation in btrfs_read_sys_array()
>
> fs/btrfs/raid56.c | 95 ++++++++++++++++++++++-----------------------
> fs/btrfs/volumes.c | 112 +++++++++++++++++++++++++++--------------------------
> 2 files changed, 103 insertions(+), 104 deletions(-)
>
Patches 2-4 LGTM you can add, :
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
next prev parent reply other threads:[~2019-10-18 12:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 9:58 [PATCH 0/4] Small coding style cleanups Johannes Thumshirn
2019-10-18 9:58 ` [PATCH 1/4] btrfs: reduce indentation in lock_stripe_add Johannes Thumshirn
2019-10-21 12:45 ` Nikolay Borisov
2019-10-21 13:30 ` David Sterba
2019-10-18 9:58 ` [PATCH 2/4] btrfs: remove pointless local variable in lock_stripe_add() Johannes Thumshirn
2019-10-18 9:58 ` [PATCH 3/4] btrfs: reduce indentation in btrfs_may_alloc_data_chunk Johannes Thumshirn
2019-10-18 9:58 ` [PATCH 4/4] btrfs: remove pointless indentation in btrfs_read_sys_array() Johannes Thumshirn
2019-10-18 12:02 ` Nikolay Borisov [this message]
2019-10-21 8:06 ` [PATCH 0/4] Small coding style cleanups Johannes Thumshirn
2019-10-21 12:32 ` Nikolay Borisov
2019-10-21 12:42 ` Johannes Thumshirn
2019-10-21 13:38 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d3d5d3b-25ae-a2bf-c59d-8cd13a2bb84a@suse.com \
--to=nborisov@suse.com \
--cc=dsterba@suse.com \
--cc=jthumshirn@suse.de \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.