From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B33DBC433F5 for ; Fri, 29 Oct 2021 13:31:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D68A611EF for ; Fri, 29 Oct 2021 13:31:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231616AbhJ2Nd4 (ORCPT ); Fri, 29 Oct 2021 09:33:56 -0400 Received: from foss.arm.com ([217.140.110.172]:38348 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231607AbhJ2Ndz (ORCPT ); Fri, 29 Oct 2021 09:33:55 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0102D1063; Fri, 29 Oct 2021 06:31:27 -0700 (PDT) Received: from [10.57.25.71] (unknown [10.57.25.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4A5CC3F73D; Fri, 29 Oct 2021 06:31:25 -0700 (PDT) Subject: Re: [PATCH] [RFC] arm64: export this_cpu_has_cap To: Arnd Bergmann , Catalin Marinas , Will Deacon , Mathieu Poirier , Anshuman Khandual Cc: Arnd Bergmann , Marc Zyngier , Mark Rutland , David Brazdil , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20211029113023.760421-1-arnd@kernel.org> From: Suzuki K Poulose Message-ID: <9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com> Date: Fri, 29 Oct 2021 14:31:23 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211029113023.760421-1-arnd@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd Thanks for the fix. On 29/10/2021 12:30, Arnd Bergmann wrote: > From: Arnd Bergmann > > It's now used in a coresight driver that can be a loadable module: > > ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined! > > Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling") Reviewed-by: Suzuki K Poulose Tested-by: Suzuki K Poulose Will, Catalin, Mathieu, Do you have a preference on how this fix can be pulled in ? This may be safe to go via coresight tree if it is not too late. Otherwise, it could go via the arm64 tree. Suzuki > Signed-off-by: Arnd Bergmann > --- > Not sure if we actually want this to be exported, this is my local > workaround for the randconfig build bot. > --- > arch/arm64/kernel/cpufeature.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index ecbdff795f5e..beccbcfa7391 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n) > > return false; > } > +EXPORT_SYMBOL(this_cpu_has_cap); > > /* > * This helper function is used in a narrow window when, > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9BA9C433F5 for ; Fri, 29 Oct 2021 13:33:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D19C60C51 for ; Fri, 29 Oct 2021 13:33:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7D19C60C51 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H1xkFcGaI0AeV36Xaoizq6eD6de9g1Iyk/UzjfeE06c=; b=qMRmCrm9jxGJfv5h1o0xMT3B48 waPZ6ojt9+kTsn8+WKKjLIX0r9flRp5w3MyWC9YI6i9t1hQplZ/gsBcwNqNVUpXE3yoSiu10sEepX w4ihW+cWpDb4meAh9jXtDDnOZaDdLyg1/DBzXsfqFyM62xwq6qE8B9NVq6cSH6FVT8WCngIS9Xzqh abBB2rNrKSbjjEZv4WhMTs4R417eUwwFl0HbN1ycyH1+Z9GQmRxbpkNqP/wTT9MifR0S6XrpgOkkZ ODgtAbLoLqQvRAdVx690oigructuH8+on/HkYbQeTWx79pi0Qh4+TCQLHUyS93yBrAM2ICo6bOR+a HPPIyaqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgRyn-00B39B-HM; Fri, 29 Oct 2021 13:31:33 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgRyk-00B38d-IX for linux-arm-kernel@lists.infradead.org; Fri, 29 Oct 2021 13:31:31 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0102D1063; Fri, 29 Oct 2021 06:31:27 -0700 (PDT) Received: from [10.57.25.71] (unknown [10.57.25.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4A5CC3F73D; Fri, 29 Oct 2021 06:31:25 -0700 (PDT) Subject: Re: [PATCH] [RFC] arm64: export this_cpu_has_cap To: Arnd Bergmann , Catalin Marinas , Will Deacon , Mathieu Poirier , Anshuman Khandual Cc: Arnd Bergmann , Marc Zyngier , Mark Rutland , David Brazdil , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20211029113023.760421-1-arnd@kernel.org> From: Suzuki K Poulose Message-ID: <9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com> Date: Fri, 29 Oct 2021 14:31:23 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211029113023.760421-1-arnd@kernel.org> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211029_063130_697493_9B0BF977 X-CRM114-Status: GOOD ( 20.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Arnd Thanks for the fix. On 29/10/2021 12:30, Arnd Bergmann wrote: > From: Arnd Bergmann > > It's now used in a coresight driver that can be a loadable module: > > ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined! > > Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling") Reviewed-by: Suzuki K Poulose Tested-by: Suzuki K Poulose Will, Catalin, Mathieu, Do you have a preference on how this fix can be pulled in ? This may be safe to go via coresight tree if it is not too late. Otherwise, it could go via the arm64 tree. Suzuki > Signed-off-by: Arnd Bergmann > --- > Not sure if we actually want this to be exported, this is my local > workaround for the randconfig build bot. > --- > arch/arm64/kernel/cpufeature.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index ecbdff795f5e..beccbcfa7391 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n) > > return false; > } > +EXPORT_SYMBOL(this_cpu_has_cap); > > /* > * This helper function is used in a narrow window when, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel