* [PATCH] malloc: fix not unlocking hotplug on fail to init
@ 2018-04-13 15:58 Anatoly Burakov
2018-04-17 10:14 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Anatoly Burakov @ 2018-04-13 15:58 UTC (permalink / raw)
To: dev; +Cc: anatoly.burakov
We lock the hotplug during init, but do not unlock it if we couldn't
register multiprocess callbacks. Add the missing unlock.
Fixes: 07dcbfe0101f ("malloc: support multiprocess memory hotplug")
Cc: anatoly.burakov@intel.com
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/librte_eal/common/malloc_heap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/common/malloc_heap.c b/lib/librte_eal/common/malloc_heap.c
index 41c14a8..590e9e3 100644
--- a/lib/librte_eal/common/malloc_heap.c
+++ b/lib/librte_eal/common/malloc_heap.c
@@ -815,6 +815,7 @@ rte_eal_malloc_heap_init(void)
if (register_mp_requests()) {
RTE_LOG(ERR, EAL, "Couldn't register malloc multiprocess actions\n");
+ rte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);
return -1;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] malloc: fix not unlocking hotplug on fail to init
2018-04-13 15:58 [PATCH] malloc: fix not unlocking hotplug on fail to init Anatoly Burakov
@ 2018-04-17 10:14 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2018-04-17 10:14 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: dev
13/04/2018 17:58, Anatoly Burakov:
> We lock the hotplug during init, but do not unlock it if we couldn't
> register multiprocess callbacks. Add the missing unlock.
>
> Fixes: 07dcbfe0101f ("malloc: support multiprocess memory hotplug")
> Cc: anatoly.burakov@intel.com
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-17 10:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-13 15:58 [PATCH] malloc: fix not unlocking hotplug on fail to init Anatoly Burakov
2018-04-17 10:14 ` Thomas Monjalon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.