From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v3 10/20] drm: omapdrm: Only commit planes on active CRTCs Date: Tue, 20 Sep 2016 16:51:11 +0300 Message-ID: <9d5edf00-564c-63d6-809f-16cef6f4895c@ti.com> References: <1474288063-5315-1-git-send-email-laurent.pinchart@ideasonboard.com> <1474288063-5315-11-git-send-email-laurent.pinchart@ideasonboard.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1423525523==" Return-path: Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by gabe.freedesktop.org (Postfix) with ESMTPS id 541EC6E6CE for ; Tue, 20 Sep 2016 13:51:18 +0000 (UTC) In-Reply-To: <1474288063-5315-11-git-send-email-laurent.pinchart@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1423525523== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Qu2kHpM1qL5MSEEQJI2d7G5XFtfjGo2oX" --Qu2kHpM1qL5MSEEQJI2d7G5XFtfjGo2oX Content-Type: multipart/mixed; boundary="PFswqR9vQ4I0jDDD3l1rGXM3ut8eMQK5X"; protected-headers="v1" From: Tomi Valkeinen To: Laurent Pinchart , dri-devel@lists.freedesktop.org Message-ID: <9d5edf00-564c-63d6-809f-16cef6f4895c@ti.com> Subject: Re: [PATCH v3 10/20] drm: omapdrm: Only commit planes on active CRTCs References: <1474288063-5315-1-git-send-email-laurent.pinchart@ideasonboard.com> <1474288063-5315-11-git-send-email-laurent.pinchart@ideasonboard.com> In-Reply-To: <1474288063-5315-11-git-send-email-laurent.pinchart@ideasonboard.com> --PFswqR9vQ4I0jDDD3l1rGXM3ut8eMQK5X Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 19/09/16 15:27, Laurent Pinchart wrote: > The DRM core supports skipping plane update for inactive CRTCs for > hardware that don't need it or can't cope with it. That's our case, so > use the DRM core infrastructure instead of reinventing it. I don't follow this desc. What is omapdrm reinventing? At least this patch does not remove any of the "reinvention". What does DRM_PLANE_COMMIT_ACTIVE_ONLY do? Skips plane HW configuration for planes on crtcs that are disabled? The plane HW config will still be done when the crtc is about to be enabled, right? Tomi --PFswqR9vQ4I0jDDD3l1rGXM3ut8eMQK5X-- --Qu2kHpM1qL5MSEEQJI2d7G5XFtfjGo2oX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX4T7PAAoJEPo9qoy8lh71P0gP/ju/d/suuAb6r/iaO+J0FTF2 6CjEvGXrTyemmIR8FMVDU+XasR2Zuv1miNFCYXTMS7qJXB1YRCAzKw4zfFCoTAlj SA67Kmb7NpFDr8eDluduWsxvhO2NnENXHNgMaTUS7Dlr9L2sCNxA+MK2UzWuBiCU MVyEVgT2KEZ03+hdAZeaCccQ0o11/oKC9DDKdNx3yC0Egnhn7ngDJRYz4HtvwcR9 b6TH3qtJGEzumUulsSx8kCr4OcZO8yg2xm4DF0d0vstU8hPjfmMwZ/pY4IdmGaDd 8TMiz6b9WKVpXsSnNKC7amCP9LGN4reS7FXZ24PBiXjQcFaob07d+UVsS1bptphT ejNG08e5oiyDoPqQrMfY8/gZwNDZuDR2cwdiPepYXMI8pSZqjyLb1GRpTq3y11HA GspwdKG4AGc7llaZS7WigrLAYT+89306l7ZYW3n9E6mVEEUtzTkztVInVBs3NXYE ofDfD6LeaAoK19+8qy6vO2j05djjWOF0pnAax3DVnWfKTdhMEoUbb5FsqxHIUxR0 C2e328CrxRdkCnuBhK0ivN1OtpoH2/6fWvS9tLS4Idk+IO5RQ5j/enykEF+Ig/1R +02iuDbs4O3XLkYzlG14zbdWseHYBhLB2hiOcc0YKAeIRaJNZO0YqV1hh0PVQtEA o/b4kJI+i9rlvcIJmzSH =k+Rl -----END PGP SIGNATURE----- --Qu2kHpM1qL5MSEEQJI2d7G5XFtfjGo2oX-- --===============1423525523== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1423525523==--