From: David Ahern <dsahern@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>, netdev@vger.kernel.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 2/2] genl: ctrl: support dumping netlink policy
Date: Mon, 24 Aug 2020 10:54:50 -0600 [thread overview]
Message-ID: <9d6372e5-66cd-6313-5302-5306a4cc8686@gmail.com> (raw)
In-Reply-To: <251b824ef444ee46fb199b7e650f077fb7f682ea.camel@sipsolutions.net>
On 8/24/20 1:54 AM, Johannes Berg wrote:
> Arguably, pretty much all of the code here should go into libnetlink
> then, since the kernel facility was expressly written in a way that
> would allow dumping out arbitrary (not just generic netlink) policies,
> just needs wiring up in the appropriate netlink family (or perhaps some
> additional "policy netlink" family?)
good point.
>
> I can make that change, but I sort of assumed it'd be nicer to do that
> when someone else actually picked it up.
I think it would be better to put this into libnetlink from the start.
prev parent reply other threads:[~2020-08-24 16:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 10:29 [PATCH 1/2] libnetlink: add rtattr_for_each_nested() iteration macro Johannes Berg
2020-08-19 10:29 ` [PATCH 2/2] genl: ctrl: support dumping netlink policy Johannes Berg
2020-08-24 1:45 ` David Ahern
2020-08-24 7:54 ` Johannes Berg
2020-08-24 16:54 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d6372e5-66cd-6313-5302-5306a4cc8686@gmail.com \
--to=dsahern@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.