From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EB50C11F65 for ; Wed, 30 Jun 2021 12:18:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E98661997 for ; Wed, 30 Jun 2021 12:18:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E98661997 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=dh-electronics.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iZmhQmKomSzxj+CQwk6xxpcVxudEJZMa6UyToDvj/Xk=; b=RrZtAm7duHQ8et 1xY+J9P2S61Hn568aaVPJ5MGIY0hlaXynG6Tusy7hys60TZUl7/DAMCQ5fE3Jw1rKg2ysvvPW1/eZ Jdw79Q0o4B82XlNxSbvV+SGuxegBcEMwP3BWesVwXvMV6ka5tTZRe9jt1caQ99rum59Dhf/q/IPv1 X13/QymkU+WLYmC2xwNS/1PPtMSSElTR7k5n6vWdavexDtPsDk1/Cm8V2YNaOLxxEn+PdaJO9ihNB 1296KXpohRLNu+iA9vQWUpQ0Dbt1LYbwPNtdZmcTho1k3ejid259VTKeEIbNEWpsTqhGEvP3TlO9W wFGtZOQJwgZePVMfpwLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyZ9I-00DovV-MS; Wed, 30 Jun 2021 12:17:00 +0000 Received: from mx2.securetransport.de ([2a03:4000:13:6c7::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyZ9C-00Dosi-Ct for linux-arm-kernel@lists.infradead.org; Wed, 30 Jun 2021 12:16:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1625055396; bh=ymo5bzgqRT2KyQcqHSKdsSawmyiXBw7v6HyZ7S4tn6U=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=P/e5FLtrsfFTOC9pJfa+6Zux+g+A0vHQ9dnLicZNmk7X5nqX4uDoMlI32lxQcFrdm 2nuRh5v8SQ4Fm8Eg6xAHl30V3lUho0/vlmnlet+3e0S8VKgk/T0iGT+p6XVMGLjS1k Xla6KB3NdJurGCuANtuz+A1sfEwHszBkhHD8/SdxNj/JjuB6XRS1Lq8/w7Lfe/tqaf sZOoJkz0FwqRMkc6IeP0+whTEwRBfQZazApkIleErFCaDESY+0dnDcDXVubPDt9o2V dnKmwXFnAGbCwESafhyL4JEHxRtERSHGwLi57qMyhBt9MXYf15m8MqwZhSzVvAJ7rw ilcTJn7so63xg== X-secureTransport-forwarded: yes From: Christoph Niedermaier Complaints-To: abuse@cubewerk.de To: "Marek MV. Vasut" , "linux-arm-kernel@lists.infradead.org" CC: Shawn Guo , Fabio Estevam , "NXP Linux Team" , kernel Subject: RE: [PATCH V4 06/15] ARM: dts: imx6q-dhcom: Add keys and leds to the PDK2 board Thread-Topic: [PATCH V4 06/15] ARM: dts: imx6q-dhcom: Add keys and leds to the PDK2 board Thread-Index: AQHXbO6JxMqyxRup1EygRfoFLxhQVqsq9l+AgAGCptA= Date: Wed, 30 Jun 2021 12:16:27 +0000 Message-ID: <9d662d2c215d460bb6dde4e7335249cb@dh-electronics.com> References: <20210629135612.60695-1-cniedermaier@dh-electronics.com> <20210629135612.60695-6-cniedermaier@dh-electronics.com> <94d8297d-6453-cd46-8b89-c6b4c2528698@denx.de> In-Reply-To: <94d8297d-6453-cd46-8b89-c6b4c2528698@denx.de> Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210630_051654_652209_EE279768 X-CRM114-Status: GOOD ( 12.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Marek Vasut [mailto:marex@denx.de] Sent: Tuesday, June 29, 2021 5:10 PM > On 6/29/21 3:56 PM, Christoph Niedermaier wrote: > > [...] > >> diff --git a/arch/arm/boot/dts/imx6q-dhcom-pdk2.dts b/arch/arm/boot/dts/imx6q-dhcom-pdk2.dts >> index 6bb7129d0498..ff794a77c5db 100644 >> --- a/arch/arm/boot/dts/imx6q-dhcom-pdk2.dts >> +++ b/arch/arm/boot/dts/imx6q-dhcom-pdk2.dts > > [...] > >> + led { >> + compatible = "gpio-leds"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_leds_pdk2>; >> + >> + /* >> + * Disable led-5, because GPIO E is >> + * already used as touch interrupt. >> + */ >> + led-5 { >> + color = ; >> + function = LED_FUNCTION_INDICATOR; >> + gpios = <&gpio4 5 GPIO_ACTIVE_HIGH>; /* GPIO E */ >> + default-state = "off"; >> + status = "disabled"; >> + }; > > [...] > >> diff --git a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi >> index c5c060c6b9bf..68ac29d28f4f 100644 >> --- a/arch/arm/boot/dts/imx6q-dhcom-som.dtsi >> +++ b/arch/arm/boot/dts/imx6q-dhcom-som.dtsi >> @@ -9,6 +9,7 @@ >> #include >> #include >> #include >> +#include > > The LEDs are optionally present on some of the carrier boards, so this > header should be included in the carrier board .dts file I think. Thanks, will fix this in version 5. Regards Christoph _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel