From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Date: Wed, 03 Apr 2019 13:49:26 +0000 Subject: Re: [PATCH 2/2] arch: add pidfd and io_uring syscalls everywhere Message-Id: <9d673dfd-0051-3676-653e-6376430d73dd@kernel.dk> List-Id: References: <20190325143521.34928-1-arnd@arndb.de> <20190325144737.703921-1-arnd@arndb.de> <87tvff24a1.fsf@concordia.ellerman.id.au> <20190403111134.GA7159@fuggles.cambridge.arm.com> In-Reply-To: <20190403111134.GA7159@fuggles.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Will Deacon , Michael Ellerman Cc: Rich Felker , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Benjamin Herrenschmidt , Heiko Carstens , linux-mips@vger.kernel.org, "James E . J . Bottomley" , Max Filippov , Paul Mackerras , sparclinux@vger.kernel.org, linux-s390@vger.kernel.org, Helge Deller , Russell King , Geert Uytterhoeven , Catalin Marinas , James Hogan , Firoz Khan , Matt Turner , Fenghua Yu , Arnd Bergmann , linux-m68k@lists.linux-m68k.org, Ivan Kokshaysky , linux-arm-kernel@lists.infradead.org, Richard Henderson , Michal Simek , Tony Luck , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Ralf Baechle , Paul Burton , linux-alpha@vger.kernel.org, Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" On 4/3/19 5:11 AM, Will Deacon wrote: > Hi Michael, > > On Wed, Apr 03, 2019 at 01:47:50PM +1100, Michael Ellerman wrote: >> Arnd Bergmann writes: >>> diff --git a/arch/powerpc/kernel/syscalls/syscall.tbl b/arch/powerpc/kernel/syscalls/syscall.tbl >>> index b18abb0c3dae..00f5a63c8d9a 100644 >>> --- a/arch/powerpc/kernel/syscalls/syscall.tbl >>> +++ b/arch/powerpc/kernel/syscalls/syscall.tbl >>> @@ -505,3 +505,7 @@ >>> 421 32 rt_sigtimedwait_time64 sys_rt_sigtimedwait compat_sys_rt_sigtimedwait_time64 >>> 422 32 futex_time64 sys_futex sys_futex >>> 423 32 sched_rr_get_interval_time64 sys_sched_rr_get_interval sys_sched_rr_get_interval >>> +424 common pidfd_send_signal sys_pidfd_send_signal >>> +425 common io_uring_setup sys_io_uring_setup >>> +426 common io_uring_enter sys_io_uring_enter >>> +427 common io_uring_register sys_io_uring_register >> >> Acked-by: Michael Ellerman (powerpc) >> >> Lightly tested. >> >> The pidfd_test selftest passes. > > That reports pass for me too, although it fails to unshare the pid ns, which I > assume is benign. > >> Ran the io_uring example from fio, which prints lots of: > > How did you invoke that? I had a play with the tests in: It's t/io_uring from the fio repo: git://git.kernel.dk/fio and you just run it ala: # make t/io_uring # t/io_uring /dev/some_device > git://git.kernel.dk/liburing > > but I quickly ran into the kernel oops below. > > Will > > --->8 > > will@autoplooker:~/liburing/test$ ./io_uring_register > RELIMIT_MEMLOCK: 67108864 (67108864) > [ 35.477875] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000070 > [ 35.478969] Mem abort info: > [ 35.479296] ESR = 0x96000004 > [ 35.479785] Exception class = DABT (current EL), IL = 32 bits > [ 35.480528] SET = 0, FnV = 0 > [ 35.480980] EA = 0, S1PTW = 0 > [ 35.481345] Data abort info: > [ 35.481680] ISV = 0, ISS = 0x00000004 > [ 35.482267] CM = 0, WnR = 0 > [ 35.482618] user pgtable: 4k pages, 48-bit VAs, pgdp = (____ptrval____) > [ 35.483486] [0000000000000070] pgd00000000000000 > [ 35.484041] Internal error: Oops: 96000004 [#1] PREEMPT SMP > [ 35.484788] Modules linked in: > [ 35.485311] CPU: 113 PID: 3973 Comm: io_uring_regist Not tainted 5.1.0-rc3-00012-g40b114779944 #1 > [ 35.486712] Hardware name: linux,dummy-virt (DT) > [ 35.487450] pstate: 20400005 (nzCv daif +PAN -UAO) > [ 35.488228] pc : link_pwq+0x10/0x60 > [ 35.488794] lr : apply_wqattrs_commit+0xe0/0x118 > [ 35.489550] sp : ffff000017e2bbc0 Huh, this looks odd, it's crashing inside the wq setup. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 092CAC4360F for ; Wed, 3 Apr 2019 13:49:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C329020700 for ; Wed, 3 Apr 2019 13:49:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="a+09Q+zu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726157AbfDCNtd (ORCPT ); Wed, 3 Apr 2019 09:49:33 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:44122 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726193AbfDCNtd (ORCPT ); Wed, 3 Apr 2019 09:49:33 -0400 Received: by mail-pf1-f195.google.com with SMTP id y13so8183679pfm.11 for ; Wed, 03 Apr 2019 06:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=t5ZVVI/5i5BZgbC0+BF4FpeyupPsSZBs0qT2dr3BKsI=; b=a+09Q+zugRlUHjkyucJBUCWf446/MQuUX5HgeGs3ZuGQQLIWjJL4mBRQrPd8Bx1buN pS4R4TpqP3XhVpa6S7zs10taoPdLsT7v+9IuXra/Uik1YcsijFXT7lR/UJiVHpj8asQt ZKI61os4qE1ceMgeeCWS8eeEqFOYcwVarDSKzOrfLlnJyc5wRdlnXGw37CR8OlhLZqnf yHVyoaWIHJpz8YliG/fKTjFH1niDFOpAo/QavcioqNac4ds3tqnSs5/kTVDh1j1rvHJs S0B+dWgq7An+aJLx8NTQYB7UoUjMFTNUGB972txZpMDJCgnpUlYul4Q6ZsTAr8wNltER O/0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=t5ZVVI/5i5BZgbC0+BF4FpeyupPsSZBs0qT2dr3BKsI=; b=d+8H6aiRX/djT4t2Nu0JrHWvq7xp0lFB7ixPYi9PAla2V7Xw6Rf0JBFD9h6Pgmy5WS AOtZIYj23a2wBBekg1R3eXwGOlZLr9ofOzsl3iNwaXj7+thBxL3Q7ga6Q0GiIUclmPgT 7wsmC9bKigXte0tdGAuwd9WM5ORYGa/SzRDTFeKn8BxPPSKlVT6UD8bzvwF4XfahlJvn wYkUxsfYaNkm5lLM8HSMU2QmfaFgKXkMxGD3b9Na5VQPFIafcQ5rVEVNrzYyFN9hB7o+ GvFjfsxno4blz1P19hZdLSSnWvsNTZmFBbEWgUiSQ9IR/7c7oDNX9He1gY0+cEmyNjZK nJ1Q== X-Gm-Message-State: APjAAAUAWs245Ni8Nk5bDY4In6VNCLGV8ITg7Pz/ck7jgwc5CeMg9MdE YMkuuOEYcpihuuj9uHjoPUwY/A== X-Google-Smtp-Source: APXvYqzl4pp2LVq+nDJhXTBECl1hQPThxVc/ItK+ZQpXYL1XB54jwn23RYPTMUJAYmiOOJU/yQZx8A== X-Received: by 2002:a62:2687:: with SMTP id m129mr25296327pfm.204.1554299372295; Wed, 03 Apr 2019 06:49:32 -0700 (PDT) Received: from [192.168.1.121] (66.29.188.166.static.utbb.net. [66.29.188.166]) by smtp.gmail.com with ESMTPSA id g2sm22691245pfd.134.2019.04.03.06.49.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Apr 2019 06:49:30 -0700 (PDT) Subject: Re: [PATCH 2/2] arch: add pidfd and io_uring syscalls everywhere To: Will Deacon , Michael Ellerman Cc: Arnd Bergmann , Andrew Morton , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Catalin Marinas , Tony Luck , Fenghua Yu , Geert Uytterhoeven , Michal Simek , Ralf Baechle , Paul Burton , James Hogan , "James E . J . Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , Rich Felker , "David S . Miller" , Max Filippov , Firoz Khan , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org References: <20190325143521.34928-1-arnd@arndb.de> <20190325144737.703921-1-arnd@arndb.de> <87tvff24a1.fsf@concordia.ellerman.id.au> <20190403111134.GA7159@fuggles.cambridge.arm.com> From: Jens Axboe Message-ID: <9d673dfd-0051-3676-653e-6376430d73dd@kernel.dk> Date: Wed, 3 Apr 2019 07:49:26 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190403111134.GA7159@fuggles.cambridge.arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On 4/3/19 5:11 AM, Will Deacon wrote: > Hi Michael, > > On Wed, Apr 03, 2019 at 01:47:50PM +1100, Michael Ellerman wrote: >> Arnd Bergmann writes: >>> diff --git a/arch/powerpc/kernel/syscalls/syscall.tbl b/arch/powerpc/kernel/syscalls/syscall.tbl >>> index b18abb0c3dae..00f5a63c8d9a 100644 >>> --- a/arch/powerpc/kernel/syscalls/syscall.tbl >>> +++ b/arch/powerpc/kernel/syscalls/syscall.tbl >>> @@ -505,3 +505,7 @@ >>> 421 32 rt_sigtimedwait_time64 sys_rt_sigtimedwait compat_sys_rt_sigtimedwait_time64 >>> 422 32 futex_time64 sys_futex sys_futex >>> 423 32 sched_rr_get_interval_time64 sys_sched_rr_get_interval sys_sched_rr_get_interval >>> +424 common pidfd_send_signal sys_pidfd_send_signal >>> +425 common io_uring_setup sys_io_uring_setup >>> +426 common io_uring_enter sys_io_uring_enter >>> +427 common io_uring_register sys_io_uring_register >> >> Acked-by: Michael Ellerman (powerpc) >> >> Lightly tested. >> >> The pidfd_test selftest passes. > > That reports pass for me too, although it fails to unshare the pid ns, which I > assume is benign. > >> Ran the io_uring example from fio, which prints lots of: > > How did you invoke that? I had a play with the tests in: It's t/io_uring from the fio repo: git://git.kernel.dk/fio and you just run it ala: # make t/io_uring # t/io_uring /dev/some_device > git://git.kernel.dk/liburing > > but I quickly ran into the kernel oops below. > > Will > > --->8 > > will@autoplooker:~/liburing/test$ ./io_uring_register > RELIMIT_MEMLOCK: 67108864 (67108864) > [ 35.477875] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000070 > [ 35.478969] Mem abort info: > [ 35.479296] ESR = 0x96000004 > [ 35.479785] Exception class = DABT (current EL), IL = 32 bits > [ 35.480528] SET = 0, FnV = 0 > [ 35.480980] EA = 0, S1PTW = 0 > [ 35.481345] Data abort info: > [ 35.481680] ISV = 0, ISS = 0x00000004 > [ 35.482267] CM = 0, WnR = 0 > [ 35.482618] user pgtable: 4k pages, 48-bit VAs, pgdp = (____ptrval____) > [ 35.483486] [0000000000000070] pgd=0000000000000000 > [ 35.484041] Internal error: Oops: 96000004 [#1] PREEMPT SMP > [ 35.484788] Modules linked in: > [ 35.485311] CPU: 113 PID: 3973 Comm: io_uring_regist Not tainted 5.1.0-rc3-00012-g40b114779944 #1 > [ 35.486712] Hardware name: linux,dummy-virt (DT) > [ 35.487450] pstate: 20400005 (nzCv daif +PAN -UAO) > [ 35.488228] pc : link_pwq+0x10/0x60 > [ 35.488794] lr : apply_wqattrs_commit+0xe0/0x118 > [ 35.489550] sp : ffff000017e2bbc0 Huh, this looks odd, it's crashing inside the wq setup. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 2/2] arch: add pidfd and io_uring syscalls everywhere References: <20190325143521.34928-1-arnd@arndb.de> <20190325144737.703921-1-arnd@arndb.de> <87tvff24a1.fsf@concordia.ellerman.id.au> <20190403111134.GA7159@fuggles.cambridge.arm.com> From: Jens Axboe Message-ID: <9d673dfd-0051-3676-653e-6376430d73dd@kernel.dk> Date: Wed, 3 Apr 2019 07:49:26 -0600 MIME-Version: 1.0 In-Reply-To: <20190403111134.GA7159@fuggles.cambridge.arm.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org List-Archive: To: Will Deacon , Michael Ellerman Cc: Rich Felker , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Benjamin Herrenschmidt , Heiko Carstens , linux-mips@vger.kernel.org, "James E . J . Bottomley" , Max Filippov , Paul Mackerras , sparclinux@vger.kernel.org, linux-s390@vger.kernel.org, Helge Deller , Russell King , Geert Uytterhoeven , Catalin Marinas , James Hogan , Firoz Khan , Matt Turner , Fenghua Yu , Arnd Bergmann , linux-m68k@lists.linux-m68k.org, Ivan Kokshaysky , linux-arm-kernel@lists.infradead.org, Richard Henderson , Michal Simek , Tony Luck , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Ralf Baechle , Paul Burton , linux-alpha@vger.kernel.org, Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" List-ID: On 4/3/19 5:11 AM, Will Deacon wrote: > Hi Michael, > > On Wed, Apr 03, 2019 at 01:47:50PM +1100, Michael Ellerman wrote: >> Arnd Bergmann writes: >>> diff --git a/arch/powerpc/kernel/syscalls/syscall.tbl b/arch/powerpc/kernel/syscalls/syscall.tbl >>> index b18abb0c3dae..00f5a63c8d9a 100644 >>> --- a/arch/powerpc/kernel/syscalls/syscall.tbl >>> +++ b/arch/powerpc/kernel/syscalls/syscall.tbl >>> @@ -505,3 +505,7 @@ >>> 421 32 rt_sigtimedwait_time64 sys_rt_sigtimedwait compat_sys_rt_sigtimedwait_time64 >>> 422 32 futex_time64 sys_futex sys_futex >>> 423 32 sched_rr_get_interval_time64 sys_sched_rr_get_interval sys_sched_rr_get_interval >>> +424 common pidfd_send_signal sys_pidfd_send_signal >>> +425 common io_uring_setup sys_io_uring_setup >>> +426 common io_uring_enter sys_io_uring_enter >>> +427 common io_uring_register sys_io_uring_register >> >> Acked-by: Michael Ellerman (powerpc) >> >> Lightly tested. >> >> The pidfd_test selftest passes. > > That reports pass for me too, although it fails to unshare the pid ns, which I > assume is benign. > >> Ran the io_uring example from fio, which prints lots of: > > How did you invoke that? I had a play with the tests in: It's t/io_uring from the fio repo: git://git.kernel.dk/fio and you just run it ala: # make t/io_uring # t/io_uring /dev/some_device > git://git.kernel.dk/liburing > > but I quickly ran into the kernel oops below. > > Will > > --->8 > > will@autoplooker:~/liburing/test$ ./io_uring_register > RELIMIT_MEMLOCK: 67108864 (67108864) > [ 35.477875] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000070 > [ 35.478969] Mem abort info: > [ 35.479296] ESR = 0x96000004 > [ 35.479785] Exception class = DABT (current EL), IL = 32 bits > [ 35.480528] SET = 0, FnV = 0 > [ 35.480980] EA = 0, S1PTW = 0 > [ 35.481345] Data abort info: > [ 35.481680] ISV = 0, ISS = 0x00000004 > [ 35.482267] CM = 0, WnR = 0 > [ 35.482618] user pgtable: 4k pages, 48-bit VAs, pgdp = (____ptrval____) > [ 35.483486] [0000000000000070] pgd=0000000000000000 > [ 35.484041] Internal error: Oops: 96000004 [#1] PREEMPT SMP > [ 35.484788] Modules linked in: > [ 35.485311] CPU: 113 PID: 3973 Comm: io_uring_regist Not tainted 5.1.0-rc3-00012-g40b114779944 #1 > [ 35.486712] Hardware name: linux,dummy-virt (DT) > [ 35.487450] pstate: 20400005 (nzCv daif +PAN -UAO) > [ 35.488228] pc : link_pwq+0x10/0x60 > [ 35.488794] lr : apply_wqattrs_commit+0xe0/0x118 > [ 35.489550] sp : ffff000017e2bbc0 Huh, this looks odd, it's crashing inside the wq setup. -- Jens Axboe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CED0CC4360F for ; Wed, 3 Apr 2019 13:51:32 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F37D72084B for ; Wed, 3 Apr 2019 13:51:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="a+09Q+zu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F37D72084B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44Z6tn4vXbzDqMF for ; Thu, 4 Apr 2019 00:51:29 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=kernel.dk (client-ip=2607:f8b0:4864:20::541; helo=mail-pg1-x541.google.com; envelope-from=axboe@kernel.dk; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="a+09Q+zu"; dkim-atps=neutral Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44Z6rh4tFJzDqKZ for ; Thu, 4 Apr 2019 00:49:35 +1100 (AEDT) Received: by mail-pg1-x541.google.com with SMTP id 85so8372544pgc.3 for ; Wed, 03 Apr 2019 06:49:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=t5ZVVI/5i5BZgbC0+BF4FpeyupPsSZBs0qT2dr3BKsI=; b=a+09Q+zugRlUHjkyucJBUCWf446/MQuUX5HgeGs3ZuGQQLIWjJL4mBRQrPd8Bx1buN pS4R4TpqP3XhVpa6S7zs10taoPdLsT7v+9IuXra/Uik1YcsijFXT7lR/UJiVHpj8asQt ZKI61os4qE1ceMgeeCWS8eeEqFOYcwVarDSKzOrfLlnJyc5wRdlnXGw37CR8OlhLZqnf yHVyoaWIHJpz8YliG/fKTjFH1niDFOpAo/QavcioqNac4ds3tqnSs5/kTVDh1j1rvHJs S0B+dWgq7An+aJLx8NTQYB7UoUjMFTNUGB972txZpMDJCgnpUlYul4Q6ZsTAr8wNltER O/0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=t5ZVVI/5i5BZgbC0+BF4FpeyupPsSZBs0qT2dr3BKsI=; b=P5f+E034TftG/fbmqCJwuKggELQ9WrqYz6qdlOZx6pubkB8CA2MDtNusvAt7zushDk vIv2Zz1BIEJWgeU6jSvM/qXP8O9YVD3S+fX+s/CWzAwkZvgUiEW5H8f4ogQpc8RimaDh mDLE150N6lEwlX+VomOcjlx7+f2/NX8RSDmz2xh83lJH6u4IZYuB4MAgwQhILMgClWr/ XjLoDXKfSI8yJujvn5n9A51t//RvrTezhBj4GdQ/1lLEvNEh6dpEAgwbhAa7Bvnv2llC IaQPOUE3bEhJFwTI6DFelm5HqfS804zjrwAiK+YvbhEznIN7V3lf+2oKbc/SzQuga2v9 Pa7w== X-Gm-Message-State: APjAAAWY32j4NKqTFwJjL6QhdPuRk/bsIX9YR+RzEWlGvFXX6eGgeVOR Hy8EJ+AnJwpP5hgqaOJw0uv0FQ== X-Google-Smtp-Source: APXvYqzl4pp2LVq+nDJhXTBECl1hQPThxVc/ItK+ZQpXYL1XB54jwn23RYPTMUJAYmiOOJU/yQZx8A== X-Received: by 2002:a62:2687:: with SMTP id m129mr25296327pfm.204.1554299372295; Wed, 03 Apr 2019 06:49:32 -0700 (PDT) Received: from [192.168.1.121] (66.29.188.166.static.utbb.net. [66.29.188.166]) by smtp.gmail.com with ESMTPSA id g2sm22691245pfd.134.2019.04.03.06.49.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Apr 2019 06:49:30 -0700 (PDT) Subject: Re: [PATCH 2/2] arch: add pidfd and io_uring syscalls everywhere To: Will Deacon , Michael Ellerman References: <20190325143521.34928-1-arnd@arndb.de> <20190325144737.703921-1-arnd@arndb.de> <87tvff24a1.fsf@concordia.ellerman.id.au> <20190403111134.GA7159@fuggles.cambridge.arm.com> From: Jens Axboe Message-ID: <9d673dfd-0051-3676-653e-6376430d73dd@kernel.dk> Date: Wed, 3 Apr 2019 07:49:26 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190403111134.GA7159@fuggles.cambridge.arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Heiko Carstens , linux-mips@vger.kernel.org, "James E . J . Bottomley" , Max Filippov , Paul Mackerras , sparclinux@vger.kernel.org, linux-s390@vger.kernel.org, Helge Deller , Russell King , Geert Uytterhoeven , Catalin Marinas , James Hogan , Firoz Khan , Matt Turner , Fenghua Yu , Arnd Bergmann , linux-m68k@lists.linux-m68k.org, Ivan Kokshaysky , linux-arm-kernel@lists.infradead.org, Richard Henderson , Michal Simek , Tony Luck , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Ralf Baechle , Paul Burton , linux-alpha@vger.kernel.org, Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S . Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 4/3/19 5:11 AM, Will Deacon wrote: > Hi Michael, > > On Wed, Apr 03, 2019 at 01:47:50PM +1100, Michael Ellerman wrote: >> Arnd Bergmann writes: >>> diff --git a/arch/powerpc/kernel/syscalls/syscall.tbl b/arch/powerpc/kernel/syscalls/syscall.tbl >>> index b18abb0c3dae..00f5a63c8d9a 100644 >>> --- a/arch/powerpc/kernel/syscalls/syscall.tbl >>> +++ b/arch/powerpc/kernel/syscalls/syscall.tbl >>> @@ -505,3 +505,7 @@ >>> 421 32 rt_sigtimedwait_time64 sys_rt_sigtimedwait compat_sys_rt_sigtimedwait_time64 >>> 422 32 futex_time64 sys_futex sys_futex >>> 423 32 sched_rr_get_interval_time64 sys_sched_rr_get_interval sys_sched_rr_get_interval >>> +424 common pidfd_send_signal sys_pidfd_send_signal >>> +425 common io_uring_setup sys_io_uring_setup >>> +426 common io_uring_enter sys_io_uring_enter >>> +427 common io_uring_register sys_io_uring_register >> >> Acked-by: Michael Ellerman (powerpc) >> >> Lightly tested. >> >> The pidfd_test selftest passes. > > That reports pass for me too, although it fails to unshare the pid ns, which I > assume is benign. > >> Ran the io_uring example from fio, which prints lots of: > > How did you invoke that? I had a play with the tests in: It's t/io_uring from the fio repo: git://git.kernel.dk/fio and you just run it ala: # make t/io_uring # t/io_uring /dev/some_device > git://git.kernel.dk/liburing > > but I quickly ran into the kernel oops below. > > Will > > --->8 > > will@autoplooker:~/liburing/test$ ./io_uring_register > RELIMIT_MEMLOCK: 67108864 (67108864) > [ 35.477875] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000070 > [ 35.478969] Mem abort info: > [ 35.479296] ESR = 0x96000004 > [ 35.479785] Exception class = DABT (current EL), IL = 32 bits > [ 35.480528] SET = 0, FnV = 0 > [ 35.480980] EA = 0, S1PTW = 0 > [ 35.481345] Data abort info: > [ 35.481680] ISV = 0, ISS = 0x00000004 > [ 35.482267] CM = 0, WnR = 0 > [ 35.482618] user pgtable: 4k pages, 48-bit VAs, pgdp = (____ptrval____) > [ 35.483486] [0000000000000070] pgd=0000000000000000 > [ 35.484041] Internal error: Oops: 96000004 [#1] PREEMPT SMP > [ 35.484788] Modules linked in: > [ 35.485311] CPU: 113 PID: 3973 Comm: io_uring_regist Not tainted 5.1.0-rc3-00012-g40b114779944 #1 > [ 35.486712] Hardware name: linux,dummy-virt (DT) > [ 35.487450] pstate: 20400005 (nzCv daif +PAN -UAO) > [ 35.488228] pc : link_pwq+0x10/0x60 > [ 35.488794] lr : apply_wqattrs_commit+0xe0/0x118 > [ 35.489550] sp : ffff000017e2bbc0 Huh, this looks odd, it's crashing inside the wq setup. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 2/2] arch: add pidfd and io_uring syscalls everywhere Date: Wed, 3 Apr 2019 07:49:26 -0600 Message-ID: <9d673dfd-0051-3676-653e-6376430d73dd@kernel.dk> References: <20190325143521.34928-1-arnd@arndb.de> <20190325144737.703921-1-arnd@arndb.de> <87tvff24a1.fsf@concordia.ellerman.id.au> <20190403111134.GA7159@fuggles.cambridge.arm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=t5ZVVI/5i5BZgbC0+BF4FpeyupPsSZBs0qT2dr3BKsI=; b=a+09Q+zugRlUHjkyucJBUCWf446/MQuUX5HgeGs3ZuGQQLIWjJL4mBRQrPd8Bx1buN pS4R4TpqP3XhVpa6S7zs10taoPdLsT7v+9IuXra/Uik1YcsijFXT7lR/UJiVHpj8asQt ZKI61os4qE1ceMgeeCWS8eeEqFOYcwVarDSKzOrfLlnJyc5wRdlnXGw37CR8OlhLZqnf yHVyoaWIHJpz8YliG/fKTjFH1niDFOpAo/QavcioqNac4ds3tqnSs5/kTVDh1j1rvHJs S0B+dWgq7An+aJLx8NTQYB7UoUjMFTNUGB972txZpMDJCgnpUlYul4Q6ZsTAr8wNltER O/0Q== In-Reply-To: <20190403111134.GA7159@fuggles.cambridge.arm.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Will Deacon , Michael Ellerman Cc: Arnd Bergmann , Andrew Morton , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Catalin Marinas , Tony Luck , Fenghua Yu , Geert Uytterhoeven , Michal Simek , Ralf Baechle , Paul Burton , James Hogan , "James E . J . Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , Martin Schwidefsky On 4/3/19 5:11 AM, Will Deacon wrote: > Hi Michael, > > On Wed, Apr 03, 2019 at 01:47:50PM +1100, Michael Ellerman wrote: >> Arnd Bergmann writes: >>> diff --git a/arch/powerpc/kernel/syscalls/syscall.tbl b/arch/powerpc/kernel/syscalls/syscall.tbl >>> index b18abb0c3dae..00f5a63c8d9a 100644 >>> --- a/arch/powerpc/kernel/syscalls/syscall.tbl >>> +++ b/arch/powerpc/kernel/syscalls/syscall.tbl >>> @@ -505,3 +505,7 @@ >>> 421 32 rt_sigtimedwait_time64 sys_rt_sigtimedwait compat_sys_rt_sigtimedwait_time64 >>> 422 32 futex_time64 sys_futex sys_futex >>> 423 32 sched_rr_get_interval_time64 sys_sched_rr_get_interval sys_sched_rr_get_interval >>> +424 common pidfd_send_signal sys_pidfd_send_signal >>> +425 common io_uring_setup sys_io_uring_setup >>> +426 common io_uring_enter sys_io_uring_enter >>> +427 common io_uring_register sys_io_uring_register >> >> Acked-by: Michael Ellerman (powerpc) >> >> Lightly tested. >> >> The pidfd_test selftest passes. > > That reports pass for me too, although it fails to unshare the pid ns, which I > assume is benign. > >> Ran the io_uring example from fio, which prints lots of: > > How did you invoke that? I had a play with the tests in: It's t/io_uring from the fio repo: git://git.kernel.dk/fio and you just run it ala: # make t/io_uring # t/io_uring /dev/some_device > git://git.kernel.dk/liburing > > but I quickly ran into the kernel oops below. > > Will > > --->8 > > will@autoplooker:~/liburing/test$ ./io_uring_register > RELIMIT_MEMLOCK: 67108864 (67108864) > [ 35.477875] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000070 > [ 35.478969] Mem abort info: > [ 35.479296] ESR = 0x96000004 > [ 35.479785] Exception class = DABT (current EL), IL = 32 bits > [ 35.480528] SET = 0, FnV = 0 > [ 35.480980] EA = 0, S1PTW = 0 > [ 35.481345] Data abort info: > [ 35.481680] ISV = 0, ISS = 0x00000004 > [ 35.482267] CM = 0, WnR = 0 > [ 35.482618] user pgtable: 4k pages, 48-bit VAs, pgdp = (____ptrval____) > [ 35.483486] [0000000000000070] pgd=0000000000000000 > [ 35.484041] Internal error: Oops: 96000004 [#1] PREEMPT SMP > [ 35.484788] Modules linked in: > [ 35.485311] CPU: 113 PID: 3973 Comm: io_uring_regist Not tainted 5.1.0-rc3-00012-g40b114779944 #1 > [ 35.486712] Hardware name: linux,dummy-virt (DT) > [ 35.487450] pstate: 20400005 (nzCv daif +PAN -UAO) > [ 35.488228] pc : link_pwq+0x10/0x60 > [ 35.488794] lr : apply_wqattrs_commit+0xe0/0x118 > [ 35.489550] sp : ffff000017e2bbc0 Huh, this looks odd, it's crashing inside the wq setup. -- Jens Axboe