From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5676CC4363D for ; Fri, 25 Sep 2020 13:40:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D4582076D for ; Fri, 25 Sep 2020 13:40:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="cT03BzeJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728551AbgIYNkL (ORCPT ); Fri, 25 Sep 2020 09:40:11 -0400 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:1414 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727982AbgIYNkL (ORCPT ); Fri, 25 Sep 2020 09:40:11 -0400 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 25 Sep 2020 06:39:58 -0700 Received: from [172.27.1.66] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 25 Sep 2020 13:39:56 +0000 Subject: Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages To: Tvrtko Ursulin , Jason Gunthorpe , Leon Romanovsky CC: Christoph Hellwig , Doug Ledford , , , "Roland Scheidegger" , , "David Airlie" , VMware Graphics , Maor Gottlieb References: <20200922083958.2150803-1-leon@kernel.org> <20200922083958.2150803-2-leon@kernel.org> <118a03ef-d160-e202-81cc-16c9c39359fc@linux.intel.com> <20200925071330.GA2280698@unreal> <20200925115544.GY9475@nvidia.com> <65ca566b-7a5e-620f-13a4-c59eb836345a@nvidia.com> <33942b10-8eef-9180-44c5-b7379b92b824@linux.intel.com> From: Maor Gottlieb Message-ID: <9d69d68d-7868-609b-c703-dfe9fec93a0f@nvidia.com> Date: Fri, 25 Sep 2020 16:39:53 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.1 MIME-Version: 1.0 In-Reply-To: <33942b10-8eef-9180-44c5-b7379b92b824@linux.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1601041198; bh=I3MevVq0rfThlib9stYezAlO6VoXyq/abMk8uS5Rf30=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding: Content-Language:X-Originating-IP:X-ClientProxiedBy; b=cT03BzeJw3AnIIrmEndxMyFxZGs1x1e+luerBaV6utLXOQpxqyHE0J35I/xDt+xhQ nR5XsHMTcB0Sg+P7pyDrtOk1sPUxKgkwNxDjh5LrmwZNkflEO0B+KyIXAPtShuGdZp BAkM4kyDxQzdIawJgqR//5croKMPwX5+yyb7UibsGX7XYCgs5+KQQNnOr3xu1koFWo l66mYjr0hXJexrdgIiX4ZJXsHGEllajD/0UevEWQGSQk7XBJszxIYwaFw0yubCntpL oG5dpHOEhdPi1skYh5ja8JQdJ+bII9s7XSD/ihYM9L8T/rsdj8ZZifbMGapnVBN7QJ rq56RmEyRwkhA== Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 9/25/2020 3:33 PM, Tvrtko Ursulin wrote: > > On 25/09/2020 13:18, Maor Gottlieb wrote: >> On 9/25/2020 2:55 PM, Jason Gunthorpe wrote: >>> On Fri, Sep 25, 2020 at 10:13:30AM +0300, Leon Romanovsky wrote: >>>>>> diff --git a/tools/testing/scatterlist/main.c=20 >>>>>> b/tools/testing/scatterlist/main.c >>>>>> index 0a1464181226..4899359a31ac 100644 >>>>>> +++ b/tools/testing/scatterlist/main.c >>>>>> @@ -55,14 +55,13 @@ int main(void) >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 for (i =3D 0, test =3D tests; t= est->expected_segments; test++,=20 >>>>>> i++) { >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct = page *pages[MAX_PAGES]; >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct = sg_table st; >>>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int ret; >>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct scatterlist *sg; >>>>>> >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 set_pag= es(pages, test->pfn, test->num_pages); >>>>>> >>>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ret =3D __sg_alloc_table= _from_pages(&st, pages,=20 >>>>>> test->num_pages, >>>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 0, test->size, test->max_seg, >>>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 GFP_KERNEL); >>>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 assert(ret =3D=3D test->= alloc_ret); >>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 sg =3D __sg_alloc_table_= from_pages(&st, pages,=20 >>>>>> test->num_pages, 0, >>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 test->size, test->max_seg, NULL, 0, GFP_KERNEL); >>>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 assert(PTR_ERR_OR_ZERO(s= g) =3D=3D test->alloc_ret); >>>>> Some test coverage for relatively complex code would be very=20 >>>>> welcomed. Since >>>>> the testing framework is already there, even if it bit-rotted a=20 >>>>> bit, but >>>>> shouldn't be hard to fix. >>>>> >>>>> A few tests to check append/grow works as expected, in terms of=20 >>>>> how the end >>>>> table looks like given the initial state and some different page=20 >>>>> patterns >>>>> added to it. And both crossing and not crossing into sg chaining=20 >>>>> scenarios. >>>> This function is basic for all RDMA devices and we are pretty=20 >>>> confident >>>> that the old and new flows are tested thoroughly. >>> Well, since 0-day is reporting that __i915_gem_userptr_alloc_pages is >>> crashing on this, it probably does need some tests :\ >>> >>> Jason >> >> It is crashing in the regular old flow which already tested. >> However, I will add more tests. > > Do you want to take some of the commits from=20 > git://people.freedesktop.org/~tursulin/drm-intel sgtest? It would be=20 > fine by me. I can clean up the commit messages if you want. I will very appreciate it. Thanks > > https://cgit.freedesktop.org/~tursulin/drm-intel/commit/?h=3Dsgtest&id=3D= 79102f4d795c4769431fc44a6cf7ed5c5b1b5214=20 > - this one undoes the bit rot and makes the test just work on the=20 > current kernel. > > https://cgit.freedesktop.org/~tursulin/drm-intel/commit/?h=3Dsgtest&id=3D= b09bfe80486c4d93ee1d8ae17d5b46397b1c6ee1=20 > - this one you probably should squash in your patch. Minus the zeroing=20 > of struct sg_stable since that would hide the issue. > > https://cgit.freedesktop.org/~tursulin/drm-intel/commit/?h=3Dsgtest&id=3D= 97f5df37e612f798ced90541eece13e2ef639181=20 > - final commit is optional but I guess handy for debugging. > > Regards, > > Tvrtko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83679C47423 for ; Mon, 28 Sep 2020 07:07:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DFFA20789 for ; Mon, 28 Sep 2020 07:07:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="cT03BzeJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DFFA20789 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 288006E334; Mon, 28 Sep 2020 07:06:28 +0000 (UTC) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6B7E46EB29; Fri, 25 Sep 2020 13:40:12 +0000 (UTC) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 25 Sep 2020 06:39:58 -0700 Received: from [172.27.1.66] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 25 Sep 2020 13:39:56 +0000 Subject: Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages To: Tvrtko Ursulin , Jason Gunthorpe , Leon Romanovsky References: <20200922083958.2150803-1-leon@kernel.org> <20200922083958.2150803-2-leon@kernel.org> <118a03ef-d160-e202-81cc-16c9c39359fc@linux.intel.com> <20200925071330.GA2280698@unreal> <20200925115544.GY9475@nvidia.com> <65ca566b-7a5e-620f-13a4-c59eb836345a@nvidia.com> <33942b10-8eef-9180-44c5-b7379b92b824@linux.intel.com> From: Maor Gottlieb Message-ID: <9d69d68d-7868-609b-c703-dfe9fec93a0f@nvidia.com> Date: Fri, 25 Sep 2020 16:39:53 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.1 MIME-Version: 1.0 In-Reply-To: <33942b10-8eef-9180-44c5-b7379b92b824@linux.intel.com> Content-Language: en-US X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1601041198; bh=I3MevVq0rfThlib9stYezAlO6VoXyq/abMk8uS5Rf30=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding: Content-Language:X-Originating-IP:X-ClientProxiedBy; b=cT03BzeJw3AnIIrmEndxMyFxZGs1x1e+luerBaV6utLXOQpxqyHE0J35I/xDt+xhQ nR5XsHMTcB0Sg+P7pyDrtOk1sPUxKgkwNxDjh5LrmwZNkflEO0B+KyIXAPtShuGdZp BAkM4kyDxQzdIawJgqR//5croKMPwX5+yyb7UibsGX7XYCgs5+KQQNnOr3xu1koFWo l66mYjr0hXJexrdgIiX4ZJXsHGEllajD/0UevEWQGSQk7XBJszxIYwaFw0yubCntpL oG5dpHOEhdPi1skYh5ja8JQdJ+bII9s7XSD/ihYM9L8T/rsdj8ZZifbMGapnVBN7QJ rq56RmEyRwkhA== X-Mailman-Approved-At: Mon, 28 Sep 2020 07:06:24 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rdma@vger.kernel.org, intel-gfx@lists.freedesktop.org, Roland Scheidegger , dri-devel@lists.freedesktop.org, Maor Gottlieb , David Airlie , Doug Ledford , VMware Graphics , Christoph Hellwig Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Ck9uIDkvMjUvMjAyMCAzOjMzIFBNLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPgo+IE9uIDI1LzA5 LzIwMjAgMTM6MTgsIE1hb3IgR290dGxpZWIgd3JvdGU6Cj4+IE9uIDkvMjUvMjAyMCAyOjU1IFBN LCBKYXNvbiBHdW50aG9ycGUgd3JvdGU6Cj4+PiBPbiBGcmksIFNlcCAyNSwgMjAyMCBhdCAxMDox MzozMEFNICswMzAwLCBMZW9uIFJvbWFub3Zza3kgd3JvdGU6Cj4+Pj4+PiBkaWZmIC0tZ2l0IGEv dG9vbHMvdGVzdGluZy9zY2F0dGVybGlzdC9tYWluLmMgCj4+Pj4+PiBiL3Rvb2xzL3Rlc3Rpbmcv c2NhdHRlcmxpc3QvbWFpbi5jCj4+Pj4+PiBpbmRleCAwYTE0NjQxODEyMjYuLjQ4OTkzNTlhMzFh YyAxMDA2NDQKPj4+Pj4+ICsrKyBiL3Rvb2xzL3Rlc3Rpbmcvc2NhdHRlcmxpc3QvbWFpbi5jCj4+ Pj4+PiBAQCAtNTUsMTQgKzU1LDEzIEBAIGludCBtYWluKHZvaWQpCj4+Pj4+PiDCoMKgwqDCoMKg wqAgZm9yIChpID0gMCwgdGVzdCA9IHRlc3RzOyB0ZXN0LT5leHBlY3RlZF9zZWdtZW50czsgdGVz dCsrLCAKPj4+Pj4+IGkrKykgewo+Pj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0IHBh Z2UgKnBhZ2VzW01BWF9QQUdFU107Cj4+Pj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3Qg c2dfdGFibGUgc3Q7Cj4+Pj4+PiAtwqDCoMKgwqDCoMKgwqAgaW50IHJldDsKPj4+Pj4+ICvCoMKg wqDCoMKgwqDCoCBzdHJ1Y3Qgc2NhdHRlcmxpc3QgKnNnOwo+Pj4+Pj4KPj4+Pj4+IMKgwqDCoMKg wqDCoMKgwqDCoMKgIHNldF9wYWdlcyhwYWdlcywgdGVzdC0+cGZuLCB0ZXN0LT5udW1fcGFnZXMp Owo+Pj4+Pj4KPj4+Pj4+IC3CoMKgwqDCoMKgwqDCoCByZXQgPSBfX3NnX2FsbG9jX3RhYmxlX2Zy b21fcGFnZXMoJnN0LCBwYWdlcywgCj4+Pj4+PiB0ZXN0LT5udW1fcGFnZXMsCj4+Pj4+PiAtwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgMCwgdGVzdC0+ c2l6ZSwgdGVzdC0+bWF4X3NlZywKPj4+Pj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBHRlBfS0VSTkVMKTsKPj4+Pj4+IC3CoMKgwqDCoMKgwqDC oCBhc3NlcnQocmV0ID09IHRlc3QtPmFsbG9jX3JldCk7Cj4+Pj4+PiArwqDCoMKgwqDCoMKgwqAg c2cgPSBfX3NnX2FsbG9jX3RhYmxlX2Zyb21fcGFnZXMoJnN0LCBwYWdlcywgCj4+Pj4+PiB0ZXN0 LT5udW1fcGFnZXMsIDAsCj4+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHRl c3QtPnNpemUsIHRlc3QtPm1heF9zZWcsIE5VTEwsIDAsIEdGUF9LRVJORUwpOwo+Pj4+Pj4gK8Kg wqDCoMKgwqDCoMKgIGFzc2VydChQVFJfRVJSX09SX1pFUk8oc2cpID09IHRlc3QtPmFsbG9jX3Jl dCk7Cj4+Pj4+IFNvbWUgdGVzdCBjb3ZlcmFnZSBmb3IgcmVsYXRpdmVseSBjb21wbGV4IGNvZGUg d291bGQgYmUgdmVyeSAKPj4+Pj4gd2VsY29tZWQuIFNpbmNlCj4+Pj4+IHRoZSB0ZXN0aW5nIGZy YW1ld29yayBpcyBhbHJlYWR5IHRoZXJlLCBldmVuIGlmIGl0IGJpdC1yb3R0ZWQgYSAKPj4+Pj4g Yml0LCBidXQKPj4+Pj4gc2hvdWxkbid0IGJlIGhhcmQgdG8gZml4Lgo+Pj4+Pgo+Pj4+PiBBIGZl dyB0ZXN0cyB0byBjaGVjayBhcHBlbmQvZ3JvdyB3b3JrcyBhcyBleHBlY3RlZCwgaW4gdGVybXMg b2YgCj4+Pj4+IGhvdyB0aGUgZW5kCj4+Pj4+IHRhYmxlIGxvb2tzIGxpa2UgZ2l2ZW4gdGhlIGlu aXRpYWwgc3RhdGUgYW5kIHNvbWUgZGlmZmVyZW50IHBhZ2UgCj4+Pj4+IHBhdHRlcm5zCj4+Pj4+ IGFkZGVkIHRvIGl0LiBBbmQgYm90aCBjcm9zc2luZyBhbmQgbm90IGNyb3NzaW5nIGludG8gc2cg Y2hhaW5pbmcgCj4+Pj4+IHNjZW5hcmlvcy4KPj4+PiBUaGlzIGZ1bmN0aW9uIGlzIGJhc2ljIGZv ciBhbGwgUkRNQSBkZXZpY2VzIGFuZCB3ZSBhcmUgcHJldHR5IAo+Pj4+IGNvbmZpZGVudAo+Pj4+ IHRoYXQgdGhlIG9sZCBhbmQgbmV3IGZsb3dzIGFyZSB0ZXN0ZWQgdGhvcm91Z2hseS4KPj4+IFdl bGwsIHNpbmNlIDAtZGF5IGlzIHJlcG9ydGluZyB0aGF0IF9faTkxNV9nZW1fdXNlcnB0cl9hbGxv Y19wYWdlcyBpcwo+Pj4gY3Jhc2hpbmcgb24gdGhpcywgaXQgcHJvYmFibHkgZG9lcyBuZWVkIHNv bWUgdGVzdHMgOlwKPj4+Cj4+PiBKYXNvbgo+Pgo+PiBJdCBpcyBjcmFzaGluZyBpbiB0aGUgcmVn dWxhciBvbGQgZmxvdyB3aGljaCBhbHJlYWR5IHRlc3RlZC4KPj4gSG93ZXZlciwgSSB3aWxsIGFk ZCBtb3JlIHRlc3RzLgo+Cj4gRG8geW91IHdhbnQgdG8gdGFrZSBzb21lIG9mIHRoZSBjb21taXRz IGZyb20gCj4gZ2l0Oi8vcGVvcGxlLmZyZWVkZXNrdG9wLm9yZy9+dHVyc3VsaW4vZHJtLWludGVs IHNndGVzdD8gSXQgd291bGQgYmUgCj4gZmluZSBieSBtZS4gSSBjYW4gY2xlYW4gdXAgdGhlIGNv bW1pdCBtZXNzYWdlcyBpZiB5b3Ugd2FudC4KCkkgd2lsbCB2ZXJ5IGFwcHJlY2lhdGUgaXQuIFRo YW5rcwo+Cj4gaHR0cHM6Ly9jZ2l0LmZyZWVkZXNrdG9wLm9yZy9+dHVyc3VsaW4vZHJtLWludGVs L2NvbW1pdC8/aD1zZ3Rlc3QmaWQ9NzkxMDJmNGQ3OTVjNDc2OTQzMWZjNDRhNmNmN2VkNWM1YjFi NTIxNCAKPiAtIHRoaXMgb25lIHVuZG9lcyB0aGUgYml0IHJvdCBhbmQgbWFrZXMgdGhlIHRlc3Qg anVzdCB3b3JrIG9uIHRoZSAKPiBjdXJyZW50IGtlcm5lbC4KPgo+IGh0dHBzOi8vY2dpdC5mcmVl ZGVza3RvcC5vcmcvfnR1cnN1bGluL2RybS1pbnRlbC9jb21taXQvP2g9c2d0ZXN0JmlkPWIwOWJm ZTgwNDg2YzRkOTNlZTFkOGFlMTdkNWI0NjM5N2IxYzZlZTEgCj4gLSB0aGlzIG9uZSB5b3UgcHJv YmFibHkgc2hvdWxkIHNxdWFzaCBpbiB5b3VyIHBhdGNoLiBNaW51cyB0aGUgemVyb2luZyAKPiBv ZiBzdHJ1Y3Qgc2dfc3RhYmxlIHNpbmNlIHRoYXQgd291bGQgaGlkZSB0aGUgaXNzdWUuCj4KPiBo dHRwczovL2NnaXQuZnJlZWRlc2t0b3Aub3JnL350dXJzdWxpbi9kcm0taW50ZWwvY29tbWl0Lz9o PXNndGVzdCZpZD05N2Y1ZGYzN2U2MTJmNzk4Y2VkOTA1NDFlZWNlMTNlMmVmNjM5MTgxIAo+IC0g ZmluYWwgY29tbWl0IGlzIG9wdGlvbmFsIGJ1dCBJIGd1ZXNzIGhhbmR5IGZvciBkZWJ1Z2dpbmcu Cj4KPiBSZWdhcmRzLAo+Cj4gVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2575C4741F for ; Fri, 25 Sep 2020 15:37:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75D3420809 for ; Fri, 25 Sep 2020 15:37:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="cT03BzeJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75D3420809 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D924B6ED20; Fri, 25 Sep 2020 15:37:31 +0000 (UTC) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6B7E46EB29; Fri, 25 Sep 2020 13:40:12 +0000 (UTC) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 25 Sep 2020 06:39:58 -0700 Received: from [172.27.1.66] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 25 Sep 2020 13:39:56 +0000 To: Tvrtko Ursulin , Jason Gunthorpe , Leon Romanovsky References: <20200922083958.2150803-1-leon@kernel.org> <20200922083958.2150803-2-leon@kernel.org> <118a03ef-d160-e202-81cc-16c9c39359fc@linux.intel.com> <20200925071330.GA2280698@unreal> <20200925115544.GY9475@nvidia.com> <65ca566b-7a5e-620f-13a4-c59eb836345a@nvidia.com> <33942b10-8eef-9180-44c5-b7379b92b824@linux.intel.com> From: Maor Gottlieb Message-ID: <9d69d68d-7868-609b-c703-dfe9fec93a0f@nvidia.com> Date: Fri, 25 Sep 2020 16:39:53 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.1 MIME-Version: 1.0 In-Reply-To: <33942b10-8eef-9180-44c5-b7379b92b824@linux.intel.com> Content-Language: en-US X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1601041198; bh=I3MevVq0rfThlib9stYezAlO6VoXyq/abMk8uS5Rf30=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding: Content-Language:X-Originating-IP:X-ClientProxiedBy; b=cT03BzeJw3AnIIrmEndxMyFxZGs1x1e+luerBaV6utLXOQpxqyHE0J35I/xDt+xhQ nR5XsHMTcB0Sg+P7pyDrtOk1sPUxKgkwNxDjh5LrmwZNkflEO0B+KyIXAPtShuGdZp BAkM4kyDxQzdIawJgqR//5croKMPwX5+yyb7UibsGX7XYCgs5+KQQNnOr3xu1koFWo l66mYjr0hXJexrdgIiX4ZJXsHGEllajD/0UevEWQGSQk7XBJszxIYwaFw0yubCntpL oG5dpHOEhdPi1skYh5ja8JQdJ+bII9s7XSD/ihYM9L8T/rsdj8ZZifbMGapnVBN7QJ rq56RmEyRwkhA== X-Mailman-Approved-At: Fri, 25 Sep 2020 15:37:31 +0000 Subject: Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rdma@vger.kernel.org, intel-gfx@lists.freedesktop.org, Roland Scheidegger , dri-devel@lists.freedesktop.org, Maor Gottlieb , David Airlie , Doug Ledford , VMware Graphics , Christoph Hellwig Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Ck9uIDkvMjUvMjAyMCAzOjMzIFBNLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPgo+IE9uIDI1LzA5 LzIwMjAgMTM6MTgsIE1hb3IgR290dGxpZWIgd3JvdGU6Cj4+IE9uIDkvMjUvMjAyMCAyOjU1IFBN LCBKYXNvbiBHdW50aG9ycGUgd3JvdGU6Cj4+PiBPbiBGcmksIFNlcCAyNSwgMjAyMCBhdCAxMDox MzozMEFNICswMzAwLCBMZW9uIFJvbWFub3Zza3kgd3JvdGU6Cj4+Pj4+PiBkaWZmIC0tZ2l0IGEv dG9vbHMvdGVzdGluZy9zY2F0dGVybGlzdC9tYWluLmMgCj4+Pj4+PiBiL3Rvb2xzL3Rlc3Rpbmcv c2NhdHRlcmxpc3QvbWFpbi5jCj4+Pj4+PiBpbmRleCAwYTE0NjQxODEyMjYuLjQ4OTkzNTlhMzFh YyAxMDA2NDQKPj4+Pj4+ICsrKyBiL3Rvb2xzL3Rlc3Rpbmcvc2NhdHRlcmxpc3QvbWFpbi5jCj4+ Pj4+PiBAQCAtNTUsMTQgKzU1LDEzIEBAIGludCBtYWluKHZvaWQpCj4+Pj4+PiDCoMKgwqDCoMKg wqAgZm9yIChpID0gMCwgdGVzdCA9IHRlc3RzOyB0ZXN0LT5leHBlY3RlZF9zZWdtZW50czsgdGVz dCsrLCAKPj4+Pj4+IGkrKykgewo+Pj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0IHBh Z2UgKnBhZ2VzW01BWF9QQUdFU107Cj4+Pj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzdHJ1Y3Qg c2dfdGFibGUgc3Q7Cj4+Pj4+PiAtwqDCoMKgwqDCoMKgwqAgaW50IHJldDsKPj4+Pj4+ICvCoMKg wqDCoMKgwqDCoCBzdHJ1Y3Qgc2NhdHRlcmxpc3QgKnNnOwo+Pj4+Pj4KPj4+Pj4+IMKgwqDCoMKg wqDCoMKgwqDCoMKgIHNldF9wYWdlcyhwYWdlcywgdGVzdC0+cGZuLCB0ZXN0LT5udW1fcGFnZXMp Owo+Pj4+Pj4KPj4+Pj4+IC3CoMKgwqDCoMKgwqDCoCByZXQgPSBfX3NnX2FsbG9jX3RhYmxlX2Zy b21fcGFnZXMoJnN0LCBwYWdlcywgCj4+Pj4+PiB0ZXN0LT5udW1fcGFnZXMsCj4+Pj4+PiAtwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgMCwgdGVzdC0+ c2l6ZSwgdGVzdC0+bWF4X3NlZywKPj4+Pj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBHRlBfS0VSTkVMKTsKPj4+Pj4+IC3CoMKgwqDCoMKgwqDC oCBhc3NlcnQocmV0ID09IHRlc3QtPmFsbG9jX3JldCk7Cj4+Pj4+PiArwqDCoMKgwqDCoMKgwqAg c2cgPSBfX3NnX2FsbG9jX3RhYmxlX2Zyb21fcGFnZXMoJnN0LCBwYWdlcywgCj4+Pj4+PiB0ZXN0 LT5udW1fcGFnZXMsIDAsCj4+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHRl c3QtPnNpemUsIHRlc3QtPm1heF9zZWcsIE5VTEwsIDAsIEdGUF9LRVJORUwpOwo+Pj4+Pj4gK8Kg wqDCoMKgwqDCoMKgIGFzc2VydChQVFJfRVJSX09SX1pFUk8oc2cpID09IHRlc3QtPmFsbG9jX3Jl dCk7Cj4+Pj4+IFNvbWUgdGVzdCBjb3ZlcmFnZSBmb3IgcmVsYXRpdmVseSBjb21wbGV4IGNvZGUg d291bGQgYmUgdmVyeSAKPj4+Pj4gd2VsY29tZWQuIFNpbmNlCj4+Pj4+IHRoZSB0ZXN0aW5nIGZy YW1ld29yayBpcyBhbHJlYWR5IHRoZXJlLCBldmVuIGlmIGl0IGJpdC1yb3R0ZWQgYSAKPj4+Pj4g Yml0LCBidXQKPj4+Pj4gc2hvdWxkbid0IGJlIGhhcmQgdG8gZml4Lgo+Pj4+Pgo+Pj4+PiBBIGZl dyB0ZXN0cyB0byBjaGVjayBhcHBlbmQvZ3JvdyB3b3JrcyBhcyBleHBlY3RlZCwgaW4gdGVybXMg b2YgCj4+Pj4+IGhvdyB0aGUgZW5kCj4+Pj4+IHRhYmxlIGxvb2tzIGxpa2UgZ2l2ZW4gdGhlIGlu aXRpYWwgc3RhdGUgYW5kIHNvbWUgZGlmZmVyZW50IHBhZ2UgCj4+Pj4+IHBhdHRlcm5zCj4+Pj4+ IGFkZGVkIHRvIGl0LiBBbmQgYm90aCBjcm9zc2luZyBhbmQgbm90IGNyb3NzaW5nIGludG8gc2cg Y2hhaW5pbmcgCj4+Pj4+IHNjZW5hcmlvcy4KPj4+PiBUaGlzIGZ1bmN0aW9uIGlzIGJhc2ljIGZv ciBhbGwgUkRNQSBkZXZpY2VzIGFuZCB3ZSBhcmUgcHJldHR5IAo+Pj4+IGNvbmZpZGVudAo+Pj4+ IHRoYXQgdGhlIG9sZCBhbmQgbmV3IGZsb3dzIGFyZSB0ZXN0ZWQgdGhvcm91Z2hseS4KPj4+IFdl bGwsIHNpbmNlIDAtZGF5IGlzIHJlcG9ydGluZyB0aGF0IF9faTkxNV9nZW1fdXNlcnB0cl9hbGxv Y19wYWdlcyBpcwo+Pj4gY3Jhc2hpbmcgb24gdGhpcywgaXQgcHJvYmFibHkgZG9lcyBuZWVkIHNv bWUgdGVzdHMgOlwKPj4+Cj4+PiBKYXNvbgo+Pgo+PiBJdCBpcyBjcmFzaGluZyBpbiB0aGUgcmVn dWxhciBvbGQgZmxvdyB3aGljaCBhbHJlYWR5IHRlc3RlZC4KPj4gSG93ZXZlciwgSSB3aWxsIGFk ZCBtb3JlIHRlc3RzLgo+Cj4gRG8geW91IHdhbnQgdG8gdGFrZSBzb21lIG9mIHRoZSBjb21taXRz IGZyb20gCj4gZ2l0Oi8vcGVvcGxlLmZyZWVkZXNrdG9wLm9yZy9+dHVyc3VsaW4vZHJtLWludGVs IHNndGVzdD8gSXQgd291bGQgYmUgCj4gZmluZSBieSBtZS4gSSBjYW4gY2xlYW4gdXAgdGhlIGNv bW1pdCBtZXNzYWdlcyBpZiB5b3Ugd2FudC4KCkkgd2lsbCB2ZXJ5IGFwcHJlY2lhdGUgaXQuIFRo YW5rcwo+Cj4gaHR0cHM6Ly9jZ2l0LmZyZWVkZXNrdG9wLm9yZy9+dHVyc3VsaW4vZHJtLWludGVs L2NvbW1pdC8/aD1zZ3Rlc3QmaWQ9NzkxMDJmNGQ3OTVjNDc2OTQzMWZjNDRhNmNmN2VkNWM1YjFi NTIxNCAKPiAtIHRoaXMgb25lIHVuZG9lcyB0aGUgYml0IHJvdCBhbmQgbWFrZXMgdGhlIHRlc3Qg anVzdCB3b3JrIG9uIHRoZSAKPiBjdXJyZW50IGtlcm5lbC4KPgo+IGh0dHBzOi8vY2dpdC5mcmVl ZGVza3RvcC5vcmcvfnR1cnN1bGluL2RybS1pbnRlbC9jb21taXQvP2g9c2d0ZXN0JmlkPWIwOWJm ZTgwNDg2YzRkOTNlZTFkOGFlMTdkNWI0NjM5N2IxYzZlZTEgCj4gLSB0aGlzIG9uZSB5b3UgcHJv YmFibHkgc2hvdWxkIHNxdWFzaCBpbiB5b3VyIHBhdGNoLiBNaW51cyB0aGUgemVyb2luZyAKPiBv ZiBzdHJ1Y3Qgc2dfc3RhYmxlIHNpbmNlIHRoYXQgd291bGQgaGlkZSB0aGUgaXNzdWUuCj4KPiBo dHRwczovL2NnaXQuZnJlZWRlc2t0b3Aub3JnL350dXJzdWxpbi9kcm0taW50ZWwvY29tbWl0Lz9o PXNndGVzdCZpZD05N2Y1ZGYzN2U2MTJmNzk4Y2VkOTA1NDFlZWNlMTNlMmVmNjM5MTgxIAo+IC0g ZmluYWwgY29tbWl0IGlzIG9wdGlvbmFsIGJ1dCBJIGd1ZXNzIGhhbmR5IGZvciBkZWJ1Z2dpbmcu Cj4KPiBSZWdhcmRzLAo+Cj4gVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo=