From mboxrd@z Thu Jan 1 00:00:00 1970 From: Trilok Soni Subject: Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver Date: Thu, 29 Mar 2018 17:31:47 -0700 Message-ID: <9d6dad94-3e17-2ca6-2921-3f461e8315ca@codeaurora.org> References: <1522176722-12691-1-git-send-email-rishabhb@codeaurora.org> <1522176722-12691-3-git-send-email-rishabhb@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Stanimir Varbanov , Rishabh Bhatnagar , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: linux-arm@lists.infradead.org, linux-kernel@vger.kernel.org, kyan@codeaurora.org, ckadabi@codeaurora.org List-Id: linux-arm-msm@vger.kernel.org Hi Stanimir, +/* Get the slice entry by index */ >> +static struct llcc_slice_desc *llcc_slice_get_entry(struct device *dev, int n) > drop this *slice* word from function names Please note that we are activating/de-activating  a "slice" of the LLCC and not a whole LLCC. "slice" makes perfect sense here since the granularity is at the "slice" level and not the complete LLCC. --Trilok Soni From mboxrd@z Thu Jan 1 00:00:00 1970 From: tsoni@codeaurora.org (Trilok Soni) Date: Thu, 29 Mar 2018 17:31:47 -0700 Subject: [PATCH v3 2/2] drivers: soc: Add LLCC driver In-Reply-To: References: <1522176722-12691-1-git-send-email-rishabhb@codeaurora.org> <1522176722-12691-3-git-send-email-rishabhb@codeaurora.org> Message-ID: <9d6dad94-3e17-2ca6-2921-3f461e8315ca@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Stanimir, +/* Get the slice entry by index */ >> +static struct llcc_slice_desc *llcc_slice_get_entry(struct device *dev, int n) > drop this *slice* word from function names Please note that we are activating/de-activating? a "slice" of the LLCC and not a whole LLCC. "slice" makes perfect sense here since the granularity is at the "slice" level and not the complete LLCC. --Trilok Soni