From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753548AbdJCM0q (ORCPT <rfc822;w@1wt.eu>);
        Tue, 3 Oct 2017 08:26:46 -0400
Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:47772 "EHLO
        foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753537AbdJCM0m (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 3 Oct 2017 08:26:42 -0400
Subject: Re: [PATCH -v2 13/18] sched/fair: Propagate an effective
 runnable_load_avg
To: Peter Zijlstra <peterz@infradead.org>, mingo@kernel.org,
        linux-kernel@vger.kernel.org, tj@kernel.org, josef@toxicpanda.com
Cc: torvalds@linux-foundation.org, vincent.guittot@linaro.org,
        efault@gmx.de, pjt@google.com, clm@fb.com, morten.rasmussen@arm.com,
        bsegall@google.com, yuyang.du@intel.com
References: <20170901132059.342024223@infradead.org>
 <20170901132748.630232806@infradead.org>
From: Dietmar Eggemann <dietmar.eggemann@arm.com>
Message-ID: <9d710e98-2ab5-e181-4c9d-eef4e86f9bf0@arm.com>
Date: Tue, 3 Oct 2017 13:26:39 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20170901132748.630232806@infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/09/17 14:21, Peter Zijlstra wrote:

[...]

> @@ -3169,8 +3198,8 @@ ___update_load_sum(u64 now, int cpu, str
>  	 * this happens during idle_balance() which calls
>  	 * update_blocked_averages()
>  	 */

another nit-pick:

s/weight/load in comment above.

> -	if (!weight)
> -		running = 0;
> +	if (!load)
> +		runnable = running = 0;

[...]