From: Laurent Hardy <laurent.hardy@6wind.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>,
Ilya Maximets <i.maximets@samsung.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] net/ixgbe: fix busy polling while fiber link update
Date: Mon, 15 Oct 2018 12:43:23 +0200 [thread overview]
Message-ID: <9d740a33-0e4d-8773-69c4-f118482b7ee5@6wind.com> (raw)
In-Reply-To: <A2573D2ACFCADC41BB3BE09C6DE313CA07E4F2A0@PGSMSX103.gar.corp.intel.com>
Hi Wei,
On 10/12/2018 09:36 AM, Zhao1, Wei wrote:
>>>> Hi, laurent.hardy
>>>> You are the author for the patch (* net/ixgbe: ensure link status is
>> updated), why do you implement code that way?
>>>> Is that must that set up link with wait?
>>>>
>>>> ixgbe_setup_link(hw, speed, true);
>>>>
>> The main issue which has lead to this patch has been reported through a test
>> case with the autoneg enabled (which has been also reported in the pmd
>> test provided along with the patch:
>> http://patches.dpdk.org/comment/46253/).
>> In this context, without the flag set the patch wasn't effective.
> My question is whether we can change to:
>
> ixgbe_setup_link(hw, speed, false);
>
> in your patch, it is " ixgbe_setup_link(hw, speed, true);"
> some user may need flexible in wait for complete.
>
>
Yes, the parameter (autoneg_wait_to_complete) could be change to false.
I redo the test following test plan provided through
http://patches.dpdk.org/comment/46253/, with flag set to false
and speed defined to 1Gb on switch side.
In this case both ports goes properly up (nic used is 82599ES
10-Gigabit) with a correct link speed.
next prev parent reply other threads:[~2018-10-15 10:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180831123824eucas1p1cd2981c716c4764703e24c3eeb4d33c7@eucas1p1.samsung.com>
2018-08-31 12:39 ` [PATCH] net/ixgbe: fix busy polling while fiber link update Ilya Maximets
2018-09-04 6:08 ` Zhang, Qi Z
2018-09-10 15:08 ` Ilya Maximets
2018-09-12 6:49 ` Zhang, Qi Z
2018-09-12 8:05 ` Ilya Maximets
2018-09-12 8:28 ` Zhang, Qi Z
2018-09-21 14:25 ` Zhang, Qi Z
2018-10-03 7:43 ` Ilya Maximets
2018-10-09 10:22 ` Zhao1, Wei
2018-10-11 9:56 ` Zhao1, Wei
2018-10-11 10:26 ` Ilya Maximets
2018-10-11 12:21 ` Laurent Hardy
2018-10-12 7:36 ` Zhao1, Wei
2018-10-15 10:43 ` Laurent Hardy [this message]
2018-10-16 8:29 ` Zhao1, Wei
2018-10-12 9:19 ` Zhao1, Wei
2018-10-12 10:14 ` Ilya Maximets
2018-10-15 3:03 ` Zhao1, Wei
2018-10-15 8:40 ` Ilya Maximets
2018-10-16 8:59 ` Zhao1, Wei
2018-10-30 10:20 ` Ilya Maximets
2018-11-01 15:45 ` Zhang, Qi Z
2018-11-01 16:05 ` Ilya Maximets
[not found] ` <CGME20181101160505eucas1p1fcf268f3febaa80dcbb3e573b2fc2c68@eucas1p1.samsung.com>
2018-11-01 16:04 ` [PATCH v2] " Ilya Maximets
2018-11-02 13:49 ` Zhang, Qi Z
2018-11-07 15:52 ` Burakov, Anatoly
2018-11-08 10:27 ` Ilya Maximets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d740a33-0e4d-8773-69c4-f118482b7ee5@6wind.com \
--to=laurent.hardy@6wind.com \
--cc=dev@dpdk.org \
--cc=i.maximets@samsung.com \
--cc=konstantin.ananyev@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.