All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marcin Mirosław" <marcin@mejor.pl>
To: Kent Overstreet <kent.overstreet@gmail.com>
Cc: linux-bcache@vger.kernel.org
Subject: Re: [bcachefs][tier] kernel BUG at drivers/md/bcache/super.c:1561! after double changing state of device
Date: Fri, 26 Aug 2016 11:00:03 +0200	[thread overview]
Message-ID: <9d7942f4-4e8b-92b5-20de-5c7bec07f902@mejor.pl> (raw)
In-Reply-To: <20160826021029.upgpx4iji2opabjw@kmo-pixel>

W dniu 26.08.2016 o 04:10, Kent Overstreet pisze:
> On Thu, Aug 25, 2016 at 02:03:33PM +0200, Marcin Mirosław wrote:
>> https://lwn.net/Articles/655183/ :
>> "Caveat: don't try to use tiering and checksumming or compression at the
>> same time yet, the read path needs to be reworked to handle both at the
>> same time."
>>
>> Is it sill valid?
> 
> No, I did do that read path reworking, they should work.
> 
> However, I haven't been focusing on or exercising the multi device stuff in
> quite awhile - my main priority has been making single device filesystems rock
> solid and finishing off compression and such.
> 
> Tiering ought to work, but can you hold off on exercising anything else? e.g.
> the active/RO transition stuff - I'm going to have to spend a fair amount of
> time digging into that code and figuring out what makes sense when the time
> comes.

Ok, I'll focuse on one disk bcachefs.


> The checksum error is highly concerning though - that was related to messing
> with cache0/state, correct? I think Christopher is using tiering with
> checksumming enabled, can you confirm?

Yes, I only did echo "readonly", next "active" to >state. It was enough
to get BUG in kern.log.

Marcin

      parent reply	other threads:[~2016-08-26  9:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-25 10:59 [bcachefs][tier] kernel BUG at drivers/md/bcache/super.c:1561! after double changing state of device Marcin Mirosław
2016-08-25 11:04 ` Marcin Mirosław
2016-08-25 11:44   ` Marcin Mirosław
2016-08-25 12:03     ` Marcin Mirosław
2016-08-26  2:10       ` Kent Overstreet
2016-08-26  2:17         ` Christopher James Halse Rogers
2016-08-26  9:00         ` Marcin Mirosław [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d7942f4-4e8b-92b5-20de-5c7bec07f902@mejor.pl \
    --to=marcin@mejor.pl \
    --cc=kent.overstreet@gmail.com \
    --cc=linux-bcache@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.