From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD692C7EE22 for ; Tue, 9 May 2023 07:09:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 37FBE847A6; Tue, 9 May 2023 09:09:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=kontron.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=mysnt.onmicrosoft.com header.i=@mysnt.onmicrosoft.com header.b="hJ06Ehnq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7F3918472A; Tue, 9 May 2023 09:09:34 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20710.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d00::710]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 506AD847A6 for ; Tue, 9 May 2023 09:09:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=kontron.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=frieder.schrempf@kontron.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ghmA0b3AVAJCr2ubCw+Y8O1MWz39qJiuuXiRhCVW3UsAqZJFOm/dWbWq4OSdx67sXw7SQC73YC0XTAi34DT0InD8MJNBiE03gJXappFwWEomXfoKjjutbIM/aJq3KFFuRPF3kHmw5UQYJle2rjlKW56hxhRLXoYza9OOlfStv2HpKmld2vqHoSV7x+zPTGUVGtf/V6Wb5dTlsoZ6qR9gZ1leN7Zv1df1CFlEqeviNmp+Cc4nirAXO1kjp6ikh25tMtmJoW+8zTcl1g74VJlR7NQXSRALTHvl4Uu/wkh/inLmRoUkbM5sTgr2s4OJYaBqiowjyTIy1q7+wV30hsn6fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UDRGcBgSglpbQZAexbHQUFQiWrv6RK7R/L5eiA5GDFk=; b=k+AU5yk7ufEGNoEX6YlzGseElL89JcJZB3nSioG3CjpZA+A91uLuMl/x4wstheYv4xehF7/4RJE1jftJsdKEf2s39bovEQE2VjWaHOdNtywWsgmZM4z9jnsbBxguo8DyAlwTDFUwGJUBetDhnKGmczaa6O6K6ZncSpp21JiKLynrF7c6XGoKvm9jdcSPG6035XSPqOJwg6kwdCY/FQsKjzCa5bG5GvSCracM1wnHQJ2BSVEiXCDp24VcX6XzUoLScEGinSNBNq/NHHrX3oYQ1WJINNysWF12CDNZ84PftfrPqPcFpg6wAY6JOU8Fogm+HLBNVdZn9LBdZXcoYKDZdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kontron.de; dmarc=pass action=none header.from=kontron.de; dkim=pass header.d=kontron.de; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mysnt.onmicrosoft.com; s=selector2-mysnt-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UDRGcBgSglpbQZAexbHQUFQiWrv6RK7R/L5eiA5GDFk=; b=hJ06EhnqCmwKonW1yCqm0dkdr051DNY9Y/exW4uEvqTPFpT/ZOG244P9tmE+fPZRdr8S3lBh3QV4qL8zPe/e3Vn8UpN5h3K/WcaH2CfmgqOZc7icsgnamcwFhO4C6rX/wMxEOCblS2SiQkZhhHIX1BNjELRefxOzak0bfqtRosc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=kontron.de; Received: from AS4PR10MB5671.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:4f2::14) by AS1PR10MB5365.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:4af::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.29; Tue, 9 May 2023 07:09:31 +0000 Received: from AS4PR10MB5671.EURPRD10.PROD.OUTLOOK.COM ([fe80::7678:d3f0:47b:1f2]) by AS4PR10MB5671.EURPRD10.PROD.OUTLOOK.COM ([fe80::7678:d3f0:47b:1f2%4]) with mapi id 15.20.6363.033; Tue, 9 May 2023 07:09:30 +0000 Message-ID: <9d83d7ae-a69c-1584-fabf-c2dd0e1d1b67@kontron.de> Date: Tue, 9 May 2023 09:09:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 1/5] mtd/spinand: rework detect procedure for different READ_ID operation From: Frieder Schrempf To: Michael Nazzareno Trimarchi , Dario Binacchi Cc: Frieder Schrempf , u-boot@lists.denx.de, Jagan Teki , Mikhail Kshevetskiy , Miquel Raynal , Simon Glass , Stefan Roese , Tom Rini References: <20230110115843.391630-1-frieder@fris.de> Content-Language: en-US, de-DE In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS4P190CA0067.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:656::8) To AS4PR10MB5671.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:4f2::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB5671:EE_|AS1PR10MB5365:EE_ X-MS-Office365-Filtering-Correlation-Id: 09a9aa02-e97a-4d45-6c10-08db505c5596 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pmiE2C1sYbRzec8MHq+a7Bc0UWJwzMqrMrezS4warxyKWunW5MySA5p3JebU/hI5NwND5XLTvgygxvX1XeoYcWb3LmkBGN5GJYA0Ss4Rtvv9go+2VhBinfyrXiZx7tUd+nWpXGvem0+cg7gJ/OHpEi/SLDzgccs48+WeqEvVR9QZ7KRr+e0g/5WKP76rW0czpoBbkmh5POsnV5zYD5/OAcSYPP8OkKLOP5DioRMVk7+BRVof6V0DJko7lEDt2CZLjaXe/diNBw6TrHjL9b8puAgPWad02cK2EZ2J7c8AVgf/n0VeBYSkSZI0DhOjHp8rln+gi7SR7xfsqUxpBRdA5NZrDxeBrlySpToBDVC65No3mIBcRUF5u7dNHf921qzHI/JSqZNVO+mXaq20636QiuEk/+SpIKOrELTJ0DBgMMF797J7643Vwd7x50Mj7VByGwu0YB8ihPd08p9386DrJZURkXAx5rkSjInELbuCLKOcwbV3cWuajzpFgeaqMwqx5hU8hholpxRMdNP/5nu3jN88XIxabJZniznJtFQPkqzpeZBP4Q8GAWElq7+U17FuomtrOYQLKu5ha22zi7TiIkyg+qoFtscmm6tSdvpmjwaqp3Qd0C3bkYTnCeY6wDBDy75C1eSIzPNN3wR7ssN62w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS4PR10MB5671.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(366004)(39860400002)(396003)(136003)(376002)(451199021)(31686004)(53546011)(8936002)(6506007)(26005)(7416002)(2616005)(6512007)(8676002)(66476007)(2906002)(44832011)(83380400001)(478600001)(6486002)(4326008)(110136005)(66556008)(5660300002)(316002)(66946007)(186003)(54906003)(86362001)(41300700001)(36756003)(31696002)(38100700002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXBxZ3k5RysxS1FYOVNCaE5ydFJYUnV5OEVPcHFOQUNyUTZjdThQR3B4ZlF4?= =?utf-8?B?TEVJRlhBVUNWcVp0U0cwUUQ1TGJwZGRCc1RtZDlqMHRraERIc3BXR1FoNEVS?= =?utf-8?B?Q3RTb0hMS0M4MUZEbnlTK3ZuZnRHRVlISklwZnNlTldzY3JZdjhkU2tlZElQ?= =?utf-8?B?cE0wUVZRakhnMW1FRnRMbmdFelFVYnJnN215bE9nMVpQeFhaZE1LR0prZkov?= =?utf-8?B?dTYwanU4N200TmNQWFFuRHJkU0Q1dWpQNFNBc1MwaFU4aW1SdWFQbFhzVTM0?= =?utf-8?B?Qm1TNGdvYVNmcWNndk1FUERqQWNxUjJrY0gzVnF5SlUxOXI2a3k0dVdYbldX?= =?utf-8?B?Q3J0ZTZidzlYaDR0OEpPVWJNek5rN1IzS0h1eCtUVEFKbzhFeWExUmpXY2dx?= =?utf-8?B?eC9PNW8ycnpjZjgyeG5YdHhWNERway9xZnFIWWdjN3BxZGplSFpGVW00ZHB0?= =?utf-8?B?WHBXVWIyVTBkZU9FMHpzUTF5cWpTdUNSSnppYlY1STkzVGowRlhDYnV3dG53?= =?utf-8?B?OWlUOWMrSmx2SkNoazlyNkJSUmtHR0ZmeEtTaWtGbysxcmxtdXUrRjZjQW52?= =?utf-8?B?U3J1ajZvZVRRRVN4ak5CSXRualVSOFlJZGw4M04yc0xOelg2YmtTeml6U2hs?= =?utf-8?B?SkRrSjVjZW5PODF4SzFMUkNzS2F2aEh2VEIvUHFuUHgxRnpOTFppSkhZSTdo?= =?utf-8?B?bjlkSXZZMVZMUFpHUTRWR0haUit3blpXbENEN0FhQU50NjNvcmhUYVZKNHpU?= =?utf-8?B?eWRNdXlML3VDV1FMQVlXMlBmejFQT1BKTk9waTl2UktTNzVTVlNVMEpRdmRK?= =?utf-8?B?SDJQVmpSb2NXcTc1Q2FHK2Rzdng2QzY3ZlpPelJpazd6MElVNi8vT1NXdkhS?= =?utf-8?B?Q0xEdGZuYzd0MUxYRnpidHFKNVU3MlJJN1VUWTQrSmtheGJVMzRhLzViRjZQ?= =?utf-8?B?bGlPUTBsczROZktQMlFUT0JTT3MzUkVLTkgyVFo5TGtORFFUQ2pnM3M5U2Yv?= =?utf-8?B?Z2EwU0JlSlhBWXloY0NoRk4rajRxb1FMRjc1dm8xNGEwekd0ZlI1aHQ3dity?= =?utf-8?B?blUwWEhESUVzU3VGYlBBRkRybWNxVUl1U3dVYmFLY3BjWFdtRjcvYS9Iai9O?= =?utf-8?B?S29SNkxQY213N2RPSzVIUmVQcldWbzE2bTlUNkVUcVNYNEVKZjFjZ05haDRZ?= =?utf-8?B?UE5MeW5tNlRNVWFBb3hPMFZEeW85clhGaTdMTWljUGVMbVM1SFlWTncxUmVq?= =?utf-8?B?NEpDRkZRWXk5MkNQdjRLajhicURlWko0eXFWRS9Selptejk4ZUtmYUZuYndN?= =?utf-8?B?Ni8zUEdNQnA4aythaWl0QVlrMDZPMERNK2lUQlBYVXdmaGI3bmdkQVFtKzZZ?= =?utf-8?B?TnAwR0Y4UXdNU01CSS9mNTVlTVFzVHdLWWRDMTQwd2FXMEJiU2RGVXZGNVRj?= =?utf-8?B?WEJ2RXZUVnU2TzVRVHlrY1lFZGkvY1pRdHBuQmpyMituZUJOMDFyTDV4MHY1?= =?utf-8?B?VFQ1SkFXN3luYnFBS09VLzVQN1QydXU3eTRnaHh6RTkxYXhJWFg5OUNQSE9M?= =?utf-8?B?MGlsSVZRU2VneE5GcU5YTXlITWh0L05XQmZnQndKR0lvc3dncGRrWHdTeFBS?= =?utf-8?B?MVBYdkR6WGp2WGFaUDJBZlNUNWg4UzBQQ3g2MTBtL1hMK1dQUXhuOXV1Z3Zy?= =?utf-8?B?K2VrZFB3NFRNb3lLOGw4THlmYnNlSk1sMUZ4TE15T2t6L0F4WWZ4Mjh5M2Iy?= =?utf-8?B?ajNFTlU5WkJ6bERxSkpVNGJEckxlSUFLZmNtR1ZSQytoY0RzNGNVZDYreHA0?= =?utf-8?B?akV2cTh5NmJmV29KeWJuUFJEMkVvNUR4MVltWWl0eitCL3hsS2lDR2hmdGZD?= =?utf-8?B?L1VueHIwMUhBb0pSR1dCTTJmYmg5VDdiQXBObDBmNExtTHRUQWhPUmsraDdB?= =?utf-8?B?WjRDN0pUZjNwN3Q5UG5ScFhGMFBQNWwwZWluYjI3MkZkSzFmenNQN0VtQVZ6?= =?utf-8?B?Z2hXR0V3Y1NsTFBobzFwU1JZL1Z4bkFTZmtGakMvSGNmcUJrcHB4aktGM24z?= =?utf-8?B?Um03WG9QZ1V6YUhZcFU0dmNqeXBxUkVlZTBhY0l1MkJjTURlMmhtNm9XcDBU?= =?utf-8?B?Y2lUb2tuWmcwWmpYQ0t4dUpiQUNpUlFZWmtHbGlPL3BIa0RPUTI5TUtzLzdx?= =?utf-8?B?emc9PQ==?= X-OriginatorOrg: kontron.de X-MS-Exchange-CrossTenant-Network-Message-Id: 09a9aa02-e97a-4d45-6c10-08db505c5596 X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB5671.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2023 07:09:30.8474 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gYqMDCtnQ9OwlZE8ZVf1w1Uyh//EQUs0WdqgGwTpw3FCfpXugi5rwFbjgd5oBS/0gLN3GiOPfBnUu4amyUzImWO8W0f3h+Kn4mh1K+ai73c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR10MB5365 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Michael, hi Dario, On 18.04.23 15:46, Frieder Schrempf wrote: > Hi Michael, Dario, > > On 28.03.23 09:57, Frieder Schrempf wrote: >> Hi Michael, >> >> On 10.02.23 12:57, Michael Nazzareno Trimarchi wrote: >>> Hi >>> >>> I will review >>> >>> On Thu, Feb 9, 2023 at 5:52 PM Tom Rini wrote: >>>> >>>> On Thu, Feb 09, 2023 at 10:24:47AM +0100, Frieder Schrempf wrote: >>>>> Hi, >>>>> >>>>> On 10.01.23 12:58, Frieder Schrempf wrote: >>>>>> From: Mikhail Kshevetskiy >>>>>> >>>>>> Currently there are 3 different variants of read_id implementation: >>>>>> 1. opcode only. Found in GD5FxGQ4xF. >>>>>> 2. opcode + 1 addr byte. Found in GD5GxGQ4xA/E >>>>>> 3. opcode + 1 dummy byte. Found in other currently supported chips. >>>>>> >>>>>> Original implementation was for variant 1 and let detect function >>>>>> of chips with variant 2 and 3 to ignore the first byte. This isn't >>>>>> robust: >>>>>> >>>>>> 1. For chips of variant 2, if SPI master doesn't keep MOSI low >>>>>> during read, chip will get a random id offset, and the entire id >>>>>> buffer will shift by that offset, causing detect failure. >>>>>> >>>>>> 2. For chips of variant 1, if it happens to get a devid that equals >>>>>> to manufacture id of variant 2 or 3 chips, it'll get incorrectly >>>>>> detected. >>>>>> >>>>>> This patch reworks detect procedure to address problems above. New >>>>>> logic do detection for all variants separatedly, in 1-2-3 order. >>>>>> Since all current detect methods do exactly the same id matching >>>>>> procedure, unify them into core.c and remove detect method from >>>>>> manufacture_ops. >>>>>> >>>>>> This is a rework of Chuanhong Guo patch >>>>>> submitted to linux kernel >>>>>> >>>>>> Signed-off-by: Mikhail Kshevetskiy >>>>>> Signed-off-by: Frieder Schrempf >>>>> >>>>> +Cc: Jagan, Tom >>>>> >>>>> Who is supposed to pick up these patches? Some of them have been around >>>>> for some months (before I resent them). >>>>> >>>>> There is no maintainer for drivers/mtd/spinand/ and no maintainer for >>>>> drivers/mtd/ in general. >>>>> >>>>> In Patchwork Jagan got assigned, but the get_maintainer.pl script didn't >>>>> even add him to Cc, of course. >>>>> >>>>> Any ideas how to proceed? >>>> >>>> We don't have anyone dedicated to that area, yes, sadly. I've added >>>> Michael and Dario as they've also been doing mtd-but-not-spi work of >>>> late to see if they're interested. Or since you've long been working >>>> here, would you like to more formally maintain the area? Thanks! >>> >>> They can come from our tree. I will try to sort out all my duties weeked >> >> Any news regarding reviewing/picking these patches? > > Ping! > > Can you please apply these patches, that have been waiting for so long? I still can't see this applied anywhere. You already told me to take care of it multiple times. Can you please get it done? Thanks Frieder